From: Dennis Chen <kernel.org.gnu@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev <netdev@vger.kernel.org>, Miller <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] net: Prevent multiple NAPI instances co-existing in the list
Date: Fri, 9 Jan 2015 10:50:53 +0800 [thread overview]
Message-ID: <CA+U0gVha8nvWy2=c4qv+nKczGvsF9z-q2Pi5rPBwfHWRViO-Wg@mail.gmail.com> (raw)
In-Reply-To: <20150109023421.GA16089@gondor.apana.org.au>
On Fri, Jan 9, 2015 at 10:34 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Fri, Jan 09, 2015 at 10:32:13AM +0800, Dennis Chen wrote:
>>
>> Thanks, would you pls give me an example of those drivers? I'll study
>> it further...
>
> There are no known drivers doing this currently since that would
> be a bug and they would be fixed quickly. But if you look back
> in history virtio_net was doing this.
>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
So the only reason for the code '!list_empty()' I can see is to avoid
possible bug code in new drivers, thus pls think if it's possible
that there's a window opened for creating multiple NAPI instances in
the list for the new drivers?
--
Den
next prev parent reply other threads:[~2015-01-09 2:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 8:22 [PATCH] net: Prevent multiple NAPI instances co-existing in the list Dennis Chen
2015-01-08 11:15 ` Herbert Xu
2015-01-09 2:24 ` Dennis Chen
2015-01-09 2:27 ` Herbert Xu
2015-01-09 2:32 ` Dennis Chen
2015-01-09 2:34 ` Herbert Xu
2015-01-09 2:50 ` Dennis Chen [this message]
2015-01-09 3:07 ` Dennis Chen
2015-01-08 13:04 ` Sergei Shtylyov
2015-01-09 2:28 ` Dennis Chen
2015-01-08 14:51 ` Eric Dumazet
2015-01-09 2:26 ` Dennis Chen
2015-01-09 3:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+U0gVha8nvWy2=c4qv+nKczGvsF9z-q2Pi5rPBwfHWRViO-Wg@mail.gmail.com' \
--to=kernel.org.gnu@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).