From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: Christian Riesch <christian.riesch@omicron.at>
Cc: netdev <netdev@vger.kernel.org>, Jon Ringle <jon@ringle.org>,
Florian Fainelli <f.fainelli@gmail.com>,
dlos <davinci-linux-open-source@linux.davincidsp.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq
Date: Thu, 6 Mar 2014 11:08:18 +0530 [thread overview]
Message-ID: <CA+V-a8u3HChveLMuncWmXpeMhFgj1Bj4urLK1-gCOafAd0JxVg@mail.gmail.com> (raw)
In-Reply-To: <2ec3bb89-89db-48e8-b360-369545a2546f@mary.at.omicron.at>
Hi Christian,
Thanks for the patch.
On Wed, Mar 5, 2014 at 3:55 PM, Christian Riesch
<christian.riesch@omicron.at> wrote:
> In commit 6892b41d9701283085b655c6086fb57a5d63fa47
>
> Author: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Date: Tue Jun 25 21:24:51 2013 +0530
> net: davinci: emac: Convert to devm_* api
>
> the call of request_irq is replaced by devm_request_irq and the call
> of free_irq is removed. But since interrupts are requested in
> emac_dev_open, doing ifconfig up/down on the board requests the
> interrupts again each time, causing devm_request_irq to fail.
>
> This patch reverts said commit partially: It changes the driver back
> to use request_irq instead of devm_request_irq, puts free_irq back in
> place, but keeps the remaining changes of the original patch.
>
> Reported-by: Jon Ringle <jon@ringle.org>
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> Cc: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Cc: <stable@vger.kernel.org>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar lad
next prev parent reply other threads:[~2014-03-06 5:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 10:25 [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq Christian Riesch
2014-03-06 5:38 ` Prabhakar Lad [this message]
2014-03-06 8:27 ` Mugunthan V N
2014-03-06 8:51 ` Christian Riesch
[not found] ` <A8464B1127B9570790254336@172.22.2.41>
2014-03-06 17:16 ` Florian Fainelli
2014-03-06 21:57 ` David Miller
[not found] ` <20140306.165736.154818699714315258.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-03-07 2:28 ` Christian Riesch
2014-03-07 6:44 ` Christian Riesch
2014-03-07 11:42 ` Christian Riesch
2014-03-07 14:07 ` [PATCH RFC] net: davinci_emac: Fix rollback of emac_dev_open() Christian Riesch
[not found] ` <130fa9cb-7e94-4698-ac3f-f987a03c0604-2Q1zT/7oKKveau+zUrS5eLNldLUNz+W/@public.gmane.org>
2014-03-07 14:45 ` Mugunthan V N
2014-03-10 7:16 ` Christian Riesch
[not found] ` <851BA4133600BADF3FBB6427@172.22.2.41>
2014-03-13 18:17 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8u3HChveLMuncWmXpeMhFgj1Bj4urLK1-gCOafAd0JxVg@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=christian.riesch@omicron.at \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=f.fainelli@gmail.com \
--cc=jon@ringle.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).