From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: References: <20180222115307.15063-1-zongbox@gmail.com> From: Zong Li Date: Fri, 23 Feb 2018 15:05:25 +0800 Message-ID: Subject: Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU' To: Anders Roxell Cc: shuah@kernel.org, Vincent Legoll , ast@kernel.org, daniel@iogearbox.net, mcgrof@kernel.org, davem@davemloft.net, Kees Cook , Fathi Boudra , netdev@vger.kernel.org, Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org, zong@andestech.com, greentime@andestech.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: 2018-02-23 3:57 GMT+08:00 Anders Roxell : > On 22 February 2018 at 12:53, Zong Li wrote: >> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig >> to ease disabling it all")', the make kselftest-merge cannot merge the >> config dependencies of kselftest to the existing .config file. >> >> These config dependencies of kselftest need to enable the >> 'CONFIG_RUNTIME_TESTING_MENU=y' at the same time. > > Is this patch needed when patch sha 'f29c79906064 ("lib/Kconfig.debug: enable > RUNTIME_TESTING_MENU")' find its way into the kernel ? > I think it's in linux-next now. Thanks. The patch sha 'f29c79906064 ("lib/Kconfig.debug: enable RUNTIME_TESTING_MENU")' can resolve the make kselftest-merge on default situation, but I think the kselftest-merge should resolve the dependencies without the prerequisite, it should enable the 'RUNTIME_TESTING_MENU' when merging the config of some selftests if RUNTIME_TESTING_MENU is not set. Best Regards, Zong Li