* [PATCH net-next] net: dsa: sja1105: Make two functions static
@ 2019-06-11 13:58 YueHaibing
2019-06-11 18:31 ` Vladimir Oltean
2019-06-13 20:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-06-11 13:58 UTC (permalink / raw)
To: davem, olteanv, andrew, vivien.didelot, f.fainelli
Cc: linux-kernel, netdev, YueHaibing
Fix sparse warnings:
drivers/net/dsa/sja1105/sja1105_main.c:1848:6:
warning: symbol 'sja1105_port_rxtstamp' was not declared. Should it be static?
drivers/net/dsa/sja1105/sja1105_main.c:1869:6:
warning: symbol 'sja1105_port_txtstamp' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/dsa/sja1105/sja1105_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index 81e1ba5..9395e8f 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -1845,8 +1845,8 @@ static void sja1105_rxtstamp_work(struct work_struct *work)
}
/* Called from dsa_skb_defer_rx_timestamp */
-bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
- struct sk_buff *skb, unsigned int type)
+static bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
+ struct sk_buff *skb, unsigned int type)
{
struct sja1105_private *priv = ds->priv;
struct sja1105_tagger_data *data = &priv->tagger_data;
@@ -1866,8 +1866,8 @@ bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
* the skb and have it available in DSA_SKB_CB in the .port_deferred_xmit
* callback, where we will timestamp it synchronously.
*/
-bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
- struct sk_buff *skb, unsigned int type)
+static bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
+ struct sk_buff *skb, unsigned int type)
{
struct sja1105_private *priv = ds->priv;
struct sja1105_port *sp = &priv->ports[port];
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: sja1105: Make two functions static
2019-06-11 13:58 [PATCH net-next] net: dsa: sja1105: Make two functions static YueHaibing
@ 2019-06-11 18:31 ` Vladimir Oltean
2019-06-13 20:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2019-06-11 18:31 UTC (permalink / raw)
To: YueHaibing
Cc: David S. Miller, Andrew Lunn, Vivien Didelot, Florian Fainelli,
lkml, netdev
On Tue, 11 Jun 2019 at 16:59, YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix sparse warnings:
>
> drivers/net/dsa/sja1105/sja1105_main.c:1848:6:
> warning: symbol 'sja1105_port_rxtstamp' was not declared. Should it be static?
> drivers/net/dsa/sja1105/sja1105_main.c:1869:6:
> warning: symbol 'sja1105_port_txtstamp' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/dsa/sja1105/sja1105_main.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
> index 81e1ba5..9395e8f 100644
> --- a/drivers/net/dsa/sja1105/sja1105_main.c
> +++ b/drivers/net/dsa/sja1105/sja1105_main.c
> @@ -1845,8 +1845,8 @@ static void sja1105_rxtstamp_work(struct work_struct *work)
> }
>
> /* Called from dsa_skb_defer_rx_timestamp */
> -bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
> - struct sk_buff *skb, unsigned int type)
> +static bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
> + struct sk_buff *skb, unsigned int type)
> {
> struct sja1105_private *priv = ds->priv;
> struct sja1105_tagger_data *data = &priv->tagger_data;
> @@ -1866,8 +1866,8 @@ bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
> * the skb and have it available in DSA_SKB_CB in the .port_deferred_xmit
> * callback, where we will timestamp it synchronously.
> */
> -bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
> - struct sk_buff *skb, unsigned int type)
> +static bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
> + struct sk_buff *skb, unsigned int type)
> {
> struct sja1105_private *priv = ds->priv;
> struct sja1105_port *sp = &priv->ports[port];
> --
> 2.7.4
>
>
Tested-by: Vladimir Oltean <olteanv@gmail.com>
Thanks!
-Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: sja1105: Make two functions static
2019-06-11 13:58 [PATCH net-next] net: dsa: sja1105: Make two functions static YueHaibing
2019-06-11 18:31 ` Vladimir Oltean
@ 2019-06-13 20:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-13 20:59 UTC (permalink / raw)
To: yuehaibing
Cc: olteanv, andrew, vivien.didelot, f.fainelli, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 11 Jun 2019 21:58:34 +0800
> Fix sparse warnings:
>
> drivers/net/dsa/sja1105/sja1105_main.c:1848:6:
> warning: symbol 'sja1105_port_rxtstamp' was not declared. Should it be static?
> drivers/net/dsa/sja1105/sja1105_main.c:1869:6:
> warning: symbol 'sja1105_port_txtstamp' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-13 20:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-11 13:58 [PATCH net-next] net: dsa: sja1105: Make two functions static YueHaibing
2019-06-11 18:31 ` Vladimir Oltean
2019-06-13 20:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).