From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ADCFC43331 for ; Tue, 24 Mar 2020 14:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C4F420774 for ; Tue, 24 Mar 2020 14:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="irDlWpE/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728181AbgCXOv5 (ORCPT ); Tue, 24 Mar 2020 10:51:57 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:33044 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbgCXOv5 (ORCPT ); Tue, 24 Mar 2020 10:51:57 -0400 Received: by mail-ed1-f66.google.com with SMTP id z65so21036889ede.0 for ; Tue, 24 Mar 2020 07:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BitOKWYAB15K8l6XPKgTKsrQsxhragpTR3WjMqDcOeU=; b=irDlWpE/xlxWdTrSaM21n2l4DGYlYcK2KDcIHkiYyUbvQ+aW7TM9/4Xe7MxmjTvuG6 qX32UFZDi3XcUvG+zuwLaSnEqCZ2PB2GohgRF9PhXf9Xw12VyaamwHrA8caSQBttyVSn qWyKL97YgMhHMRTlO295R1DvpjhyuzLzb3dlNq+oqvd9YSTXXOmHXtoQbRbwHq79Qxq1 U/HkuKKEUTyV5zETjGBzhOEBCcma+VB+8CssNpAcDd5aVBb7uu0VODhm8G/W0aeRcXyb sR+w8lONDrW6Fe9aB2KGmVc1fKGQx3dioa67his7cIPooB9gEimK/ftEplyB/OTncgHL 4Zcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BitOKWYAB15K8l6XPKgTKsrQsxhragpTR3WjMqDcOeU=; b=t700YFRb1hq8GkpNJ9aXrCC2e5UX2ffVnDjaMyPIo7BjWwnrjWi39zjZA+qfuomZUw rbRDk1ayCjx2UiK+VirjSBftdET88fra9w1hz99cighfaQFUp+Xps7rJbjA5E68mZElI XfrE5ni778NHbsTTVd5LFF0V3m65B5tzfXGccdoLsZn6fwkDUDM+fyhtvZyomhgwtPNt 5c1eMVn9nbbqlEFHFBle4sZKtcLXQHCqw8Fg1mTCjQFPyJulfQY2NDCDkCpoVKFwLBre I+EUCS3EEtWyzeyg1EiDds26/rdHcE+uNm47O9ROiFhMNUFD1INBwz6UGjdh6cRL9QFO limw== X-Gm-Message-State: ANhLgQ3lA4Nw/dxz56VAZ1Xlj7OOU7bQrZt+ODY0aVvSbNW9HuiGPL2Q uxRD/ow6ltD0sXDi2UoNL1z6lEb0y8GnfKN4A6bICZim6DI= X-Google-Smtp-Source: ADFU+vt9hTFGrJY0EyUsPLXRceqpL0FjHWlC8Z4McQSRgEXhQkBfaMhJ0tdCPutHZZ4KShySYsGpKbCHkF5IODO8XcI= X-Received: by 2002:a17:906:fc18:: with SMTP id ov24mr2482453ejb.189.1585061515911; Tue, 24 Mar 2020 07:51:55 -0700 (PDT) MIME-Version: 1.0 References: <20200324141358.4341-1-olteanv@gmail.com> <20200324141829.GB14512@lunn.ch> <158506137648.157373.6196697912192436523@kwain> In-Reply-To: <158506137648.157373.6196697912192436523@kwain> From: Vladimir Oltean Date: Tue, 24 Mar 2020 16:51:44 +0200 Message-ID: Subject: Re: [PATCH net-next] net: phy: mscc: consolidate a common RGMII delay implementation To: Antoine Tenart Cc: Andrew Lunn , "David S. Miller" , netdev , Florian Fainelli , Heiner Kallweit Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 24 Mar 2020 at 16:49, Antoine Tenart w= rote: > > Hi Vladimir, > > Quoting Andrew Lunn (2020-03-24 15:18:29) > > On Tue, Mar 24, 2020 at 04:13:58PM +0200, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > It looks like the VSC8584 PHY driver is rolling its own RGMII delay > > > configuration code, despite the fact that the logic is mostly the sam= e. > > > > > > In fact only the register layout and position for the RGMII controls = has > > > changed. So we need to adapt and parameterize the PHY-dependent bit > > > fields when calling the new generic function. > > > > > > Signed-off-by: Vladimir Oltean > > > > Reviewed-by: Andrew Lunn > > Tested-by: Antoine Tenart > > Thanks! > Antoine > > -- > Antoine T=C3=A9nart, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Thanks for testing, Antoine!