From: Tom Herbert <therbert@google.com>
To: Jesse Gross <jesse@nicira.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 8/8] vxlan: Add support for zero UDP6 checksums
Date: Mon, 12 May 2014 16:35:21 -0700 [thread overview]
Message-ID: <CA+mtBx-0GHNRZ+midMYa4SNv33jmF62Cgv2Y188JqPnx7NH5bg@mail.gmail.com> (raw)
In-Reply-To: <CAEP_g=9BTrUN48uV2teyufmG7QPZHmYsMrvWOBs9JhJam2oOVw@mail.gmail.com>
On Mon, May 12, 2014 at 2:41 PM, Jesse Gross <jesse@nicira.com> wrote:
> On Mon, May 12, 2014 at 9:59 AM, Tom Herbert <therbert@google.com> wrote:
>> @@ -1756,7 +1754,8 @@ int vxlan_xmit_skb(struct vxlan_sock *vs,
>> uh->source = src_port;
>>
>> uh->len = htons(skb->len);
>> - uh->check = 0;
>> +
>> + udp_set_csum(vs->sock->sk, skb, src, dst, skb->len);
>
> How does this interact with inner checksum offloading? I don't think
> that we have any infrastructure to support computing two checksums on
> a packet yet.
Right, as it stands now we could overwrite the csum offload parameters
for the inner header which would be a problem. I will fix that.
The ability to offload two csums in TX could be quite useful for
encapsulations like vxlan. I don't know if any HW is planning to
support that...
next prev parent reply other threads:[~2014-05-12 23:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 16:59 [PATCH 8/8] vxlan: Add support for zero UDP6 checksums Tom Herbert
2014-05-12 21:41 ` Jesse Gross
2014-05-12 23:35 ` Tom Herbert [this message]
2014-05-13 0:13 ` Jesse Gross
2014-05-13 18:27 ` Or Gerlitz
2014-05-13 22:48 ` David Miller
2014-05-13 22:59 ` Tom Herbert
2014-05-14 10:29 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+mtBx-0GHNRZ+midMYa4SNv33jmF62Cgv2Y188JqPnx7NH5bg@mail.gmail.com \
--to=therbert@google.com \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).