From: Tom Herbert <therbert@google.com>
To: David Miller <davem@davemloft.net>
Cc: Or Gerlitz <ogerlitz@mellanox.com>, Jerry Chu <hkchu@google.com>,
Eric Dumazet <edumazet@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Linux Netdev List <netdev@vger.kernel.org>,
Yan Burman <yanb@mellanox.com>,
Shlomo Pongratz <shlomop@mellanox.com>
Subject: Re: [PATCH net-next V2 1/3] net: Add GRO support for UDP encapsulating protocols
Date: Tue, 7 Jan 2014 13:40:57 -0800 [thread overview]
Message-ID: <CA+mtBx_fo3UHZ3n4vFDGvc832bV4ZRPZ8TjAWzruMDybDrRWsQ@mail.gmail.com> (raw)
In-Reply-To: <20140107.161958.2246599406178837029.davem@davemloft.net>
On Tue, Jan 7, 2014 at 1:19 PM, David Miller <davem@davemloft.net> wrote:
> From: Or Gerlitz <ogerlitz@mellanox.com>
> Date: Tue, 7 Jan 2014 17:29:52 +0200
>
>> +#define MAX_UDP_PORT (1 << 16)
>> +extern const struct net_offload __rcu *udp_offloads[MAX_UDP_PORT];
>
> Bloating the kernel up by half a megabyte just for this feature is
> beyond unacceptable.
For now we should have at most handful of encapsulation ports (maybe
5?) so a linear lookup in a simple array should suffice. If we get
into more complex scenarios, like using connected UDP sockets to get
encapsulation through NAT boxes, then we would need something more
complex (maybe socket lookup).
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-07 21:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 15:29 [PATCH net-next V2 0/3] net: Add GRO support for UDP encapsulating protocols Or Gerlitz
2014-01-07 15:29 ` [PATCH net-next V2 1/3] " Or Gerlitz
2014-01-07 16:33 ` Eric Dumazet
2014-01-07 20:19 ` Or Gerlitz
2014-01-07 20:32 ` Eric Dumazet
2014-01-07 20:37 ` Or Gerlitz
2014-01-07 21:38 ` Eric Dumazet
2014-01-08 8:04 ` Or Gerlitz
[not found] ` <1389182291.26646.79.camel@edumazet-glaptop2.roam.corp.google.com>
2014-01-08 12:15 ` Or Gerlitz
2014-01-07 22:11 ` Jerry Chu
2014-01-08 8:02 ` Or Gerlitz
2014-01-09 3:12 ` Jerry Chu
2014-01-09 6:35 ` Or Gerlitz
2014-01-09 7:19 ` Or Gerlitz
2014-01-07 18:44 ` Tom Herbert
2014-01-07 20:21 ` Or Gerlitz
2014-01-07 23:04 ` Tom Herbert
2014-01-08 16:11 ` Or Gerlitz
2014-01-08 16:29 ` Tom Herbert
2014-01-08 16:31 ` Or Gerlitz
2014-01-07 21:19 ` David Miller
2014-01-07 21:40 ` Tom Herbert [this message]
2014-01-07 15:29 ` [PATCH net-next V2 2/3] net: Export gro_find_by_type helpers Or Gerlitz
2014-01-07 15:29 ` [PATCH net-next V2 3/3] net: Add GRO support for vxlan traffic Or Gerlitz
2014-01-07 16:34 ` Eric Dumazet
2014-01-07 19:43 ` Or Gerlitz
2014-01-07 20:04 ` Eric Dumazet
2014-01-07 20:10 ` Or Gerlitz
2014-01-07 18:08 ` Tom Herbert
2014-01-07 19:43 ` Or Gerlitz
2014-01-07 20:02 ` Eric Dumazet
2014-01-07 20:12 ` Or Gerlitz
2014-01-07 21:09 ` Tom Herbert
2014-01-08 9:45 ` Or Gerlitz
[not found] ` <CAJZOPZLsMvmHwmMjhsuKb__2HncMXMm=p6UFnT4XX5d8hZnGxw@mail.gmail.com>
2014-01-07 19:52 ` Tom Herbert
2014-01-07 16:45 ` [PATCH net-next V2 0/3] net: Add GRO support for UDP encapsulating protocols Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+mtBx_fo3UHZ3n4vFDGvc832bV4ZRPZ8TjAWzruMDybDrRWsQ@mail.gmail.com \
--to=therbert@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=shlomop@mellanox.com \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).