From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C8AC1487C7 for ; Fri, 16 Feb 2024 23:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708125013; cv=none; b=ML1uHddI2uiYMAWXurzLyWWALSjyKAiQcx3NGrBgZiyVCV0tWehmMqXLdoAmjSimebQKQM6UT2o4Bhjal551oenKkiUg0rQSQQsxvDw/BmFuz7bbrZLy8iN7eNQKKUeF5QLNXeZVfehPhr3nsm6y3YzzZeBxOuYczHOCi5MXzQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708125013; c=relaxed/simple; bh=mfmEA6zSa+OORWqKlFgSku5kK5nwRZdQXnKi8D/SPd8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Y/Fwk23B/7cnwhSCXtErtOroFRgFtYc4Dy0XiuylCmYgRLylktLvL3EeVtHMSSO8ALWxdqkh4VojpiVsizT5LlLsvRb3ID4/taM/hNr8U1w4Fa4i0ki1KJ/tlZ1Pz0wV0aPVAI8pGLmcwkWXZmBZi4kLuOJikYLXcDulr+kpkHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AOXSXFWr; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AOXSXFWr" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-607fe8cc6d8so9763827b3.1 for ; Fri, 16 Feb 2024 15:10:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708125010; x=1708729810; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EpftqacOdWcIxz3VUpc3zI1U/E0RwbiBZdYsX7Kb7J4=; b=AOXSXFWrpecqGsj3FvbdDQIjHjP887SkBI4Bl4qgqmEyp6wk619/ClmzdoNIeOtz1j tDFBRTTZ4BXijtr5HVAG7cqu0BwWijfc2LxgvgRliDfPlGHPIGKzJIhHQjwHJelHjVyQ rp/dpDg/lvX62bGEdspeYlpgcqI7rCHt98CpiYsWMLSCTyHysVsLgsH/Mi9PXkv8IZPW RnrDP9WUVm04kHfQ67x4VehA87dgAMMC2vEyqSy2YCDH6nUvxKMvEaFL93I/+w8AsTPZ 1hRoKNSn/OHxCPYYv+J9IC1EJfc+1aBHZQcbLbRU6Wlr1XeozRteflUVXWLLrhaypy2B //xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708125010; x=1708729810; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EpftqacOdWcIxz3VUpc3zI1U/E0RwbiBZdYsX7Kb7J4=; b=k8PLaqm2OlYzEuKaVknW57e4Kp2hrhEaqStsaEwLc6QkcA/56yPJ/oi9TPyg9h4y8d qaXUvIds0luRInP9vT8RjBhtD/zYbFsuPGTjyOYsGvoiQYwFfFYmlcl236O9KZFC398p LjIKAmZpR4rPqA1rpiZa6c183efL303aH9Pxp8Bwvp+rjDfr2v1+P4sJx3DQLr5qIUDA 91kHXqh3dkJLZGkyu/BEVEZ2IlpTSAOsF8rRIN3FcZqNY+fFT1Z9y5rKVT38/ikEpAcY CKIEyg4B5NjsOwgL6v3+qcUnLT3cFywRCjJTbSIT11wIOmTy5KbYGwJIAY9ru5BzsK9h +5Yw== X-Forwarded-Encrypted: i=1; AJvYcCXw7av8TurU6Nk0xQIZYSPG9H7AeWI9RR/xhF4vrG00GF2NaMpT7/ZH52GhqZTcpTxYzoX2lOVwhhNAixEBAXZpCourKGMB X-Gm-Message-State: AOJu0YzRjsOpIzlz7AzI8jszJAW40wWzEBKRNWUZjNMoLjZdc5zn8VHP n0kQlOgjMfffHy8CuPlkHfPqEEKt0wFP+v+MpS/dAVV8PPVwnCWGSe3KoUup7S/wwUmOTOF0MWE q/v568zHronCt7wU07s9L2N6kxl77cGT3xTFjgg== X-Google-Smtp-Source: AGHT+IH7vS67BhaJmZ0qKWVe6no0q/4H1vlJ1cE1CsXNcFt1Pp6VcJPBg/0mptzu0uQFXbGKADhe7nfa9TyYWhC6deg= X-Received: by 2002:a0d:ebc6:0:b0:607:ec66:36b3 with SMTP id u189-20020a0debc6000000b00607ec6636b3mr5019006ywe.19.1708125010589; Fri, 16 Feb 2024 15:10:10 -0800 (PST) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240216203215.40870-1-brgl@bgdev.pl> <20240216203215.40870-9-brgl@bgdev.pl> In-Reply-To: <20240216203215.40870-9-brgl@bgdev.pl> From: Dmitry Baryshkov Date: Sat, 17 Feb 2024 01:09:59 +0200 Message-ID: Subject: Re: [PATCH v5 08/18] arm64: dts: qcom: sm8650-qrd: add the Wifi node To: Bartosz Golaszewski Cc: Marcel Holtmann , Luiz Augusto von Dentz , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kalle Valo , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Catalin Marinas , Will Deacon , Bjorn Helgaas , Saravana Kannan , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , Marek Szyprowski , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , Abel Vesa , Manivannan Sadhasivam , Lukas Wunner , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" On Fri, 16 Feb 2024 at 22:33, Bartosz Golaszewski wrote: > > From: Neil Armstrong > > Describe the ath12k WLAN on-board the WCN7850 module present on the > board. WCN7850 is the same combo WiFi + BT chip. Is there any reason for describing its parts separately rather than using the same PMU approach? > > Signed-off-by: Neil Armstrong > [Bartosz: > - move the pcieport0 node into the .dtsi > - make regulator naming consistent with existing DT code > - add commit message] > Signed-off-by: Bartosz Golaszewski > --- > arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 29 +++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sm8650.dtsi | 10 +++++++++ > 2 files changed, 39 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > index b07cac2e5bc8..4623c358f634 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > @@ -845,6 +845,28 @@ &pcie0 { > status = "okay"; > }; > > +&pcieport0 { > + wifi@0 { > + compatible = "pci17cb,1107"; > + reg = <0x10000 0x0 0x0 0x0 0x0>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&wlan_en>; > + > + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; > + > + vdd-supply = <&vreg_s4i_0p85>; > + vddio-supply = <&vreg_l15b_1p8>; > + vddio1p2-supply = <&vreg_l3c_1p2>; > + vddaon-supply = <&vreg_s2c_0p8>; > + vdddig-supply = <&vreg_s3c_0p9>; > + vddrfa1p2-supply = <&vreg_s1c_1p2>; > + vddrfa1p8-supply = <&vreg_s6c_1p8>; > + > + clocks = <&rpmhcc RPMH_RF_CLK1>; > + }; > +}; > + > &pcie0_phy { > vdda-phy-supply = <&vreg_l1i_0p88>; > vdda-pll-supply = <&vreg_l3i_1p2>; > @@ -1139,6 +1161,13 @@ wcd_default: wcd-reset-n-active-state { > bias-disable; > output-low; > }; > + > + wlan_en: wlan-en-state { > + pins = "gpio16"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-down; > + }; > }; > > &uart14 { > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi > index d488b3b3265e..baf4932e460c 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi > @@ -2293,6 +2293,16 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > dma-coherent; > > status = "disabled"; > + > + pcieport0: pcie@0 { > + device_type = "pci"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + > + bus-range = <0x01 0xff>; > + }; > }; > > pcie0_phy: phy@1c06000 { > -- > 2.40.1 > -- With best wishes Dmitry