netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	 Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	 Peter Zijlstra <peterz@infradead.org>,
	Christian Brauner <brauner@kernel.org>,
	 Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>,  Kernel Team <kernel-team@fb.com>
Subject: Re: pull-request: bpf-next 2023-12-18
Date: Mon, 18 Dec 2023 17:48:32 -0800	[thread overview]
Message-ID: <CAADnVQJfyfbpEVHnBy2DDGEJvUm8K25b9NHCzu08Uv96OS8NaA@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wg7JuFYwGy=GOMbRCtOL+jwSQsdUaBsRWkDVYbxipbM5A@mail.gmail.com>

On Mon, Dec 18, 2023 at 5:11 PM Linus Torvalds
<torvalds@linuxfoundation.org> wrote:
>
> I literally see complete garbage like tghis:
>
>         ..
>         __u32 btf_token_fd;
>         ...
>         if (attr->btf_token_fd) {
>                 token = bpf_token_get_from_fd(attr->btf_token_fd);
>
> and this is all *new* code that makes that same bogus sh*t-for-brains
> mistake that was wrong the first time.

Point taken.
We can do s/__u32 token_fd/__u64 token/
and waste upper 32-bit as flags that indicate that lower 32-bit is an FD
or
are you ok with __u32 token that is 'fd + 1'.
zero - invalid
one - FD==0
two - FD==1
?

Naming is hard. 'token_handle' maybe?

  reply	other threads:[~2023-12-19  1:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  0:05 pull-request: bpf-next 2023-12-18 Alexei Starovoitov
2023-12-19  0:19 ` Alexei Starovoitov
2023-12-19  0:55 ` Jakub Kicinski
2023-12-19  1:17   ` Linus Torvalds
2023-12-19  1:10 ` patchwork-bot+netdevbpf
2023-12-19  1:11 ` Linus Torvalds
2023-12-19  1:48   ` Alexei Starovoitov [this message]
2023-12-19  3:57     ` Linus Torvalds
2023-12-19  4:34       ` Andrii Nakryiko
2023-12-19  5:38         ` Andrii Nakryiko
2023-12-19 10:23   ` Christian Brauner
2023-12-19 16:06     ` Matthew Wilcox
2023-12-19 16:51       ` Alexei Starovoitov
2023-12-19 16:36     ` Daniel Borkmann
2023-12-19 16:42     ` Alexei Starovoitov
2023-12-19 18:31       ` Andrii Nakryiko
2023-12-20 11:18       ` Christian Brauner
2023-12-20 19:17         ` Andrii Nakryiko
2023-12-21 13:05           ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQJfyfbpEVHnBy2DDGEJvUm8K25b9NHCzu08Uv96OS8NaA@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel-team@fb.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peterz@infradead.org \
    --cc=torvalds@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).