From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF840C17443 for ; Sat, 9 Nov 2019 03:26:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C24B2214E0 for ; Sat, 9 Nov 2019 03:26:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gyz/kW81" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726136AbfKID0j (ORCPT ); Fri, 8 Nov 2019 22:26:39 -0500 Received: from mail-lj1-f173.google.com ([209.85.208.173]:38381 "EHLO mail-lj1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbfKID0i (ORCPT ); Fri, 8 Nov 2019 22:26:38 -0500 Received: by mail-lj1-f173.google.com with SMTP id v8so8239492ljh.5; Fri, 08 Nov 2019 19:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6mWpHOx7d3RC93m4tPpgEfkg8hGRzXNMxcpawVMB0/U=; b=gyz/kW81uFp5O10kUeR0WLM/DkBFXyGdlMpBa+/SEnymxBe78dLg74Uf7a42oWb3ZB w3k3peXe3cUOtgeUG8i7A/2LU3RvgGjGgxHYzQcroTEyzwbif+71ueA2mNVj1wG0nDcE Xh8fpumZCEr/Lvt+vJBRSRAKQRuU378rLdU3CimTa59YSMkeQllamtDzMW79PpSD3ClX kNQJCUkg3+FJkSscFrXEMI3ERjLAjVizeO+dHA9mZAlfY8Q3NJqTgZEd7xr33CdxSeG2 om+hRroMi6G53/tXXCYzBNYywMjgmxc/AM72bEEj8eUbtEG8RBN6R60OUL0nj1qWNVQM kB/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6mWpHOx7d3RC93m4tPpgEfkg8hGRzXNMxcpawVMB0/U=; b=c6u2ekwNA+6XP7tTtCZ7IV230qDlwSVFe+GzIaKktsGOi/uvlpSr5XqFsRp4ZbLSWp b+9kK2tztplvaP85Ex19ONGTS9g9gnpz0lyvTLTGdWh5+oT3jQ8Ym0kHt5tKDMGzE0eG S9YNw9/12YWbRevmGeVJQQ3K02lE8Pek0n62XV2UVXXDSRnl1x7CtrPCWJQd9X072Hd2 bhtWz6vo5Pujf0sAFbOKZkbCKXmf/S9KxrS49a4OIPmYTWdEkd7tWGggm08sj3H85FzF rFEU7My0xAkdTYXCmpUNGMMT+nOHDA6Gp3uk6xuXB4P9f/FGmt+xSrn6LF5YkD8ZrFzk OprQ== X-Gm-Message-State: APjAAAXBYwAwuVZTcBErHXPozWRqNlSSG6g/Eztd1Z8dn6Z4gi7ZRE97 TQNUm/30i1L8VCQ1/Sq7hz8q7s3EttdrFV8SSNw= X-Google-Smtp-Source: APXvYqy8ps35ipYMBZMhRxqth0qghotkaQzYujvBcxNzMmvLQdMgFR4+1VJlVEaxMISJPKUAQO3L2fFFVkJ+VqVhyMU= X-Received: by 2002:a2e:92c4:: with SMTP id k4mr8854685ljh.10.1573269996294; Fri, 08 Nov 2019 19:26:36 -0800 (PST) MIME-Version: 1.0 References: <20191107005153.31541-1-danieltimlee@gmail.com> <20191107005153.31541-3-danieltimlee@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Fri, 8 Nov 2019 19:26:24 -0800 Message-ID: Subject: Re: [PATCH,bpf-next v2 2/2] samples: bpf: update map definition to new syntax BTF-defined map To: "Daniel T. Lee" Cc: Andrii Nakryiko , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , Networking , bpf Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 6, 2019 at 8:45 PM Daniel T. Lee wrote: > > On Thu, Nov 7, 2019 at 11:53 AM Andrii Nakryiko > wrote: > > > > On Wed, Nov 6, 2019 at 4:52 PM Daniel T. Lee wrote: > > > > > > Since, the new syntax of BTF-defined map has been introduced, > > > the syntax for using maps under samples directory are mixed up. > > > For example, some are already using the new syntax, and some are using > > > existing syntax by calling them as 'legacy'. > > > > > > As stated at commit abd29c931459 ("libbpf: allow specifying map > > > definitions using BTF"), the BTF-defined map has more compatablility > > > with extending supported map definition features. > > > > > > The commit doesn't replace all of the map to new BTF-defined map, > > > because some of the samples still use bpf_load instead of libbpf, which > > > can't properly create BTF-defined map. > > > > > > This will only updates the samples which uses libbpf API for loading bpf > > > program. (ex. bpf_prog_load_xattr) > > > > > > Signed-off-by: Daniel T. Lee Applied. Thanks