* [PATCH] can: mcp251x: not correct register address
@ 2015-05-25 6:57 Tomas Krcka
2015-05-30 7:41 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Tomas Krcka @ 2015-05-25 6:57 UTC (permalink / raw)
To: linux-can; +Cc: andri.yngvason, mkl, himangi774, netdev
This patch corrects addresses of acceptance filters.
These registers are not in use, but values should be correct.
Tested with MCP2515 and am3352 and also checked datasheets for MCP2515
and MCP2510.
Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
---
drivers/net/can/spi/mcp251x.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
index bf63fee..c1a95a3 100644
--- a/drivers/net/can/spi/mcp251x.c
+++ b/drivers/net/can/spi/mcp251x.c
@@ -190,10 +190,11 @@
#define RXBEID0_OFF 4
#define RXBDLC_OFF 5
#define RXBDAT_OFF 6
-#define RXFSIDH(n) ((n) * 4)
-#define RXFSIDL(n) ((n) * 4 + 1)
-#define RXFEID8(n) ((n) * 4 + 2)
-#define RXFEID0(n) ((n) * 4 + 3)
+#define RXFSID(n) ((n < 3) ? 0 : 4)
+#define RXFSIDH(n) ((n) * 4 + RXFSID(n))
+#define RXFSIDL(n) ((n) * 4 + 1 + RXFSID(n))
+#define RXFEID8(n) ((n) * 4 + 2 + RXFSID(n))
+#define RXFEID0(n) ((n) * 4 + 3 + RXFSID(n))
#define RXMSIDH(n) ((n) * 4 + 0x20)
#define RXMSIDL(n) ((n) * 4 + 0x21)
#define RXMEID8(n) ((n) * 4 + 0x22)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] can: mcp251x: not correct register address
2015-05-25 6:57 [PATCH] can: mcp251x: not correct register address Tomas Krcka
@ 2015-05-30 7:41 ` Jakub Kicinski
2015-05-30 8:08 ` Tomas Krcka
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2015-05-30 7:41 UTC (permalink / raw)
To: Tomas Krcka; +Cc: linux-can, andri.yngvason, mkl, himangi774, netdev
On Mon, 25 May 2015 08:57:48 +0200, Tomas Krcka wrote:
> This patch corrects addresses of acceptance filters.
> These registers are not in use, but values should be correct.
> Tested with MCP2515 and am3352 and also checked datasheets for MCP2515
> and MCP2510.
>
> Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
>
> ---
> drivers/net/can/spi/mcp251x.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
> index bf63fee..c1a95a3 100644
> --- a/drivers/net/can/spi/mcp251x.c
> +++ b/drivers/net/can/spi/mcp251x.c
> @@ -190,10 +190,11 @@
> #define RXBEID0_OFF 4
> #define RXBDLC_OFF 5
> #define RXBDAT_OFF 6
> -#define RXFSIDH(n) ((n) * 4)
> -#define RXFSIDL(n) ((n) * 4 + 1)
> -#define RXFEID8(n) ((n) * 4 + 2)
> -#define RXFEID0(n) ((n) * 4 + 3)
> +#define RXFSID(n) ((n < 3) ? 0 : 4)
> +#define RXFSIDH(n) ((n) * 4 + RXFSID(n))
> +#define RXFSIDL(n) ((n) * 4 + 1 + RXFSID(n))
> +#define RXFEID8(n) ((n) * 4 + 2 + RXFSID(n))
> +#define RXFEID0(n) ((n) * 4 + 3 + RXFSID(n))
> #define RXMSIDH(n) ((n) * 4 + 0x20)
> #define RXMSIDL(n) ((n) * 4 + 0x21)
> #define RXMEID8(n) ((n) * 4 + 0x22)
I think your patch was corrupted. It doesn't apply because you have
extra space before each surviving #define.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: mcp251x: not correct register address
2015-05-30 7:41 ` Jakub Kicinski
@ 2015-05-30 8:08 ` Tomas Krcka
0 siblings, 0 replies; 3+ messages in thread
From: Tomas Krcka @ 2015-05-30 8:08 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: linux-can, andri.yngvason, mkl, himangi774, netdev
You are right, sorry for that. I'll send v2.
Thanks.
2015-05-30 9:41 GMT+02:00 Jakub Kicinski <moorray3@wp.pl>:
> On Mon, 25 May 2015 08:57:48 +0200, Tomas Krcka wrote:
>> This patch corrects addresses of acceptance filters.
>> These registers are not in use, but values should be correct.
>> Tested with MCP2515 and am3352 and also checked datasheets for MCP2515
>> and MCP2510.
>>
>> Signed-off-by: Tomas Krcka <tomas.krcka@nkgroup.cz>
>>
>> ---
>> drivers/net/can/spi/mcp251x.c | 9 +++++----
>> 1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
>> index bf63fee..c1a95a3 100644
>> --- a/drivers/net/can/spi/mcp251x.c
>> +++ b/drivers/net/can/spi/mcp251x.c
>> @@ -190,10 +190,11 @@
>> #define RXBEID0_OFF 4
>> #define RXBDLC_OFF 5
>> #define RXBDAT_OFF 6
>> -#define RXFSIDH(n) ((n) * 4)
>> -#define RXFSIDL(n) ((n) * 4 + 1)
>> -#define RXFEID8(n) ((n) * 4 + 2)
>> -#define RXFEID0(n) ((n) * 4 + 3)
>> +#define RXFSID(n) ((n < 3) ? 0 : 4)
>> +#define RXFSIDH(n) ((n) * 4 + RXFSID(n))
>> +#define RXFSIDL(n) ((n) * 4 + 1 + RXFSID(n))
>> +#define RXFEID8(n) ((n) * 4 + 2 + RXFSID(n))
>> +#define RXFEID0(n) ((n) * 4 + 3 + RXFSID(n))
>> #define RXMSIDH(n) ((n) * 4 + 0x20)
>> #define RXMSIDL(n) ((n) * 4 + 0x21)
>> #define RXMEID8(n) ((n) * 4 + 0x22)
>
> I think your patch was corrupted. It doesn't apply because you have
> extra space before each surviving #define.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-30 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-25 6:57 [PATCH] can: mcp251x: not correct register address Tomas Krcka
2015-05-30 7:41 ` Jakub Kicinski
2015-05-30 8:08 ` Tomas Krcka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).