Re: iwlwifi broken in post-linux-6.3.0 after April 26

Re: iwlwifi broken in post-linux-6.3.0 after April 26

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 6964 bytes --]

On Sat, Apr 29, 2023 at 01:22:03PM +0800, Jeff Chua wrote:
> Can't start wifi on latest linux git pull ... started happening 3 days ago ...

Are you testing mainline?

Also Cc'ing networking and iwlwifi people.

> 
> Is there a fix for this? Or shall I bisect? Wifi works by reverting
> back to released 6.3.0.

Certainly you should do bisection.

> 
> Thanks,
> Jeff
> 
> 
> # wpa_supplicant -Dnl80211 -c wpa.conf -iwlan0
> wlwifi 0000:00:14.3: Failed to send RFI config cmd -5
> iwlwifi 0000:00:14.3: LED command failed: -5
> iwlwifi 0000:00:14.3: Failed to send MAC_CONFIG_CMD (action:1): -5
> 
> # lsmod
> iwlmvm                352256  0
> mac80211              610304  1 iwlmvm
> iwlwifi               299008  1 iwlmvm
> cfg80211              417792  3 iwlmvm,iwlwifi,mac80211
> ax88179_178a           28672  0
> 
> # dmesg
> iwlwifi 0000:00:14.3: Microcode SW error detected. Restarting 0x0.
> iwlwifi 0000:00:14.3: Start IWL Error Log Dump:
> iwlwifi 0000:00:14.3: Transport status: 0x0000004B, valid: 6
> iwlwifi 0000:00:14.3: Loaded firmware version: 78.3bfdc55f.0
> so-a0-gf-a0-78.ucode
> iwlwifi 0000:00:14.3: 0x00000071 | NMI_INTERRUPT_UMAC_FATAL
> iwlwifi 0000:00:14.3: 0x000002F0 | trm_hw_status0
> iwlwifi 0000:00:14.3: 0x00000000 | trm_hw_status1
> iwlwifi 0000:00:14.3: 0x004DB13C | branchlink2
> iwlwifi 0000:00:14.3: 0x004D0D3A | interruptlink1
> iwlwifi 0000:00:14.3: 0x004D0D3A | interruptlink2
> iwlwifi 0000:00:14.3: 0x000157FE | data1
> iwlwifi 0000:00:14.3: 0x00000010 | data2
> iwlwifi 0000:00:14.3: 0x00000000 | data3
> iwlwifi 0000:00:14.3: 0x00000000 | beacon time
> iwlwifi 0000:00:14.3: 0x0002A2E7 | tsf low
> iwlwifi 0000:00:14.3: 0x00000000 | tsf hi
> iwlwifi 0000:00:14.3: 0x00000000 | time gp1
> iwlwifi 0000:00:14.3: 0x0003E5C3 | time gp2
> iwlwifi 0000:00:14.3: 0x00000001 | uCode revision type
> iwlwifi 0000:00:14.3: 0x0000004E | uCode version major
> iwlwifi 0000:00:14.3: 0x3BFDC55F | uCode version minor
> iwlwifi 0000:00:14.3: 0x00000370 | hw version
> iwlwifi 0000:00:14.3: 0x00480002 | board version
> iwlwifi 0000:00:14.3: 0x80B0FF00 | hcmd
> iwlwifi 0000:00:14.3: 0x00020000 | isr0
> iwlwifi 0000:00:14.3: 0x20000000 | isr1
> iwlwifi 0000:00:14.3: 0x58F00002 | isr2
> iwlwifi 0000:00:14.3: 0x00C3000C | isr3
> iwlwifi 0000:00:14.3: 0x00000000 | isr4
> iwlwifi 0000:00:14.3: 0x00000000 | last cmd Id
> iwlwifi 0000:00:14.3: 0x000157FE | wait_event
> iwlwifi 0000:00:14.3: 0x00000000 | l2p_control
> iwlwifi 0000:00:14.3: 0x00000000 | l2p_duration
> iwlwifi 0000:00:14.3: 0x00000000 | l2p_mhvalid
> iwlwifi 0000:00:14.3: 0x00000000 | l2p_addr_match
> iwlwifi 0000:00:14.3: 0x00000018 | lmpm_pmg_sel
> iwlwifi 0000:00:14.3: 0x00000000 | timestamp
> iwlwifi 0000:00:14.3: 0x0000103C | flow_handler
> iwlwifi 0000:00:14.3: Start IWL Error Log Dump:
> iwlwifi 0000:00:14.3: Transport status: 0x0000004B, valid: 7
> iwlwifi 0000:00:14.3: 0x201002FD | ADVANCED_SYSASSERT
> iwlwifi 0000:00:14.3: 0x00000000 | umac branchlink1
> iwlwifi 0000:00:14.3: 0x8046E300 | umac branchlink2
> iwlwifi 0000:00:14.3: 0xC008191A | umac interruptlink1
> iwlwifi 0000:00:14.3: 0x00000000 | umac interruptlink2
> iwlwifi 0000:00:14.3: 0x0017020B | umac data1
> iwlwifi 0000:00:14.3: 0x00000308 | umac data2
> iwlwifi 0000:00:14.3: 0x00000304 | umac data3
> iwlwifi 0000:00:14.3: 0x0000004E | umac major
> iwlwifi 0000:00:14.3: 0x3BFDC55F | umac minor
> iwlwifi 0000:00:14.3: 0x0003E5BE | frame pointer
> iwlwifi 0000:00:14.3: 0xC0886C24 | stack pointer
> iwlwifi 0000:00:14.3: 0x0017020B | last host cmd
> iwlwifi 0000:00:14.3: 0x00000000 | isr status reg
> iwlwifi 0000:00:14.3: IML/ROM dump:
> iwlwifi 0000:00:14.3: 0x00000B03 | IML/ROM error/state
> iwlwifi 0000:00:14.3: 0x000081CD | IML/ROM data1
> iwlwifi 0000:00:14.3: 0x00000080 | IML/ROM WFPM_AUTH_KEY_0
> iwlwifi 0000:00:14.3: Fseq Registers:
> iwlwifi 0000:00:14.3: 0x60000100 | FSEQ_ERROR_CODE
> iwlwifi 0000:00:14.3: 0x003E0003 | FSEQ_TOP_INIT_VERSION
> iwlwifi 0000:00:14.3: 0x00190003 | FSEQ_CNVIO_INIT_VERSION
> iwlwifi 0000:00:14.3: 0x0000A652 | FSEQ_OTP_VERSION
> iwlwifi 0000:00:14.3: 0x00000003 | FSEQ_TOP_CONTENT_VERSION
> iwlwifi 0000:00:14.3: 0x4552414E | FSEQ_ALIVE_TOKEN
> iwlwifi 0000:00:14.3: 0x00080400 | FSEQ_CNVI_ID
> iwlwifi 0000:00:14.3: 0x00400410 | FSEQ_CNVR_ID
> iwlwifi 0000:00:14.3: 0x00080400 | CNVI_AUX_MISC_CHIP
> iwlwifi 0000:00:14.3: 0x00400410 | CNVR_AUX_MISC_CHIP
> iwlwifi 0000:00:14.3: 0x00009061 | CNVR_SCU_SD_REGS_SD_REG_DIG_DCDC_VTRIM
> iwlwifi 0000:00:14.3: 0x00000061 | CNVR_SCU_SD_REGS_SD_REG_ACTIVE_VDIG_MIRROR
> iwlwifi 0000:00:14.3: UMAC CURRENT PC: 0xd05c18
> iwlwifi 0000:00:14.3: LMAC1 CURRENT PC: 0xd05c1c
> iwlwifi 0000:00:14.3: Starting mac, retry will be triggered anyway
> iwlwifi 0000:00:14.3: FW error in SYNC CMD RFI_CONFIG_CMD
> CPU: 6 PID: 22193 Comm: wpa_supplicant Tainted: G     U             6.3.0 #1
> Hardware name: LENOVO 21CCS1GL00/21CCS1GL00, BIOS N3AET72W (1.37 ) 03/02/2023
> Call Trace:
>  <TASK>
>  dump_stack_lvl+0x33/0x50
>  iwl_trans_txq_send_hcmd+0x33a/0x380 [iwlwifi]
>  ? destroy_sched_domains_rcu+0x20/0x20
>  iwl_trans_send_cmd+0x55/0xe0 [iwlwifi]
>  iwl_mvm_send_cmd+0xd/0x30 [iwlmvm]
>  iwl_rfi_send_config_cmd+0x8f/0xf0 [iwlmvm]
>  iwl_mvm_up+0x8c9/0x980 [iwlmvm]
>  __iwl_mvm_mac_start+0x181/0x1e0 [iwlmvm]
>  iwl_mvm_mac_start+0x3f/0x100 [iwlmvm]
>  drv_start+0x2c/0x50 [mac80211]
>  ieee80211_do_open+0x2f2/0x6b0 [mac80211]
>  ieee80211_open+0x62/0x80 [mac80211]
>  __dev_open+0xca/0x170
>  __dev_change_flags+0x1a1/0x210
>  dev_change_flags+0x1c/0x60
>  devinet_ioctl+0x555/0x790
>  inet_ioctl+0x116/0x1b0
>  ? netdev_name_node_lookup_rcu+0x58/0x70
>  ? dev_get_by_name_rcu+0x5/0x10
>  ? netdev_name_node_lookup_rcu+0x58/0x70
>  ? dev_get_by_name_rcu+0x5/0x10
>  ? dev_ioctl+0x34d/0x4c0
>  sock_do_ioctl+0x3a/0xe0
>  sock_ioctl+0x15a/0x2b0
>  ? __sys_recvmsg+0x51/0xa0
>  __x64_sys_ioctl+0x7d/0xa0
>  do_syscall_64+0x35/0x80
>  entry_SYSCALL_64_after_hwframe+0x46/0xb0
> RIP: 0033:0x7efcee3a0448
> Code: 00 00 48 8d 44 24 08 48 89 54 24 e0 48 89 44 24 c0 48 8d 44 24
> d0 48 89 44 24 c8 b8 10 00 00 00 c7 44 24 b8 10 00 00 00 0f 05 <41> 89
> c0 3d 00 f0 ff ff 77 0e 44 89 c0 c3 66 2e 0f 1f 84 00 00 00
> RSP: 002b:00007ffe400ff678 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007efcee3a0448
> RDX: 00007ffe400ff680 RSI: 0000000000008914 RDI: 0000000000000007
> RBP: 0000000000000007 R08: 0000000000000000 R09: 000000000078f4b0
> R10: e324395ae363498e R11: 0000000000000246 R12: 0000000000000000
> R13: 0000000000790a30 R14: 0000000000000002 R15: 0000000000000000
>  </TASK>

Thanks for the report. I'm adding it to regzbot:

#regzbot ^introduced v6.3..89d77f71f493a3
#regzbot title iwlwifi broken on 6.4 merge window

Grazie.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: iwlwifi broken in post-linux-6.3.0 after April 26

[Jeff Chua]

On Sat, Apr 29, 2023 at 10:07 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Sat, Apr 29, 2023 at 01:22:03PM +0800, Jeff Chua wrote:
> > Can't start wifi on latest linux git pull ... started happening 3 days ago ...
>
> Are you testing mainline?

I'm pulling from https://github.com/torvalds/linux.git, currently at ...

commit 1ae78a14516b9372e4c90a89ac21b259339a3a3a (HEAD -> master,
origin/master, origin/HEAD)
Merge: 4e1c80ae5cf4 74d7970febf7
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sat Apr 29 11:10:39 2023 -0700

> Certainly you should do bisection.

ok, will do.

Re: iwlwifi broken in post-linux-6.3.0 after April 26

[Jeff Chua]

On Sun, Apr 30, 2023 at 2:17 AM Jeff Chua <jeff.chua.linux@gmail.com> wrote:
>
> On Sat, Apr 29, 2023 at 10:07 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> >
> > On Sat, Apr 29, 2023 at 01:22:03PM +0800, Jeff Chua wrote:
> > > Can't start wifi on latest linux git pull ... started happening 3 days ago ...
> >
> > Are you testing mainline?
>
> I'm pulling from https://github.com/torvalds/linux.git, currently at ...
>
> commit 1ae78a14516b9372e4c90a89ac21b259339a3a3a (HEAD -> master,
> origin/master, origin/HEAD)
> Merge: 4e1c80ae5cf4 74d7970febf7
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Sat Apr 29 11:10:39 2023 -0700
>
> > Certainly you should do bisection.
>
> ok, will do.

Bisected!

ef3ed33dfc8f0f1c81ca103e6b68b4f77ee0ab65 is the first bad commit
commit ef3ed33dfc8f0f1c81ca103e6b68b4f77ee0ab65
Author: Gregory Greenman <gregory.greenman@intel.com>
Date:   Sun Apr 16 15:47:33 2023 +0300

    wifi: iwlwifi: bump FW API to 77 for AX devices

    Start supporting API version 77 for AX devices.

    Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
    Link: https://lore.kernel.org/r/20230416154301.e522ccefe354.If7628363fafeb7687163103e734206915c445197@changeid
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>

 drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


I had to downgrade FW API to 75 to make it work again!

--- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c    2023-04-30
18:27:21.719983505 +0800
+++ a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c    2023-04-30
18:27:25.749983446 +0800
@@ -10,7 +10,7 @@
 #include "fw/api/txq.h"

 /* Highest firmware API version supported */
-#define IWL_22000_UCODE_API_MAX        78
+#define IWL_22000_UCODE_API_MAX        75

 /* Lowest firmware API version supported */
 #define IWL_22000_UCODE_API_MIN        39


My h/w is Lenovo X1 with ...

00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
WiFi (rev 01)


I've the following firmware .. I've tried 77, 78, 79, 81 .. .all not working

-rw-r--r-- 1 root root 1560532 Mar 14 08:05 iwlwifi-so-a0-gf-a0-72.ucode
-rw-r--r-- 1 root root 1563692 Mar  6 14:07 iwlwifi-so-a0-gf-a0-73.ucode
-rw-r--r-- 1 root root 1577460 Mar 14 08:05 iwlwifi-so-a0-gf-a0-74.ucode
-rw-r--r-- 1 root root 1641260 Mar  6 14:07 iwlwifi-so-a0-gf-a0-77.ucode
-rw-r--r-- 1 root root 1667236 Mar  6 14:07 iwlwifi-so-a0-gf-a0-78.ucode
-rw-r--r-- 1 root root 1672988 Mar  6 14:07 iwlwifi-so-a0-gf-a0-79.ucode
-rw-r--r-- 1 root root 1682852 Apr  5 08:22 iwlwifi-so-a0-gf-a0-81.ucode


# working dmesg attached ...
cfg80211: Loading compiled-in X.509 certificates for regulatory database
Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
iwlwifi 0000:00:14.3: Direct firmware load for
iwlwifi-so-a0-gf-a0-75.ucode failed with error -2
iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
thermal thermal_zone1: failed to read out thermal zone (-61)
iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
requested 65536K

Re: iwlwifi broken in post-linux-6.3.0 after April 26

[Greenman, Gregory]

On Sun, 2023-04-30 at 18:58 +0800, Jeff Chua wrote:
> On Sun, Apr 30, 2023 at 2:17 AM Jeff Chua <jeff.chua.linux@gmail.com> wrote:
> > 
> > On Sat, Apr 29, 2023 at 10:07 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > > 
> > > On Sat, Apr 29, 2023 at 01:22:03PM +0800, Jeff Chua wrote:
> > > > Can't start wifi on latest linux git pull ... started happening 3 days ago ...
> > > 
> > > Are you testing mainline?
> > 
> > I'm pulling from https://github.com/torvalds/linux.git, currently at ...
> > 
> > commit 1ae78a14516b9372e4c90a89ac21b259339a3a3a (HEAD -> master,
> > origin/master, origin/HEAD)
> > Merge: 4e1c80ae5cf4 74d7970febf7
> > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > Date:   Sat Apr 29 11:10:39 2023 -0700
> > 
> > > Certainly you should do bisection.
> > 
> > ok, will do.
> 
> Bisected!
> 
> ef3ed33dfc8f0f1c81ca103e6b68b4f77ee0ab65 is the first bad commit
> commit ef3ed33dfc8f0f1c81ca103e6b68b4f77ee0ab65
> Author: Gregory Greenman <gregory.greenman@intel.com>
> Date:   Sun Apr 16 15:47:33 2023 +0300
> 
>     wifi: iwlwifi: bump FW API to 77 for AX devices
> 
>     Start supporting API version 77 for AX devices.
> 
>     Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
>     Link: https://lore.kernel.org/r/20230416154301.e522ccefe354.If7628363fafeb7687163103e734206915c445197@changeid
>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
>  drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> I had to downgrade FW API to 75 to make it work again!
> 
> --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c    2023-04-30
> 18:27:21.719983505 +0800
> +++ a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c    2023-04-30
> 18:27:25.749983446 +0800
> @@ -10,7 +10,7 @@
>  #include "fw/api/txq.h"
> 
>  /* Highest firmware API version supported */
> -#define IWL_22000_UCODE_API_MAX        78
> +#define IWL_22000_UCODE_API_MAX        75
> 
>  /* Lowest firmware API version supported */
>  #define IWL_22000_UCODE_API_MIN        39
> 
> 
> My h/w is Lenovo X1 with ...
> 
> 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
> WiFi (rev 01)
> 
> 
> I've the following firmware .. I've tried 77, 78, 79, 81 .. .all not working
> 
> -rw-r--r-- 1 root root 1560532 Mar 14 08:05 iwlwifi-so-a0-gf-a0-72.ucode
> -rw-r--r-- 1 root root 1563692 Mar  6 14:07 iwlwifi-so-a0-gf-a0-73.ucode
> -rw-r--r-- 1 root root 1577460 Mar 14 08:05 iwlwifi-so-a0-gf-a0-74.ucode
> -rw-r--r-- 1 root root 1641260 Mar  6 14:07 iwlwifi-so-a0-gf-a0-77.ucode
> -rw-r--r-- 1 root root 1667236 Mar  6 14:07 iwlwifi-so-a0-gf-a0-78.ucode
> -rw-r--r-- 1 root root 1672988 Mar  6 14:07 iwlwifi-so-a0-gf-a0-79.ucode
> -rw-r--r-- 1 root root 1682852 Apr  5 08:22 iwlwifi-so-a0-gf-a0-81.ucode
> 
> 
> # working dmesg attached ...
> cfg80211: Loading compiled-in X.509 certificates for regulatory database
> Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
> iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> iwlwifi 0000:00:14.3: Direct firmware load for
> iwlwifi-so-a0-gf-a0-75.ucode failed with error -2
> iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
> thermal thermal_zone1: failed to read out thermal zone (-61)
> iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
> requested 65536K

Strangely, I couldn't reproduce it on my system. But, anyway this feature
better be disabled for a while. I'll send a patch with a fix shortly.

Re: iwlwifi broken in post-linux-6.3.0 after April 26

[Greenman, Gregory]

On Sun, 2023-04-30 at 17:06 +0000, Greenman, Gregory wrote:
> On Sun, 2023-04-30 at 18:58 +0800, Jeff Chua wrote:
> > On Sun, Apr 30, 2023 at 2:17 AM Jeff Chua <jeff.chua.linux@gmail.com> wrote:
> > > 
> > > On Sat, Apr 29, 2023 at 10:07 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > > > 
> > > > On Sat, Apr 29, 2023 at 01:22:03PM +0800, Jeff Chua wrote:
> > > > > Can't start wifi on latest linux git pull ... started happening 3 days ago ...
> > > > 
> > > > Are you testing mainline?
> > > 
> > > I'm pulling from https://github.com/torvalds/linux.git, currently at ...
> > > 
> > > commit 1ae78a14516b9372e4c90a89ac21b259339a3a3a (HEAD -> master,
> > > origin/master, origin/HEAD)
> > > Merge: 4e1c80ae5cf4 74d7970febf7
> > > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > > Date:   Sat Apr 29 11:10:39 2023 -0700
> > > 
> > > > Certainly you should do bisection.
> > > 
> > > ok, will do.
> > 
> > Bisected!
> > 
> > ef3ed33dfc8f0f1c81ca103e6b68b4f77ee0ab65 is the first bad commit
> > commit ef3ed33dfc8f0f1c81ca103e6b68b4f77ee0ab65
> > Author: Gregory Greenman <gregory.greenman@intel.com>
> > Date:   Sun Apr 16 15:47:33 2023 +0300
> > 
> >     wifi: iwlwifi: bump FW API to 77 for AX devices
> > 
> >     Start supporting API version 77 for AX devices.
> > 
> >     Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
> >     Link: https://lore.kernel.org/r/20230416154301.e522ccefe354.If7628363fafeb7687163103e734206915c445197@changeid
> >     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > 
> >  drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > 
> > I had to downgrade FW API to 75 to make it work again!
> > 
> > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c    2023-04-30
> > 18:27:21.719983505 +0800
> > +++ a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c    2023-04-30
> > 18:27:25.749983446 +0800
> > @@ -10,7 +10,7 @@
> >  #include "fw/api/txq.h"
> > 
> >  /* Highest firmware API version supported */
> > -#define IWL_22000_UCODE_API_MAX        78
> > +#define IWL_22000_UCODE_API_MAX        75
> > 
> >  /* Lowest firmware API version supported */
> >  #define IWL_22000_UCODE_API_MIN        39
> > 
> > 
> > My h/w is Lenovo X1 with ...
> > 
> > 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
> > WiFi (rev 01)
> > 
> > 
> > I've the following firmware .. I've tried 77, 78, 79, 81 .. .all not working
> > 
> > -rw-r--r-- 1 root root 1560532 Mar 14 08:05 iwlwifi-so-a0-gf-a0-72.ucode
> > -rw-r--r-- 1 root root 1563692 Mar  6 14:07 iwlwifi-so-a0-gf-a0-73.ucode
> > -rw-r--r-- 1 root root 1577460 Mar 14 08:05 iwlwifi-so-a0-gf-a0-74.ucode
> > -rw-r--r-- 1 root root 1641260 Mar  6 14:07 iwlwifi-so-a0-gf-a0-77.ucode
> > -rw-r--r-- 1 root root 1667236 Mar  6 14:07 iwlwifi-so-a0-gf-a0-78.ucode
> > -rw-r--r-- 1 root root 1672988 Mar  6 14:07 iwlwifi-so-a0-gf-a0-79.ucode
> > -rw-r--r-- 1 root root 1682852 Apr  5 08:22 iwlwifi-so-a0-gf-a0-81.ucode
> > 
> > 
> > # working dmesg attached ...
> > cfg80211: Loading compiled-in X.509 certificates for regulatory database
> > Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
> > iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> > iwlwifi 0000:00:14.3: Direct firmware load for
> > iwlwifi-so-a0-gf-a0-75.ucode failed with error -2
> > iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
> > thermal thermal_zone1: failed to read out thermal zone (-61)
> > iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
> > requested 65536K
> 
> Strangely, I couldn't reproduce it on my system. But, anyway this feature
> better be disabled for a while. I'll send a patch with a fix shortly.
May I ask you to try this fix in [1] (also cc-ed you on the patch itself)?

[1] https://lore.kernel.org/linux-wireless/20230430201830.2f8f88fe49f6.I2f0076ef1d1cbe5d10010549c875b7038ec4c365@changeid/

Re: iwlwifi broken in post-linux-6.3.0 after April 26

[Jeff Chua]

On Mon, May 1, 2023 at 2:00 AM Greenman, Gregory
<gregory.greenman@intel.com> wrote:

> > Strangely, I couldn't reproduce it on my system. But, anyway this feature
> > better be disabled for a while. I'll send a patch with a fix shortly.
> May I ask you to try this fix in [1] (also cc-ed you on the patch itself)?
>
> [1] https://lore.kernel.org/linux-wireless/20230430201830.2f8f88fe49f6.I2f0076ef1d1cbe5d10010549c875b7038ec4c365@changeid/

Hi Greg,

Applied the patch. It worked! Thank you!

Jeff

Re: iwlwifi broken in post-linux-6.3.0 after April 26

[Bagas Sanjaya]

On 4/29/23 21:07, Bagas Sanjaya wrote:
> On Sat, Apr 29, 2023 at 01:22:03PM +0800, Jeff Chua wrote:
>> Can't start wifi on latest linux git pull ... started happening 3 days ago ...
> 
> Are you testing mainline?
> 
> Also Cc'ing networking and iwlwifi people.
> 
>>
>> Is there a fix for this? Or shall I bisect? Wifi works by reverting
>> back to released 6.3.0.
> 
> Certainly you should do bisection.
> 
>>
>> Thanks,
>> Jeff
>>
>>
>> # wpa_supplicant -Dnl80211 -c wpa.conf -iwlan0
>> wlwifi 0000:00:14.3: Failed to send RFI config cmd -5
>> iwlwifi 0000:00:14.3: LED command failed: -5
>> iwlwifi 0000:00:14.3: Failed to send MAC_CONFIG_CMD (action:1): -5
>>
>> # lsmod
>> iwlmvm                352256  0
>> mac80211              610304  1 iwlmvm
>> iwlwifi               299008  1 iwlmvm
>> cfg80211              417792  3 iwlmvm,iwlwifi,mac80211
>> ax88179_178a           28672  0
>>
>> # dmesg
>> iwlwifi 0000:00:14.3: Microcode SW error detected. Restarting 0x0.
>> iwlwifi 0000:00:14.3: Start IWL Error Log Dump:
>> iwlwifi 0000:00:14.3: Transport status: 0x0000004B, valid: 6
>> iwlwifi 0000:00:14.3: Loaded firmware version: 78.3bfdc55f.0
>> so-a0-gf-a0-78.ucode
>> iwlwifi 0000:00:14.3: 0x00000071 | NMI_INTERRUPT_UMAC_FATAL
>> iwlwifi 0000:00:14.3: 0x000002F0 | trm_hw_status0
>> iwlwifi 0000:00:14.3: 0x00000000 | trm_hw_status1
>> iwlwifi 0000:00:14.3: 0x004DB13C | branchlink2
>> iwlwifi 0000:00:14.3: 0x004D0D3A | interruptlink1
>> iwlwifi 0000:00:14.3: 0x004D0D3A | interruptlink2
>> iwlwifi 0000:00:14.3: 0x000157FE | data1
>> iwlwifi 0000:00:14.3: 0x00000010 | data2
>> iwlwifi 0000:00:14.3: 0x00000000 | data3
>> iwlwifi 0000:00:14.3: 0x00000000 | beacon time
>> iwlwifi 0000:00:14.3: 0x0002A2E7 | tsf low
>> iwlwifi 0000:00:14.3: 0x00000000 | tsf hi
>> iwlwifi 0000:00:14.3: 0x00000000 | time gp1
>> iwlwifi 0000:00:14.3: 0x0003E5C3 | time gp2
>> iwlwifi 0000:00:14.3: 0x00000001 | uCode revision type
>> iwlwifi 0000:00:14.3: 0x0000004E | uCode version major
>> iwlwifi 0000:00:14.3: 0x3BFDC55F | uCode version minor
>> iwlwifi 0000:00:14.3: 0x00000370 | hw version
>> iwlwifi 0000:00:14.3: 0x00480002 | board version
>> iwlwifi 0000:00:14.3: 0x80B0FF00 | hcmd
>> iwlwifi 0000:00:14.3: 0x00020000 | isr0
>> iwlwifi 0000:00:14.3: 0x20000000 | isr1
>> iwlwifi 0000:00:14.3: 0x58F00002 | isr2
>> iwlwifi 0000:00:14.3: 0x00C3000C | isr3
>> iwlwifi 0000:00:14.3: 0x00000000 | isr4
>> iwlwifi 0000:00:14.3: 0x00000000 | last cmd Id
>> iwlwifi 0000:00:14.3: 0x000157FE | wait_event
>> iwlwifi 0000:00:14.3: 0x00000000 | l2p_control
>> iwlwifi 0000:00:14.3: 0x00000000 | l2p_duration
>> iwlwifi 0000:00:14.3: 0x00000000 | l2p_mhvalid
>> iwlwifi 0000:00:14.3: 0x00000000 | l2p_addr_match
>> iwlwifi 0000:00:14.3: 0x00000018 | lmpm_pmg_sel
>> iwlwifi 0000:00:14.3: 0x00000000 | timestamp
>> iwlwifi 0000:00:14.3: 0x0000103C | flow_handler
>> iwlwifi 0000:00:14.3: Start IWL Error Log Dump:
>> iwlwifi 0000:00:14.3: Transport status: 0x0000004B, valid: 7
>> iwlwifi 0000:00:14.3: 0x201002FD | ADVANCED_SYSASSERT
>> iwlwifi 0000:00:14.3: 0x00000000 | umac branchlink1
>> iwlwifi 0000:00:14.3: 0x8046E300 | umac branchlink2
>> iwlwifi 0000:00:14.3: 0xC008191A | umac interruptlink1
>> iwlwifi 0000:00:14.3: 0x00000000 | umac interruptlink2
>> iwlwifi 0000:00:14.3: 0x0017020B | umac data1
>> iwlwifi 0000:00:14.3: 0x00000308 | umac data2
>> iwlwifi 0000:00:14.3: 0x00000304 | umac data3
>> iwlwifi 0000:00:14.3: 0x0000004E | umac major
>> iwlwifi 0000:00:14.3: 0x3BFDC55F | umac minor
>> iwlwifi 0000:00:14.3: 0x0003E5BE | frame pointer
>> iwlwifi 0000:00:14.3: 0xC0886C24 | stack pointer
>> iwlwifi 0000:00:14.3: 0x0017020B | last host cmd
>> iwlwifi 0000:00:14.3: 0x00000000 | isr status reg
>> iwlwifi 0000:00:14.3: IML/ROM dump:
>> iwlwifi 0000:00:14.3: 0x00000B03 | IML/ROM error/state
>> iwlwifi 0000:00:14.3: 0x000081CD | IML/ROM data1
>> iwlwifi 0000:00:14.3: 0x00000080 | IML/ROM WFPM_AUTH_KEY_0
>> iwlwifi 0000:00:14.3: Fseq Registers:
>> iwlwifi 0000:00:14.3: 0x60000100 | FSEQ_ERROR_CODE
>> iwlwifi 0000:00:14.3: 0x003E0003 | FSEQ_TOP_INIT_VERSION
>> iwlwifi 0000:00:14.3: 0x00190003 | FSEQ_CNVIO_INIT_VERSION
>> iwlwifi 0000:00:14.3: 0x0000A652 | FSEQ_OTP_VERSION
>> iwlwifi 0000:00:14.3: 0x00000003 | FSEQ_TOP_CONTENT_VERSION
>> iwlwifi 0000:00:14.3: 0x4552414E | FSEQ_ALIVE_TOKEN
>> iwlwifi 0000:00:14.3: 0x00080400 | FSEQ_CNVI_ID
>> iwlwifi 0000:00:14.3: 0x00400410 | FSEQ_CNVR_ID
>> iwlwifi 0000:00:14.3: 0x00080400 | CNVI_AUX_MISC_CHIP
>> iwlwifi 0000:00:14.3: 0x00400410 | CNVR_AUX_MISC_CHIP
>> iwlwifi 0000:00:14.3: 0x00009061 | CNVR_SCU_SD_REGS_SD_REG_DIG_DCDC_VTRIM
>> iwlwifi 0000:00:14.3: 0x00000061 | CNVR_SCU_SD_REGS_SD_REG_ACTIVE_VDIG_MIRROR
>> iwlwifi 0000:00:14.3: UMAC CURRENT PC: 0xd05c18
>> iwlwifi 0000:00:14.3: LMAC1 CURRENT PC: 0xd05c1c
>> iwlwifi 0000:00:14.3: Starting mac, retry will be triggered anyway
>> iwlwifi 0000:00:14.3: FW error in SYNC CMD RFI_CONFIG_CMD
>> CPU: 6 PID: 22193 Comm: wpa_supplicant Tainted: G     U             6.3.0 #1
>> Hardware name: LENOVO 21CCS1GL00/21CCS1GL00, BIOS N3AET72W (1.37 ) 03/02/2023
>> Call Trace:
>>  <TASK>
>>  dump_stack_lvl+0x33/0x50
>>  iwl_trans_txq_send_hcmd+0x33a/0x380 [iwlwifi]
>>  ? destroy_sched_domains_rcu+0x20/0x20
>>  iwl_trans_send_cmd+0x55/0xe0 [iwlwifi]
>>  iwl_mvm_send_cmd+0xd/0x30 [iwlmvm]
>>  iwl_rfi_send_config_cmd+0x8f/0xf0 [iwlmvm]
>>  iwl_mvm_up+0x8c9/0x980 [iwlmvm]
>>  __iwl_mvm_mac_start+0x181/0x1e0 [iwlmvm]
>>  iwl_mvm_mac_start+0x3f/0x100 [iwlmvm]
>>  drv_start+0x2c/0x50 [mac80211]
>>  ieee80211_do_open+0x2f2/0x6b0 [mac80211]
>>  ieee80211_open+0x62/0x80 [mac80211]
>>  __dev_open+0xca/0x170
>>  __dev_change_flags+0x1a1/0x210
>>  dev_change_flags+0x1c/0x60
>>  devinet_ioctl+0x555/0x790
>>  inet_ioctl+0x116/0x1b0
>>  ? netdev_name_node_lookup_rcu+0x58/0x70
>>  ? dev_get_by_name_rcu+0x5/0x10
>>  ? netdev_name_node_lookup_rcu+0x58/0x70
>>  ? dev_get_by_name_rcu+0x5/0x10
>>  ? dev_ioctl+0x34d/0x4c0
>>  sock_do_ioctl+0x3a/0xe0
>>  sock_ioctl+0x15a/0x2b0
>>  ? __sys_recvmsg+0x51/0xa0
>>  __x64_sys_ioctl+0x7d/0xa0
>>  do_syscall_64+0x35/0x80
>>  entry_SYSCALL_64_after_hwframe+0x46/0xb0
>> RIP: 0033:0x7efcee3a0448
>> Code: 00 00 48 8d 44 24 08 48 89 54 24 e0 48 89 44 24 c0 48 8d 44 24
>> d0 48 89 44 24 c8 b8 10 00 00 00 c7 44 24 b8 10 00 00 00 0f 05 <41> 89
>> c0 3d 00 f0 ff ff 77 0e 44 89 c0 c3 66 2e 0f 1f 84 00 00 00
>> RSP: 002b:00007ffe400ff678 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
>> RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007efcee3a0448
>> RDX: 00007ffe400ff680 RSI: 0000000000008914 RDI: 0000000000000007
>> RBP: 0000000000000007 R08: 0000000000000000 R09: 000000000078f4b0
>> R10: e324395ae363498e R11: 0000000000000246 R12: 0000000000000000
>> R13: 0000000000790a30 R14: 0000000000000002 R15: 0000000000000000
>>  </TASK>
> 
> Thanks for the report. I'm adding it to regzbot:
> 
> #regzbot ^introduced v6.3..89d77f71f493a3
> #regzbot title iwlwifi broken on 6.4 merge window
> 

#regzbot introduced: 1ae78a14516b93
#regzbot fix: wifi: iwlwifi: mvm: rfi: disable RFI feature
#regzbot ignore-activity

-- 
An old man doll... just what I always wanted! - Clara

Linux-6.5 iwlwifi crash

[Jeff Chua]

Latest linux-6.4 after June 27 crash my whole linux notebook once
iwlwifi is loaded. Anyone seeing this?

Bisect? Or there's a patch for this?

# modprobe iwlwifi
... Whole system frozen!


Here's my system before the crash ...

# dmesg
cfg80211: Loading compiled-in X.509 certificates for regulatory database
Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
thermal thermal_zone1: failed to read out thermal zone (-61)
iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
requested 65536K

# lspci
00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
WiFi (rev 01)

# linux git log
commit d528014517f2b0531862c02865b9d4c908019dc4 (HEAD -> master,
origin/master, origin/HEAD)
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue Jul 4 15:05:12 2023 -0700

# lsmodModule                  Size  Used by
iwlmvm                397312  0
mac80211              626688  1 iwlmvm
iwlwifi               307200  1 iwlmvm
cfg80211              413696  3 iwlmvm,iwlwifi,mac80211


Bisect?

Thanks,
Jeff.

Re: Linux-6.5 iwlwifi crash

[Linux regression tracking (Thorsten Leemhuis)]

Hi! Thanks for your report.

Side note: is there any relation to the thread[1] you posted this in?
Doesn't look like it from here.

Side note: discussing multiple unrelated issues in one thread increases
the risk a lot that some or all of them are ignored:
https://linux-regtracking.leemhuis.info/post/frequent-reasons-why-linux-kernel-bug-reports-are-ignored/

[1] https://lore.kernel.org/all/ZE0kndhsXNBIb1g7@debian.me/

On 05.07.23 09:24, Jeff Chua wrote:
> Latest linux-6.4

What do you mean by that? From later in the mail it sounds like you mean
latest mainline -- is that correct?

> after June 27 crash my whole linux notebook once
> iwlwifi is loaded. Anyone seeing this?

I haven't heard of any such problems, but that doesn't have to mean much.

> Bisect? Or there's a patch for this?
> 
> # modprobe iwlwifi
> ... Whole system frozen!
> 
> 
> Here's my system before the crash ...
> 
> # dmesg
> cfg80211: Loading compiled-in X.509 certificates for regulatory database
> Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
> iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
> thermal thermal_zone1: failed to read out thermal zone (-61)
> iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
> requested 65536K
> 
> # lspci
> 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
> WiFi (rev 01)
> 
> # linux git log
> commit d528014517f2b0531862c02865b9d4c908019dc4 (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Tue Jul 4 15:05:12 2023 -0700
> 
> # lsmodModule                  Size  Used by
> iwlmvm                397312  0
> mac80211              626688  1 iwlmvm
> iwlwifi               307200  1 iwlmvm
> cfg80211              413696  3 iwlmvm,iwlwifi,mac80211
> 
> 
> Bisect?

If none of the others CCed comes up with an idea within the next few
hours then yes please!

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

Re: Linux-6.5 iwlwifi crash

[Jeff Chua]

On Wed, Jul 5, 2023 at 4:37 PM Linux regression tracking (Thorsten
Leemhuis) <regressions@leemhuis.info> wrote:
>
> Hi! Thanks for your report.
>
> Side note: is there any relation to the thread[1] you posted this in?

Sorry, I was just posting to the same email list that I had reported
about a different wifi list earlier. No relation to this, but it's a
new wifi issue.

> Doesn't look like it from here.
>
> Side note: discussing multiple unrelated issues in one thread increases
> the risk a lot that some or all of them are ignored:
> https://linux-regtracking.leemhuis.info/post/frequent-reasons-why-linux-kernel-bug-reports-are-ignored/
>
> [1] https://lore.kernel.org/all/ZE0kndhsXNBIb1g7@debian.me/
>
> On 05.07.23 09:24, Jeff Chua wrote:
> > Latest linux-6.4
>
> What do you mean by that? From later in the mail it sounds like you mean
> latest mainline -- is that correct?

It's from linux git pull. It's 6.5-rc but I didn't write that way
becuase Linus's branch is still 6.4 ... that 6.5-rc0 or rc1 should
have more appropriate.

> > after June 27 crash my whole linux notebook once
> > iwlwifi is loaded. Anyone seeing this?
>
> I haven't heard of any such problems, but that doesn't have to mean much.

> > Bisect? Or there's a patch for this?
> >
> > # modprobe iwlwifi
> > ... Whole system frozen!
> >
> >
> > Here's my system before the crash ...
> >
> > # dmesg
> > cfg80211: Loading compiled-in X.509 certificates for regulatory database
> > Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
> > iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> > iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
> > thermal thermal_zone1: failed to read out thermal zone (-61)
> > iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
> > requested 65536K
> >
> > # lspci
> > 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
> > WiFi (rev 01)
> >
> > # linux git log
> > commit d528014517f2b0531862c02865b9d4c908019dc4 (HEAD -> master,
> > origin/master, origin/HEAD)
> > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > Date:   Tue Jul 4 15:05:12 2023 -0700
> >
> > # lsmodModule                  Size  Used by
> > iwlmvm                397312  0
> > mac80211              626688  1 iwlmvm
> > iwlwifi               307200  1 iwlmvm
> > cfg80211              413696  3 iwlmvm,iwlwifi,mac80211
> >
> >
> > Bisect?
>
> If none of the others CCed comes up with an idea within the next few
> hours then yes please!

I will wait for a day, then bisect.

Thank you!


> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.

Re: Linux-6.5 iwlwifi crash

[Larry Finger]

On 7/5/23 06:56, Jeff Chua wrote:
> On Wed, Jul 5, 2023 at 4:37 PM Linux regression tracking (Thorsten
> Leemhuis) <regressions@leemhuis.info> wrote:
>>
>> Hi! Thanks for your report.
>>
>> Side note: is there any relation to the thread[1] you posted this in?
> 
> Sorry, I was just posting to the same email list that I had reported
> about a different wifi list earlier. No relation to this, but it's a
> new wifi issue.
> 
>> Doesn't look like it from here.
>>
>> Side note: discussing multiple unrelated issues in one thread increases
>> the risk a lot that some or all of them are ignored:
>> https://linux-regtracking.leemhuis.info/post/frequent-reasons-why-linux-kernel-bug-reports-are-ignored/
>>
>> [1] https://lore.kernel.org/all/ZE0kndhsXNBIb1g7@debian.me/
>>
>> On 05.07.23 09:24, Jeff Chua wrote:
>>> Latest linux-6.4
>>
>> What do you mean by that? From later in the mail it sounds like you mean
>> latest mainline -- is that correct?
> 
> It's from linux git pull. It's 6.5-rc but I didn't write that way
> becuase Linus's branch is still 6.4 ... that 6.5-rc0 or rc1 should
> have more appropriate.
> 
>>> after June 27 crash my whole linux notebook once
>>> iwlwifi is loaded. Anyone seeing this?
>>
>> I haven't heard of any such problems, but that doesn't have to mean much.
> 
>>> Bisect? Or there's a patch for this?
>>>
>>> # modprobe iwlwifi
>>> ... Whole system frozen!
>>>
>>>
>>> Here's my system before the crash ...
>>>
>>> # dmesg
>>> cfg80211: Loading compiled-in X.509 certificates for regulatory database
>>> Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
>>> iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
>>> iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
>>> thermal thermal_zone1: failed to read out thermal zone (-61)
>>> iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
>>> requested 65536K
>>>
>>> # lspci
>>> 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
>>> WiFi (rev 01)
>>>
>>> # linux git log
>>> commit d528014517f2b0531862c02865b9d4c908019dc4 (HEAD -> master,
>>> origin/master, origin/HEAD)
>>> Author: Linus Torvalds <torvalds@linux-foundation.org>
>>> Date:   Tue Jul 4 15:05:12 2023 -0700
>>>
>>> # lsmodModule                  Size  Used by
>>> iwlmvm                397312  0
>>> mac80211              626688  1 iwlmvm
>>> iwlwifi               307200  1 iwlmvm
>>> cfg80211              413696  3 iwlmvm,iwlwifi,mac80211

Jeff,

Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today) 
is working OK with iwlmvm. Lspci says my device is

04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1] 
(rev 73)

I think you do need to do a bisection.

Larry

Re: Linux-6.5 iwlwifi crash

[Jeff Chua]

On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <Larry.Finger@lwfinger.net> wrote:

> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
> is working OK with iwlmvm. Lspci says my device is
>
> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
> (rev 73)
>
> I think you do need to do a bisection.
> Larry


Larry,

I did a bisect and here's what it came up with ... reverted the
following and iwlwiifi worked again.


19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
Author: Johannes Berg <johannes.berg@intel.com>
Date:   Wed Jun 21 13:12:07 2023 +0300

    wifi: iwlwifi: split 22000.c into multiple files

    Split the configuration list in 22000.c into four new files,
    per new device family, so we don't have this huge unusable
    file. Yes, this duplicates a few small things, but that's
    still much better than what we have now.

    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
    Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>

 drivers/net/wireless/intel/iwlwifi/Makefile     |   1 +
 drivers/net/wireless/intel/iwlwifi/cfg/22000.c  | 939 +-----------------------
 drivers/net/wireless/intel/iwlwifi/cfg/ax210.c  | 452 ++++++++++++
 drivers/net/wireless/intel/iwlwifi/cfg/bz.c     | 523 +++++++++++++
 drivers/net/wireless/intel/iwlwifi/cfg/sc.c     | 214 ++++++
 drivers/net/wireless/intel/iwlwifi/iwl-config.h |   2 +
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c   |   3 +
 7 files changed, 1206 insertions(+), 928 deletions(-)
 create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/ax210.c
 create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/bz.c
 create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/sc.c


My best.,
Jeff

>
>

Re: Linux-6.5 iwlwifi crash

[Linux regression tracking (Thorsten Leemhuis)]

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
for once, to make this easily accessible to everyone.

Jeff, thx for bisecting. Johannes afaik is unavailable for a while
(CCing him nevertheless), hence:

Gregory, could you please take a look at this? And maybe provide a few
hints for Jeff how to generate more data that allows us to find the root
of the problem?

Jeff, btw, the iwlwifi bug reporting guide (
https://wireless.wiki.kernel.org/en/users/drivers/iwlwifi/debugging
) says to file a bugs in http://bugzilla.kernel.org/ Might be wise to do
this in case Gregory is also unavailable, but instructed someone to keep
an eye on things there.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

On 07.07.23 03:56, Jeff Chua wrote:
> On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <Larry.Finger@lwfinger.net> wrote:
> 
>> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
>> is working OK with iwlmvm. Lspci says my device is
>>
>> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
>> (rev 73)
>>
>> I think you do need to do a bisection.
>> Larry
> 
> 
> Larry,
> 
> I did a bisect and here's what it came up with ... reverted the
> following and iwlwiifi worked again.
> 
> 
> 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
> commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
> Author: Johannes Berg <johannes.berg@intel.com>
> Date:   Wed Jun 21 13:12:07 2023 +0300
> 
>     wifi: iwlwifi: split 22000.c into multiple files
> 
>     Split the configuration list in 22000.c into four new files,
>     per new device family, so we don't have this huge unusable
>     file. Yes, this duplicates a few small things, but that's
>     still much better than what we have now.
> 
>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>     Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
>     Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
>  drivers/net/wireless/intel/iwlwifi/Makefile     |   1 +
>  drivers/net/wireless/intel/iwlwifi/cfg/22000.c  | 939 +-----------------------
>  drivers/net/wireless/intel/iwlwifi/cfg/ax210.c  | 452 ++++++++++++
>  drivers/net/wireless/intel/iwlwifi/cfg/bz.c     | 523 +++++++++++++
>  drivers/net/wireless/intel/iwlwifi/cfg/sc.c     | 214 ++++++
>  drivers/net/wireless/intel/iwlwifi/iwl-config.h |   2 +
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c   |   3 +
>  7 files changed, 1206 insertions(+), 928 deletions(-)
>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/ax210.c
>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/bz.c
>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/sc.c
> 
> 
> My best.,
> Jeff
> 
>>
>>
> 
> 

Re: Linux-6.5 iwlwifi crash

[Thorsten Leemhuis]

On 07.07.23 10:43, Linux regression tracking (Thorsten Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> for once, to make this easily accessible to everyone.
> 
> Jeff, thx for bisecting. Johannes afaik is unavailable for a while
> (CCing him nevertheless), hence:
> [...]

Just noticed: there is a bug in bugzilla about this issue already. See
here: https://bugzilla.kernel.org/show_bug.cgi?id=217622

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.


> On 07.07.23 03:56, Jeff Chua wrote:
>> On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>>> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
>>> is working OK with iwlmvm. Lspci says my device is
>>>
>>> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
>>> (rev 73)
>>>
>>> I think you do need to do a bisection.
>>> Larry
>>
>>
>> Larry,
>>
>> I did a bisect and here's what it came up with ... reverted the
>> following and iwlwiifi worked again.
>>
>>
>> 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
>> commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
>> Author: Johannes Berg <johannes.berg@intel.com>
>> Date:   Wed Jun 21 13:12:07 2023 +0300
>>
>>     wifi: iwlwifi: split 22000.c into multiple files
>>
>>     Split the configuration list in 22000.c into four new files,
>>     per new device family, so we don't have this huge unusable
>>     file. Yes, this duplicates a few small things, but that's
>>     still much better than what we have now.
>>
>>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>     Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
>>     Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
>>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>
>>  drivers/net/wireless/intel/iwlwifi/Makefile     |   1 +
>>  drivers/net/wireless/intel/iwlwifi/cfg/22000.c  | 939 +-----------------------
>>  drivers/net/wireless/intel/iwlwifi/cfg/ax210.c  | 452 ++++++++++++
>>  drivers/net/wireless/intel/iwlwifi/cfg/bz.c     | 523 +++++++++++++
>>  drivers/net/wireless/intel/iwlwifi/cfg/sc.c     | 214 ++++++
>>  drivers/net/wireless/intel/iwlwifi/iwl-config.h |   2 +
>>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c   |   3 +
>>  7 files changed, 1206 insertions(+), 928 deletions(-)
>>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/ax210.c
>>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/bz.c
>>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/sc.c
>>
>>
>> My best.,
>> Jeff
>>
>>>
>>>
>>
>>

Re: Linux-6.5 iwlwifi crash

[Larry Finger]

[-- Attachment #1: Type: text/plain, Size: 2895 bytes --]

On 7/7/23 03:43, Linux regression tracking (Thorsten Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> for once, to make this easily accessible to everyone.
> 
> Jeff, thx for bisecting. Johannes afaik is unavailable for a while
> (CCing him nevertheless), hence:
> 
> Gregory, could you please take a look at this? And maybe provide a few
> hints for Jeff how to generate more data that allows us to find the root
> of the problem?
> 
> Jeff, btw, the iwlwifi bug reporting guide (
> https://wireless.wiki.kernel.org/en/users/drivers/iwlwifi/debugging
> ) says to file a bugs in http://bugzilla.kernel.org/ Might be wise to do
> this in case Gregory is also unavailable, but instructed someone to keep
> an eye on things there.
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
> 
> On 07.07.23 03:56, Jeff Chua wrote:
>> On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>>> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
>>> is working OK with iwlmvm. Lspci says my device is
>>>
>>> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
>>> (rev 73)
>>>
>>> I think you do need to do a bisection.
>>> Larry
>>
>>
>> Larry,
>>
>> I did a bisect and here's what it came up with ... reverted the
>> following and iwlwiifi worked again.
>>
>>
>> 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
>> commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
>> Author: Johannes Berg <johannes.berg@intel.com>
>> Date:   Wed Jun 21 13:12:07 2023 +0300
>>
>>      wifi: iwlwifi: split 22000.c into multiple files
>>
>>      Split the configuration list in 22000.c into four new files,
>>      per new device family, so we don't have this huge unusable
>>      file. Yes, this duplicates a few small things, but that's
>>      still much better than what we have now.
>>
>>      Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>      Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
>>      Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
>>      Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Jeff,

I am certainly no expert on iwlwifi, but this change looks suspicious:

@@ -10,8 +10,7 @@
  #include "fw/api/txq.h"

  /* Highest firmware API version supported */
-#define IWL_22000_UCODE_API_MAX        81
-#define IWL_22500_UCODE_API_MAX        77
+#define IWL_22000_UCODE_API_MAX        77

  /* Lowest firmware API version supported */

The parameter that was originally set to 81 is now set to 77.

Please try the attached patch.

Larry

[-- Attachment #2: test_iwlwifi.patch --]
[-- Type: text/x-patch, Size: 1007 bytes --]

diff --git a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c
index beee09dd958c..4ca6a1ba78e8 100644
--- a/drivers/net/wireless/cisco/airo.c
+++ b/drivers/net/wireless/cisco/airo.c
@@ -6156,7 +6156,7 @@ static int airo_get_rate(struct net_device *dev,
 {
 	struct iw_param *vwrq = &wrqu->bitrate;
 	struct airo_info *local = dev->ml_priv;
-	StatusRid status_rid;		/* Card status info */
+	StatusRid status_rid = {};		/* Card status info */
 
 	readStatusRid(local, &status_rid, 1);
 
diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
index aa4320ca4c30..d3e70c33fbcf 100644
--- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
+++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c
@@ -10,7 +10,7 @@
 #include "fw/api/txq.h"
 
 /* Highest firmware API version supported */
-#define IWL_22000_UCODE_API_MAX	77
+#define IWL_22000_UCODE_API_MAX	81
 
 /* Lowest firmware API version supported */
 #define IWL_22000_UCODE_API_MIN	50

Re: Linux-6.5 iwlwifi crash

[Jeff Chua]

On Sat, Jul 8, 2023 at 2:07 AM Larry Finger <Larry.Finger@lwfinger.net> wrote:
> I am certainly no expert on iwlwifi, but this change looks suspicious:
>
> @@ -10,8 +10,7 @@
>   #include "fw/api/txq.h"
>
>   /* Highest firmware API version supported */
> -#define IWL_22000_UCODE_API_MAX        81
> -#define IWL_22500_UCODE_API_MAX        77
> +#define IWL_22000_UCODE_API_MAX        77
>
>   /* Lowest firmware API version supported */
>
> The parameter that was originally set to 81 is now set to 77.
>
> Please try the attached patch.
>
> Larry

Larry, tried, but that didn't help.

Thanks,
Jeff.