From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2EF01DF247 for ; Tue, 23 Sep 2025 01:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758589420; cv=none; b=DtrN3DmuFTQqiPtsvnTQzF2R7LBmT1q3BaFnXHDhJx8gTR6dkMut2nvLTfqmOQAe41xd6dHzapeqHKXFAItZpfpa9XT7J3vGf5DKbeWAJz5XB8RHhUA4XHvDlVEp+YONTg4oWpxgb9p5Npw2Fv+k4E62kzOjhyXOWtEmc1/eMaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758589420; c=relaxed/simple; bh=i6Of2jAUL+zQjJ8mC94XwylCjFmErxMFeVoMP3a6500=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=DQUVSYcM7gQ+Tk2rR0pZr6Kq8EggmYJILoz0sKdYA1Mp1i6+VAeC3SIrku+I6rzuGdAGb0gDkxXOC8KcueM9p0IVR9fFcMCF0tXA7MoRBGCQ60u1lD0WP6PS07Yv48DBoSgLgcUhHiWmorxsLLsHkaE246J35NLU5vOXbL5NrYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HUgiQ5Yc; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HUgiQ5Yc" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-b5516ee0b0bso2684419a12.1 for ; Mon, 22 Sep 2025 18:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758589418; x=1759194218; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x33yQCiS8yD4t00RGUcUdYXvxGF8NkkkcCi7P/JHd/M=; b=HUgiQ5YcWjQFquCPubpxmHoqDYVyL8Pl9u40e4LEBO1Hz4pTehTPy/LrzenufVT+1n HNtF67XfHYdXCIsiALwkPMC4x7wiNo06LakgR2uDEToKI9mi6zjJOAx2c9GK6OfZ5qMy HXAEBLTFi+EPoqAO932P8UvVWU9rIe/VM2qmRQC0jjvqe3eT8Svd0iTlzXoxWlvRLa9G KAmOY6LELFQBNuWWLcVbFJiiqgFDWtsgCNBgD4R1A5WXqRvP1aeZFO+Dh4yEd1yLvD96 EsmVDZvHXLgA1VerIWja67jAv/jsoggADxLHjdHCWEXgIEsKlidPgiL3GvI7teVVbpYH 0x9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758589418; x=1759194218; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x33yQCiS8yD4t00RGUcUdYXvxGF8NkkkcCi7P/JHd/M=; b=hmsZlAVKR1OZpUWdeYlg3Po0cjCW7Qa79I5aho/NnqecztUWV7dAN16GlvNS3B/SQs 6AHsNo87JKFp8IAxMgimA1h0mUiKgIro0v6E2xw2jX1AT5QXOGWMFB5KmRmKDXm2q/h2 aKYtwpRbHeIu96G/88xOWRUbyLlnGKosnW6rAB7x9BUU+lx1c5mvvPhNF5be6ZaKcth0 r6ztxgw0dlhkWlXTPeYgNmzyy8tToGCZ7bRsHGN7ReP5gauOWB6weY3iUD2LPYOhLDDg AGpVuOPv6flW4bnNkR4nO+OfB1ytd5Lxz1xEagXHIzl5Y26644nIPOjipWGhHcemKk+/ 8kLQ== X-Forwarded-Encrypted: i=1; AJvYcCWSYMEhmzJNfMVuAljd7P6gCchCG2lMGIlxeHCW2E3WhzRnS+VnPpfVcN6YQvyl0IsPChjhX0M=@vger.kernel.org X-Gm-Message-State: AOJu0YxX9x/Pnu51kxzCSOipvG63OtvXIHBSFRB4fWgSO9+5IOWuB5jm 64GIHxfkFqYs6oRjoV2+SrpS6ySHTAW1SeC0ywf38FX+TB6iPx/DBWjmXlLOR1qNU587i0K8pM3 rKepNB53Efgl0YQfKLJoXc05xWxzPhFiXsKZ3HYDt X-Gm-Gg: ASbGncuIcVRUEfYaoN8yOfR9WTOYXVJCOLNz96YFeQDPJ0bohLaqfbM+n1Rv+8lKOqA 9lbSksBqnMJRlMWRmxUTlc3QCRb0Se4PvAu/nqix0RuYMjQ+HvpWq+PGCAp3XHPtos8CtkQYbzW Qutqq6wksHBx/OxwCUivFv3uNXno/6pPVWHmN3QA1ASDlOZt4PK3M7P8G5tdfn51IyIB1u750zd 5mC0BE= X-Google-Smtp-Source: AGHT+IF4V7vLCAX99zE2i1WgDrb/NvJZo/98rUrRoBuo4S05a+IOKORc6ElcP1wyehzVZqK2h4N0L8kJZulAJ8PxgQE= X-Received: by 2002:a17:90b:2d8b:b0:32e:a54a:be5d with SMTP id 98e67ed59e1d1-332a91baa9fmr956929a91.2.1758589417994; Mon, 22 Sep 2025 18:03:37 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250920000751.2091731-1-kuniyu@google.com> <20250920000751.2091731-4-kuniyu@google.com> In-Reply-To: From: Kuniyuki Iwashima Date: Mon, 22 Sep 2025 18:03:25 -0700 X-Gm-Features: AS18NWA4Ta5V2LkgBMhN9GY-RVQdhXUu2iIiDrc6jXD7aYqae5HSof66nqd6WU4 Message-ID: Subject: Re: [PATCH v10 bpf-next/net 3/6] net-memcg: Introduce net.core.memcg_exclusive sysctl. To: Shakeel Butt Cc: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Martin KaFai Lau , John Fastabend , Stanislav Fomichev , Johannes Weiner , Michal Hocko , Roman Gushchin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Neal Cardwell , Willem de Bruijn , Mina Almasry , Kuniyuki Iwashima , bpf@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 22, 2025 at 5:54=E2=80=AFPM Shakeel Butt wrote: > > On Sat, Sep 20, 2025 at 12:07:17AM +0000, Kuniyuki Iwashima wrote: > > diff --git a/net/core/sock.c b/net/core/sock.c > > index 814966309b0e..348e599c3fbc 100644 > > --- a/net/core/sock.c > > +++ b/net/core/sock.c > > @@ -2519,6 +2519,7 @@ struct sock *sk_clone_lock(const struct sock *sk,= const gfp_t priority) > > #ifdef CONFIG_MEMCG > > /* sk->sk_memcg will be populated at accept() time */ > > newsk->sk_memcg =3D NULL; > > + mem_cgroup_sk_set_flags(newsk, mem_cgroup_sk_get_flags(sk)); > > Why do you need to set the flag here? Will doing in __inet_accept only > be too late i.e. protocol accounting would have happened? Currently, we only allow bpf_setsockopt() during socket(2) not to make things complicated as explained in patch 4. So, this is to preserve the listener's flag set by bpf_setsockopt() since network applications basically assume setsockopt() for a listener socket is inherited to its child sockets.