From: Wenwen Wang <wang6495@umn.edu>
To: David Miller <davem@davemloft.net>
Cc: Kangjie Lu <kjlu@umn.edu>, Armin Schindler <mac@melware.de>,
Karsten Keil <isdn@linux-pingi.de>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Wenwen Wang <wang6495@umn.edu>
Subject: Re: [PATCH v2] isdn: eicon: fix a missing-check bug
Date: Mon, 21 May 2018 01:48:31 -0500 [thread overview]
Message-ID: <CAAa=b7f3LA4GS18VfLouDLFYAsGifwbWb1DtMeWSGOCT64egug@mail.gmail.com> (raw)
In-Reply-To: <20180520.183730.1550159916165131561.davem@davemloft.net>
On Sun, May 20, 2018 at 5:37 PM, David Miller <davem@davemloft.net> wrote:
> From: Wenwen Wang <wang6495@umn.edu>
> Date: Fri, 18 May 2018 16:33:47 -0500
>
>> In divasmain.c, the function divas_write() firstly invokes the function
>> diva_xdi_open_adapter() to open the adapter that matches with the adapter
>> number provided by the user, and then invokes the function diva_xdi_write()
>> to perform the write operation using the matched adapter. The two functions
>> diva_xdi_open_adapter() and diva_xdi_write() are located in diva.c.
>
> This doesn't even compile:
>
> In file included from drivers/isdn/hardware/eicon/divasmain.c:30:
> drivers/isdn/hardware/eicon/diva.h:23:18: error: unknown type name ‘diva_xdi_um_cfg_cmd_t’
> int length, diva_xdi_um_cfg_cmd_t *msg,
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/isdn/hardware/eicon/diva.h:27:20: error: unknown type name ‘diva_xdi_um_cfg_cmd_t’
> int length, diva_xdi_um_cfg_cmd_t *msg,
> ^~~~~~~~~~~~~~~~~~~~~
Sorry. I will correct the compilation errors and resubmit the patch.
Wenwen
next prev parent reply other threads:[~2018-05-21 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 21:33 [PATCH v2] isdn: eicon: fix a missing-check bug Wenwen Wang
2018-05-20 22:37 ` David Miller
2018-05-21 6:48 ` Wenwen Wang [this message]
2018-05-21 0:01 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAa=b7f3LA4GS18VfLouDLFYAsGifwbWb1DtMeWSGOCT64egug@mail.gmail.com' \
--to=wang6495@umn.edu \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).