From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wenwen Wang Subject: Re: [PATCH v2] isdn: eicon: fix a missing-check bug Date: Mon, 21 May 2018 01:48:31 -0500 Message-ID: References: <1526679228-1596-1-git-send-email-wang6495@umn.edu> <20180520.183730.1550159916165131561.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Kangjie Lu , Armin Schindler , Karsten Keil , "open list:NETWORKING [GENERAL]" , open list , Wenwen Wang To: David Miller Return-path: In-Reply-To: <20180520.183730.1550159916165131561.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, May 20, 2018 at 5:37 PM, David Miller wrote: > From: Wenwen Wang > Date: Fri, 18 May 2018 16:33:47 -0500 > >> In divasmain.c, the function divas_write() firstly invokes the function >> diva_xdi_open_adapter() to open the adapter that matches with the adapte= r >> number provided by the user, and then invokes the function diva_xdi_writ= e() >> to perform the write operation using the matched adapter. The two functi= ons >> diva_xdi_open_adapter() and diva_xdi_write() are located in diva.c. > > This doesn't even compile: > > In file included from drivers/isdn/hardware/eicon/divasmain.c:30: > drivers/isdn/hardware/eicon/diva.h:23:18: error: unknown type name =E2=80= =98diva_xdi_um_cfg_cmd_t=E2=80=99 > int length, diva_xdi_um_cfg_cmd_t *msg, > ^~~~~~~~~~~~~~~~~~~~~ > drivers/isdn/hardware/eicon/diva.h:27:20: error: unknown type name =E2=80= =98diva_xdi_um_cfg_cmd_t=E2=80=99 > int length, diva_xdi_um_cfg_cmd_t *msg, > ^~~~~~~~~~~~~~~~~~~~~ Sorry. I will correct the compilation errors and resubmit the patch. Wenwen