From: Samiullah Khawaja <skhawaja@google.com>
To: Kohei Enju <enjuk@amazon.com>
Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI
Date: Fri, 29 Aug 2025 08:37:48 -0700 [thread overview]
Message-ID: <CAAywjhSDz3F1uieMEuaFAtE2AKYXcv+5FjcDv3d4+T5ddWhy6Q@mail.gmail.com> (raw)
In-Reply-To: <20250829064857.51503-1-enjuk@amazon.com>
On Thu, Aug 28, 2025 at 11:49 PM Kohei Enju <enjuk@amazon.com> wrote:
>
> Commit 2677010e7793 ("Add support to set NAPI threaded for individual
> NAPI") introduced threaded NAPI configuration per individual NAPI
> instance, however obsolete description that threaded NAPI is per device
> has remained.
>
> Remove the old description and clarify that only NAPI instances running
> in threaded mode spawn kernel threads by changing "Each NAPI instance"
> to "Each threaded NAPI instance".
>
> Cc: Samiullah Khawaja <skhawaja@google.com>
> Signed-off-by: Kohei Enju <enjuk@amazon.com>
> ---
> Documentation/networking/napi.rst | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
> index a15754adb041..7dd60366f4ff 100644
> --- a/Documentation/networking/napi.rst
> +++ b/Documentation/networking/napi.rst
> @@ -433,9 +433,8 @@ Threaded NAPI
>
> Threaded NAPI is an operating mode that uses dedicated kernel
> threads rather than software IRQ context for NAPI processing.
> -The configuration is per netdevice and will affect all
> -NAPI instances of that device. Each NAPI instance will spawn a separate
> -thread (called ``napi/${ifc-name}-${napi-id}``).
> +Each threaded NAPI instance will spawn a separate thread
> +(called ``napi/${ifc-name}-${napi-id}``).
>
> It is recommended to pin each kernel thread to a single CPU, the same
> CPU as the CPU which services the interrupt. Note that the mapping
> --
> 2.48.1
>
>
Reviewed-by: Samiullah Khawaja <skhawaja@google.com>
next prev parent reply other threads:[~2025-08-29 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 6:48 [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI Kohei Enju
2025-08-29 15:37 ` Samiullah Khawaja [this message]
2025-09-01 20:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAywjhSDz3F1uieMEuaFAtE2AKYXcv+5FjcDv3d4+T5ddWhy6Q@mail.gmail.com \
--to=skhawaja@google.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enjuk@amazon.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).