From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A2ACC0650E for ; Mon, 1 Jul 2019 05:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCF542089F for ; Mon, 1 Jul 2019 05:09:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=endlessm-com.20150623.gappssmtp.com header.i=@endlessm-com.20150623.gappssmtp.com header.b="TVF/0x0y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbfGAFJV (ORCPT ); Mon, 1 Jul 2019 01:09:21 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:42373 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726483AbfGAFJV (ORCPT ); Mon, 1 Jul 2019 01:09:21 -0400 Received: by mail-qk1-f196.google.com with SMTP id b18so9996659qkc.9 for ; Sun, 30 Jun 2019 22:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M0+3rkTOxrBQnGgZwbRK/n9QcJ7Vj4bYLlp4CkN2fVs=; b=TVF/0x0ySR+gK3cDJBD7zack+c+4yrlXDC6HXULmlnKE0AUu9lB5G/+Zm48nzlSf9f SO/QedbVeeX4tDOiuPuO8Pcnjk5f3ne8M27we0Q9YpcHhzO9xJqQfR+RxLkTSxQtrkGc GO3hV64lu8bv1jWmbpGrMJeUjiOJbcqbm5ymh5lAR2zDYQ6oT29V9xhCrFyLmAaWQNUy VzmmgkRrgTMTlIS1ENbH/rSTU5Tww/nI5QxACSrMnYCPuAgAkDnCsnmgVlF+hljggEcy qzS6ycwoCaVLdU2kCz5krIaIyB/L1VfpvXEboUANpye+MJD40uzzB5ta6F/A40ZrFrkq kKdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M0+3rkTOxrBQnGgZwbRK/n9QcJ7Vj4bYLlp4CkN2fVs=; b=sYrTmMDSGF3zbKStGrOAGDUZiZrmnd0e+YhN9gIjkEsnXlAMr/rY/ofPv2lSLjyR9U PsNFki09Ga9ZFKxjLgVdN85ZwPZAiDCyPBJCYly0yWVwOnBP6CD1rJf+PEjszzRH4Z4R G+GZtQw27rYkgzVCWXuHzgDSa7CQG32iw81coPYs5np+ouGh3juW7x2jTaEoy7+MG8am y3nKYWEAuc86NGgpzHoD9ApZTbsZ+ckAeyQuI27hDqob3xtObAPutVNCx8TKb58Tcy8m 1zdnAV8Soo2Vo5Jx0tl4rHxOao2ITTnwJUosSY3haI/8+JsuDDh5M5jhv+h6UdsJ4hPg csxA== X-Gm-Message-State: APjAAAWG+B7QDxm7t/nE5fNMeomhOxg6edIqe2Tr+0DTJUOS6lOL1MRP xnQOGT2u10U86q5kXjkn/UP5WoZR+KK2AIinz9RBgg== X-Google-Smtp-Source: APXvYqxPXXMq+e6c2PMdwsMsZqvK6M7xzZTMcrRA5OHdGdm9CcEfDbc4yuhWL3bNvMjKuXVRF0G9orXxlMe58EWt/SY= X-Received: by 2002:a37:a484:: with SMTP id n126mr17603801qke.366.1561957759898; Sun, 30 Jun 2019 22:09:19 -0700 (PDT) MIME-Version: 1.0 References: <20190627095247.8792-1-chiu@endlessm.com> In-Reply-To: <20190627095247.8792-1-chiu@endlessm.com> From: Chris Chiu Date: Mon, 1 Jul 2019 13:09:09 +0800 Message-ID: Subject: Re: [PATCH] rtl8xxxu: Fix wifi low signal strength issue of RTL8723BU To: Jes Sorensen , Kalle Valo , David Miller Cc: linux-wireless , netdev , Linux Kernel , Linux Upstreaming Team Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 27, 2019 at 5:52 PM Chris Chiu wrote: > > The WiFi tx power of RTL8723BU is extremely low after booting. So > the WiFi scan gives very limited AP list and it always fails to > connect to the selected AP. This module only supports 1x1 antenna > and the antenna is switched to bluetooth due to some incorrect > register settings. > > This commit hand over the antenna control to PTA, the wifi signal > will be back to normal and the bluetooth scan can also work at the > same time. However, the btcoexist still needs to be handled under > different circumstances. If there's a BT connection established, > the wifi still fails to connect until disconneting the BT. > > Signed-off-by: Chris Chiu > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 9 ++++++--- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 ++- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c > index 3adb1d3d47ac..6c3c70d93ac1 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c > @@ -1525,7 +1525,7 @@ static void rtl8723b_enable_rf(struct rtl8xxxu_priv *priv) > /* > * WLAN action by PTA > */ > - rtl8xxxu_write8(priv, REG_WLAN_ACT_CONTROL_8723B, 0x04); > + rtl8xxxu_write8(priv, REG_WLAN_ACT_CONTROL_8723B, 0x0c); > > /* > * BT select S0/S1 controlled by WiFi > @@ -1568,9 +1568,12 @@ static void rtl8723b_enable_rf(struct rtl8xxxu_priv *priv) > rtl8xxxu_gen2_h2c_cmd(priv, &h2c, sizeof(h2c.ant_sel_rsv)); > > /* > - * 0x280, 0x00, 0x200, 0x80 - not clear > + * Different settings per different antenna position. > + * Antenna switch to BT: 0x280, 0x00 (inverse) > + * Antenna switch to WiFi: 0x0, 0x280 (inverse) > + * Antenna controlled by PTA: 0x200, 0x80 (inverse) > */ > - rtl8xxxu_write32(priv, REG_S0S1_PATH_SWITCH, 0x00); > + rtl8xxxu_write32(priv, REG_S0S1_PATH_SWITCH, 0x80); > > /* > * Software control, antenna at WiFi side > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > index 8136e268b4e6..87b2179a769e 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > @@ -3891,12 +3891,13 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw) > > /* Check if MAC is already powered on */ > val8 = rtl8xxxu_read8(priv, REG_CR); > + val16 = rtl8xxxu_read16(priv, REG_SYS_CLKR); > > /* > * Fix 92DU-VC S3 hang with the reason is that secondary mac is not > * initialized. First MAC returns 0xea, second MAC returns 0x00 > */ > - if (val8 == 0xea) > + if (val8 == 0xea || !(val16 & BIT(11))) > macpower = false; > else > macpower = true; > -- > 2.11.0 > Gentle ping. Cheers. Chris