From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [Xen-devel] [RFC v2 1/4] bridge: enable interfaces to opt out from becoming the root bridge Date: Fri, 21 Feb 2014 08:01:13 -0800 Message-ID: References: <1392433180-16052-1-git-send-email-mcgrof@do-not-panic.com> <1392433180-16052-2-git-send-email-mcgrof@do-not-panic.com> <20140216105754.63738163@nehalam.linuxnetplumber.net> <1392803559.23084.99.camel@kazak.uk.xensource.com> <5304C13F.3030802@citrix.com> <20140219090855.610c0e04@nehalam.linuxnetplumber.net> <20140220091958.62a8b444@nehalam.linuxnetplumber.net> <53074E6B.6030006@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Ian Campbell , kvm@vger.kernel.org, "netdev@vger.kernel.org" , bridge@lists.linux-foundation.org, "linux-kernel@vger.kernel.org" , Stephen Hemminger , xen-devel@lists.xenproject.org To: Zoltan Kiss Return-path: In-Reply-To: <53074E6B.6030006@citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Fri, Feb 21, 2014 at 5:02 AM, Zoltan Kiss wrote: >> Agreed that's the best strategy and I'll work on sending patches to >> brctl to enable the root_block preference. This approach however also > > I don't think brctl should deal with any Xen specific stuff. I assume there > is a misunderstanding in this thread: when I (and possibly other Xen folks) > talk about "userspace" or "toolstack" here, I mean Xen specific tools which > use e.g. brctl to set up bridges. Not brctl itself. I did mean brctl, but as I looked at the code it doesn't used rtnl_open() and not sure if Stephen would want that. Additionally even if it did handle root_block the other issue with this strategy is that as you noted upon initialization the bridge, without a static MAC address, could end up setting the backend as the root port, until you let userspace turn the root_block knob. Luis