From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rustad, Mark D" Subject: Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support Date: Tue, 27 Feb 2018 22:45:19 +0000 Message-ID: References: <20180226031911.18980.80488.stgit@mdrustad-mac04.local> <20180227.103502.2160088807348773566.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "virtio-dev@lists.oasis-open.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Daly, Dan" , "alex.williamson@redhat.com" , "MRustad@gmail.com" , "alexander.duyck@gmail.com" , "mst@redhat.com" To: David Miller Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20180227.103502.2160088807348773566.davem@davemloft.net> Content-Language: en-US Content-ID: List-Id: netdev.vger.kernel.org > On Feb 27, 2018, at 7:35 AM, David Miller wrote: >=20 > I don't like these helpers on many different levels. > So kill off pci_sriov_enable() helper completely, it is unnecessary, > and rename the disable helper so that it says something meaningful to > the reader. Yes. Once pointed out, I completely agree with your comments and wish that = I had seen those things myself. > Thanks. V3 was junk, but your comments apply to V4 as well, so please ignore it. Thank you for your valuable review. --=20 Mark Rustad, Networking Division, Intel Corporation