From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Caleb Connolly <caleb.connolly@linaro.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] bluetooth: hci_event: don't print an error on vendor events
Date: Wed, 2 Mar 2022 12:58:12 -0800 [thread overview]
Message-ID: <CABBYNZJPN6o-v2OpAXND0+UfwB3AQL2=r6CDQ0S8PktWZqijMw@mail.gmail.com> (raw)
In-Reply-To: <21F7790B-8849-4131-AF09-4E622B1A9E9D@holtmann.org>
Hi Marcel, Caleb,
On Wed, Mar 2, 2022 at 11:20 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Caleb,
>
> > Since commit 3e54c5890c87 ("Bluetooth: hci_event: Use of a function table to handle HCI events"),
> > some devices see warnings being printed for vendor events, e.g.
> >
> > [ 75.806141] Bluetooth: hci0: setting up wcn399x
> > [ 75.948311] Bluetooth: hci0: unexpected event 0xff length: 14 > 0
> > [ 75.955552] Bluetooth: hci0: QCA Product ID :0x0000000a
> > [ 75.961369] Bluetooth: hci0: QCA SOC Version :0x40010214
> > [ 75.967417] Bluetooth: hci0: QCA ROM Version :0x00000201
> > [ 75.973363] Bluetooth: hci0: QCA Patch Version:0x00000001
> > [ 76.000289] Bluetooth: hci0: QCA controller version 0x02140201
> > [ 76.006727] Bluetooth: hci0: QCA Downloading qca/crbtfw21.tlv
> > [ 76.986850] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.013574] Bluetooth: hci0: QCA Downloading qca/oneplus6/crnv21.bin
> > [ 77.024302] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.032681] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.040674] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.049251] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.057997] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.066320] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.075065] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.083073] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.091250] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.099417] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.110166] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.118672] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.127449] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.137190] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.146192] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.154242] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.163183] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.171202] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.179364] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.187259] Bluetooth: hci0: unexpected event 0xff length: 3 > 0
> > [ 77.198451] Bluetooth: hci0: QCA setup on UART is completed
> >
> > Avoid printing the event length warning for vendor events, this reverts
> > to the previous behaviour where such warnings weren't printed.
> >
> > Fixes: 3e54c5890c87 ("Bluetooth: hci_event: Use of a function table to handle HCI events")
> > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> > ---
> > Changes since v1:
> > * Don't return early! Vendor events still get parsed despite the
> > warning. I should have looked a little more closely at that...
> > ---
> > net/bluetooth/hci_event.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> patch has been applied to bluetooth-stable tree.
>
> Regards
>
> Marcel
I believe a proper fix has already been pushed to bluetooth-next:
https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=314d8cd2787418c5ac6b02035c344644f47b292b
HCI_EV_VENDOR shall be assumed to be variable length and that also
uses bt_dev_warn_ratelimited to avoid spamming the logs in case it
still fails.
--
Luiz Augusto von Dentz
next prev parent reply other threads:[~2022-03-02 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 18:35 [PATCH v2] bluetooth: hci_event: don't print an error on vendor events Caleb Connolly
2022-03-02 19:20 ` Marcel Holtmann
2022-03-02 20:58 ` Luiz Augusto von Dentz [this message]
2022-03-03 12:37 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABBYNZJPN6o-v2OpAXND0+UfwB3AQL2=r6CDQ0S8PktWZqijMw@mail.gmail.com' \
--to=luiz.dentz@gmail.com \
--cc=caleb.connolly@linaro.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).