From: Su Kang Yin <cantona@cantona.net>
To: linux-kernel@vger.kernel.org, nic_swsd@realtek.com,
romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: [PATCH 1/1] r8169.c correct MSIEnable register offset
Date: Wed, 14 Dec 2011 15:13:57 +0800 [thread overview]
Message-ID: <CABJLtPHWfRLcbzDFR0ZXe4da3jv04eDZL2CabF1FTcaadoy0xQ@mail.gmail.com> (raw)
correct MSIEnable (bit 5) register to Config1 (offset 0x52) instead of
Config2 (offset 0x53)
Signed-off-by: Su Kang Yin <cantona@cantona.net>
---
drivers/net/ethernet/realtek/r8169.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
index 67bf078..451835c 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -3430,18 +3430,18 @@ static unsigned rtl_try_msi(struct pci_dev
*pdev, void __iomem *ioaddr,
const struct rtl_cfg_info *cfg)
{
unsigned msi = 0;
- u8 cfg2;
+ u8 cfg1;
- cfg2 = RTL_R8(Config2) & ~MSIEnable;
+ cfg1 = RTL_R8(Config1) & ~MSIEnable;
if (cfg->features & RTL_FEATURE_MSI) {
if (pci_enable_msi(pdev)) {
dev_info(&pdev->dev, "no MSI. Back to INTx.\n");
} else {
- cfg2 |= MSIEnable;
+ cfg1 |= MSIEnable;
msi = RTL_FEATURE_MSI;
}
}
- RTL_W8(Config2, cfg2);
+ RTL_W8(Config1, cfg1);
return msi;
}
--
1.7.0.4
next reply other threads:[~2011-12-14 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 7:13 Su Kang Yin [this message]
2011-12-14 21:37 ` [PATCH 1/1] r8169.c correct MSIEnable register offset Francois Romieu
2011-12-15 6:43 ` David Miller
2011-12-15 8:34 ` hayeswang
2011-12-15 18:37 ` [PATCH] r8169: fix Config2 MSIEnable bit setting Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABJLtPHWfRLcbzDFR0ZXe4da3jv04eDZL2CabF1FTcaadoy0xQ@mail.gmail.com \
--to=cantona@cantona.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).