From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Zhou <azhou@ovn.org>
Subject: Re: [net-next sample action optimization 3/3] openvswitch: Optimize
 sample action for the clone use cases
Date: Mon, 13 Mar 2017 16:39:08 -0700
Message-ID: <CABKoBm01ieuSrbhf7yZH9AzZkTNB=kiOAhYTDoinXRtDhQoFoQ@mail.gmail.com>
References: <1489193500-15260-1-git-send-email-azhou@ovn.org>
 <1489193500-15260-4-git-send-email-azhou@ovn.org> <CAOrHB_CNyhQM5wVJvYNQtE8+RKLAbPrjsrQtbGe-poHi+5AW+g@mail.gmail.com>
 <CABKoBm14S4QRZCNYqBdfcVXrmvDnf3xrRXbDsBKGsMufdgeXZQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Joe Stringer <joe@ovn.org>
To: Pravin Shelar <pshelar@ovn.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:58241 "EHLO
        relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753336AbdCMXjx (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 13 Mar 2017 19:39:53 -0400
Received: from mfilter10-d.gandi.net (mfilter10-d.gandi.net [217.70.178.139])
        by relay4-d.mail.gandi.net (Postfix) with ESMTP id B7544172098
        for <netdev@vger.kernel.org>; Tue, 14 Mar 2017 00:39:51 +0100 (CET)
Received: from relay4-d.mail.gandi.net ([IPv6:::ffff:217.70.183.196])
        by mfilter10-d.gandi.net (mfilter10-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024)
        with ESMTP id VHWimwPJY-ts for <netdev@vger.kernel.org>;
        Tue, 14 Mar 2017 00:39:50 +0100 (CET)
Received: from mail-pg0-f49.google.com (mail-pg0-f49.google.com [74.125.83.49])
        (Authenticated sender: azhou@ovn.org)
        by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 37FD217209A
        for <netdev@vger.kernel.org>; Tue, 14 Mar 2017 00:39:50 +0100 (CET)
Received: by mail-pg0-f49.google.com with SMTP id b129so72805529pgc.2
        for <netdev@vger.kernel.org>; Mon, 13 Mar 2017 16:39:49 -0700 (PDT)
In-Reply-To: <CABKoBm14S4QRZCNYqBdfcVXrmvDnf3xrRXbDsBKGsMufdgeXZQ@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

>>> -       skb = skb_clone(skb, GFP_ATOMIC);
>>> -       if (!skb)
>>> -               /* Skip the sample action when out of memory. */
>>> -               return 0;
>>> +       if (key) {
>>> +               err = do_execute_actions(dp, skb, key, actions, rem);
>>> +       } else if (!add_deferred_actions(skb, orig, actions, rem)) {
>>>
>> We can refactor this code to avoid duplicate code all actions
>> implementation. This way there could be single function dealing with
>> both defered action and key fifo arrays.
>
> O.K. I will make the change in the next version.

After looking more at it, the sample action and recirc action are different
enough that I don't see clean ways refactor them. For example, recirc
needs to deal with setting recirc_id.  recirc calls
ovs_dp_process_packet, and sample calls do_execute_action.

>> I am not sure if we can put sample or recirc in "may not change flow"
>> actions list. Consider following set of actions:
>> sample(sample(set-IP)),userpsace(),...
>> In this case the userspace action could recieve skb with inconsistent
>> flow due to preceding of set action nested in the sample action.
>
> Good catch.  Will fix.

What's the objection on recirc action? It always works on clone key.