From: Andy Zhou <azhou@ovn.org>
To: Pravin Shelar <pshelar@ovn.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Joe Stringer <joe@ovn.org>
Subject: Re: [net-next sample action optimization v2 1/4] openvswitch: Deferred fifo API change.
Date: Thu, 16 Mar 2017 12:21:07 -0700 [thread overview]
Message-ID: <CABKoBm1sro_Bo4HMgPTTJYsd+XBNENMMy_vo1o2Fx_GRMN9v1Q@mail.gmail.com> (raw)
In-Reply-To: <CAOrHB_B9_HpA38SL8V66=wOi9enTpgQ_Di-Kf5CUJ0oLPS97xA@mail.gmail.com>
On Thu, Mar 16, 2017 at 10:28 AM, Pravin Shelar <pshelar@ovn.org> wrote:
> On Tue, Mar 14, 2017 at 4:08 PM, Andy Zhou <azhou@ovn.org> wrote:
>> add_deferred_actions() API currently requires actions to be passed in
>> as a fully encoded netlink message. So far both 'sample' and 'recirc'
>> actions happens to carry actions as fully encoded netlink messages.
>> However, this requirement is more restrictive than necessary, future
>> patch will need to pass in action lists that are not fully encoded
>> by themselves.
>
> It is not obvious why this change is required?
> can you explain it.
The original 'attr' requires a nested netlink message for the callee
to get the size of
the actions list. In the sample case, since we rewrite sample into an
internal format that
does not have actions encoded as a nested netlink, we will need to
pass both pointer
to the first action, and the size of the actions list.
next prev parent reply other threads:[~2017-03-16 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 23:08 [net-next sample action optimization v2 0/4] Andy Zhou
2017-03-14 23:08 ` [net-next sample action optimization v2 1/4] openvswitch: Deferred fifo API change Andy Zhou
2017-03-16 17:28 ` Pravin Shelar
2017-03-16 19:21 ` Andy Zhou [this message]
2017-03-14 23:08 ` [net-next sample action optimization v2 2/4] openvswitch: Refactor recirc key allocation Andy Zhou
2017-03-16 17:28 ` Pravin Shelar
2017-03-14 23:08 ` [net-next sample action optimization v2 3/4] openvswitch: Optimize sample action for the clone use cases Andy Zhou
2017-03-14 23:08 ` [net-next sample action optimization v2 4/4] Openvswitch: Refactor sample and recirc actions implementation Andy Zhou
2017-03-16 17:29 ` Pravin Shelar
2017-03-16 19:24 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABKoBm1sro_Bo4HMgPTTJYsd+XBNENMMy_vo1o2Fx_GRMN9v1Q@mail.gmail.com \
--to=azhou@ovn.org \
--cc=joe@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).