From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chaitanya Lala Subject: Re: i40e - Is i40e_force_link_state doing the right thing ? Date: Wed, 16 May 2018 08:35:49 -0700 Message-ID: References: <1F86EBA5C8668B468CEE1C33B96E862B36905DA1@IRSMSX104.ger.corp.intel.com> <1F86EBA5C8668B468CEE1C33B96E862B36905E19@IRSMSX104.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: "netdev@vger.kernel.org" , "Williams, Mitch A" , "Bowers, AndrewX" , "Kirsher, Jeffrey T" To: "Stachura, Mariusz" Return-path: Received: from mail-ua0-f173.google.com ([209.85.217.173]:34031 "EHLO mail-ua0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbeEPPgK (ORCPT ); Wed, 16 May 2018 11:36:10 -0400 Received: by mail-ua0-f173.google.com with SMTP id f22-v6so839921uam.1 for ; Wed, 16 May 2018 08:36:10 -0700 (PDT) In-Reply-To: <1F86EBA5C8668B468CEE1C33B96E862B36905E19@IRSMSX104.ger.corp.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Mariusz, ... On Wed, May 16, 2018 at 12:49 AM, Stachura, Mariusz wrote: >> Hi Mariusz, ... >> >> On Tue, May 15, 2018 at 2:24 PM, Stachura, Mariusz wrote: >>> On Tue, May 15, 2018 at 1:15 PM, Chaitanya Lala wrote: >>>> Hi, >>>> >>>> I am trying to bring up a Intel XL710 4x10G Intel card using the >>>> latest mainline top-of-tree. >>>> The problem is that "ifconfig up" and "ifconfig down" do not take >>>> effect at the link state level. >>>> I tracked the problem down to i40e_force_link_state() when it is >>>> called from i40e_down(). >>>> It calls i40e_force_link_state with "is_up" =3D=3D false. In-turn it >>>> calls, i40e_aq_set_link_restart_an(hw, true, NULL). >>>> >>>> Should the second argument of i40e_aq_set_link_restart_an be "is_up" >>>> vs the current "true" >>>> i.e. i40e_aq_set_link_restart_an(hw, is_up, NULL). ? When I make this >>>> change, the link state syncs-up with the interface administrative >>>> state. >>>> >>>> Is this a bug ? >>>> >>>> Thanks, >>>> Chaitanya >>> >>> Hello Chaitanya, >>> >>> i40e_down() calls i40e_force_link_state with "is_up" =3D=3D false only = if interface's private flag "link-down-on-close" is set. By default the lin= k is left up for manageability and VF traffic, user can use this flag to po= wer down the interface on the link level. Does that work for you? >>> The command is: >>> "ethtool --set-priv-flags IFNAME link-down-on-close on" and then >> >> This flag is _on_ in my setup and hencet i40e_force_link_state is being = called with is_up =3D=3D false in my setup. The problem is that irrespectiv= e of value of "is_up" flag, i40e_force_link_state invokes i40e_aq_set_link_= restart_an with second argument (enable_link) as "true". So i40e_aq_set_lin= k_restart_an is always trying to enable link even if is_up was false. Is th= at correct behavior ? >> >> I have pasted code with my annotations below marked with "//XXX". >> (...) >> Thanks, >> Chaitanya > > Hey, > i40e_aq_set_link_restart_an has second argument set to "true" intentional= ly, as I understand the "link-down-on-close" does not work for you, right? = I will double check if this feature works for me and get back to you, thank= you again. That's correct. Even with the flag set, if-down does not result in a link down for me. Thanks for checking! - Chaitanya > -------------------------------------------------------------------- > > Intel Technology Poland sp. z o.o. > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wy= dzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-= 316 | Kapital zakladowy 200.000 PLN. > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresa= ta i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej = wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jaki= ekolwiek > przegladanie lub rozpowszechnianie jest zabronione. > This e-mail and any attachments may contain confidential material for the= sole use of the intended recipient(s). If you are not the intended recipie= nt, please contact the sender and delete all copies; any review or distribu= tion by > others is strictly prohibited.