From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33A3C433EF for ; Sat, 2 Oct 2021 03:16:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D6C461159 for ; Sat, 2 Oct 2021 03:16:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232400AbhJBDSG (ORCPT ); Fri, 1 Oct 2021 23:18:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230386AbhJBDSF (ORCPT ); Fri, 1 Oct 2021 23:18:05 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6AEFC0613E5 for ; Fri, 1 Oct 2021 20:16:19 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id v127so8493620wme.5 for ; Fri, 01 Oct 2021 20:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eRRgfa1jwx7KE2gon3snTWAPopiduxwAu3R+KiFpgDY=; b=jx1xhiSilBXMu76bopUb6ItbtlOyagKNfcpW8OjlefPp7C0d9SNepFS4COaotvA8jj r7OHttaOwK5XCQiwsSDJzyaRUogxlqjBPElrCn6cf7zJpU31tlhEbTAsLQxXH97doSF6 Qc5lw9NjMGktXIEiKJKIj/Put4dMq15TkHIOUsVrZ1a4x2KH+v2eKQyEkaW5VNSDbmh6 s45uWM+XkrQGaowGAXL6HQA8Gk6F0XnNc811RlZgH/9nzDyu3Oe3yVgtBB5bjXx3+tRk 7fNDtYWlf1mNxQJiBG6dnWkUgjv/uboTFHzN3zsi++JFqm7MW6siwR3fXkQnUHs6Ezxs xmwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eRRgfa1jwx7KE2gon3snTWAPopiduxwAu3R+KiFpgDY=; b=tYndBv4HynCjx0zFz01H2vgIEHw4q8mqVKMdb3KEV1GhOiuc1X8bjFSwDEjn25EPbN piyuh7z3DJUwDrtPK62aJWajPwtdaO+fJvyTIocvN5e14uLNLPTzzKc5kcUPStpNe/4u mT+hD3aH/Gl2GwJqFECsmhXUmPfyiLGm1VI7j5yQ4jYvQ6+YQbawtoJNX2i25+Avqj5p o9pukaqHL5FA49RpdkfJWZRdL7gjrgHuaOuKB+TVjOXYH5Mis5BaJVE4w5IjnGX02HHo dGdumv8Hxrw9yWhOaVNSAvsdOIxGIQxQztWCclJUekoS0X47l1AFl7YMcdy28uYQTpd1 H1CQ== X-Gm-Message-State: AOAM533TEnoSs4Cv421BBE67C6p8AClWWyk/ZNOYfBkCtBucgmTDEm+G az2XclHY/Ppg3qKv/qA8pyvMhBQs055piTpHW00Y4PfK+pqF7A== X-Google-Smtp-Source: ABdhPJyO9HFau+hWBe01yGl1Ur2Sfe8aqf+C/e/nBua4KbCJn+N0dKGm6mZHbBD+nCv9dPEjsgY+dCtDl/jQ+YoArlQ= X-Received: by 2002:a05:600c:1c1d:: with SMTP id j29mr7500373wms.49.1633144578094; Fri, 01 Oct 2021 20:16:18 -0700 (PDT) MIME-Version: 1.0 References: <20211002022656.1681956-1-jk@codeconstruct.com.au> <20211002022656.1681956-2-jk@codeconstruct.com.au> In-Reply-To: <20211002022656.1681956-2-jk@codeconstruct.com.au> From: David Gow Date: Sat, 2 Oct 2021 11:16:07 +0800 Message-ID: Subject: Re: [PATCH net-next 2/2] mctp: test: defer mdev setup until we've registered To: Jeremy Kerr Cc: Networking , "David S. Miller" , Jakub Kicinski , Matt Johnston , Brendan Higgins , "open list:KERNEL SELFTEST FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Oct 2, 2021 at 10:27 AM Jeremy Kerr wrote: > > The MCTP device isn't available until we've registered the netdev, so > defer storing our convenience pointer. > > Signed-off-by: Jeremy Kerr > --- Haha -- you sent this just as I'd come up with the same patch here. :-) With these changes, alongside the rt->dev == NULL in mctp_route_release() crash fix mentioned in [1], the tests all pass on my system. (They also pass under KASAN, which bodes well.) This fix is, Reviewed-by: David Gow Cheers, -- David [1]: https://lore.kernel.org/linux-kselftest/163309440949.24017.15314464452259318665.git-patchwork-notify@kernel.org/T/#m1a319b6932dd2bffaf78ab2d3b4c399282f7bda2 > net/mctp/test/utils.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/net/mctp/test/utils.c b/net/mctp/test/utils.c > index e2ab1f3da357..cc6b8803aa9d 100644 > --- a/net/mctp/test/utils.c > +++ b/net/mctp/test/utils.c > @@ -46,17 +46,17 @@ struct mctp_test_dev *mctp_test_create_dev(void) > dev = netdev_priv(ndev); > dev->ndev = ndev; > > - rcu_read_lock(); > - dev->mdev = __mctp_dev_get(ndev); > - mctp_dev_hold(dev->mdev); > - rcu_read_unlock(); > - > rc = register_netdev(ndev); > if (rc) { > free_netdev(ndev); > return NULL; > } > > + rcu_read_lock(); > + dev->mdev = __mctp_dev_get(ndev); > + mctp_dev_hold(dev->mdev); > + rcu_read_unlock(); > + > return dev; > } > > -- > 2.30.2 >