From: Alexander Aring <alex.aring@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: dcaratti@redhat.com, Alexander Aring <aring@mojatatu.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
xiyou.wangcong@gmail.com, Jiri Pirko <jiri@resnulli.us>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
dsahern@gmail.com
Subject: Re: [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker
Date: Tue, 13 Feb 2018 11:58:11 -0500 [thread overview]
Message-ID: <CAB_54W7SL_Tf1TZMXmbJiU4+nrWOFy+=ModxucKLUamY_4q26Q@mail.gmail.com> (raw)
In-Reply-To: <20180213.111818.1744624787176430479.davem@davemloft.net>
Hi,
2018-02-13 11:18 GMT-05:00 David Miller <davem@davemloft.net>:
> From: Davide Caratti <dcaratti@redhat.com>
> Date: Tue, 13 Feb 2018 10:58:01 +0100
>
>> On Mon, 2018-02-12 at 15:19 -0500, Alexander Aring wrote:
>>>
>>> @@ -211,7 +212,8 @@ int tcf_generic_walker(struct tc_action_net *tn, struct sk_buff *skb,
>>> } else if (type == RTM_GETACTION) {
>>> return tcf_dump_walker(idrinfo, skb, cb);
>>> } else {
>>> - WARN(1, "tcf_generic_walker: unknown action %d\n", type);
>>> + WARN(1, "tcf_generic_walker: unknown command %d\n", type);
>>> + NL_SET_ERR_MSG(extack, "tcf_generic_walker: unknown command\n");
>>
>> minor nit: maybe we don't need the '\n' in the above message?
>
Yep, I will send v2.
Thanks.
- Alex
next prev parent reply other threads:[~2018-02-13 16:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 20:19 [PATCH net-next 0/8] net: sched: act: add extack support Alexander Aring
2018-02-12 20:19 ` [PATCH net-next 1/8] net: sched: act: fix code style Alexander Aring
2018-02-12 20:19 ` [PATCH net-next 2/8] net: sched: act: add extack to init Alexander Aring
2018-02-12 20:19 ` [PATCH net-next 3/8] net: sched: act: handle generic action errors Alexander Aring
2018-02-12 20:19 ` [PATCH net-next 4/8] net: sched: act: add extack to init callback Alexander Aring
2018-02-12 20:19 ` [PATCH net-next 5/8] net: sched: act: add extack for lookup callback Alexander Aring
2018-02-12 20:19 ` [PATCH net-next 6/8] net: sched: act: add extack for walk callback Alexander Aring
2018-02-12 20:19 ` [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker Alexander Aring
2018-02-13 9:58 ` Davide Caratti
2018-02-13 16:18 ` David Miller
2018-02-13 16:58 ` Alexander Aring [this message]
2018-02-12 20:19 ` [PATCH net-next 8/8] net: sched: act: mirred: add extack support Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB_54W7SL_Tf1TZMXmbJiU4+nrWOFy+=ModxucKLUamY_4q26Q@mail.gmail.com' \
--to=alex.aring@gmail.com \
--cc=aring@mojatatu.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).