From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28059C48BC2 for ; Wed, 23 Jun 2021 08:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04AB7610C7 for ; Wed, 23 Jun 2021 08:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbhFWIrY (ORCPT ); Wed, 23 Jun 2021 04:47:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbhFWIrW (ORCPT ); Wed, 23 Jun 2021 04:47:22 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40146C061756 for ; Wed, 23 Jun 2021 01:45:05 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id p7so2821770lfg.4 for ; Wed, 23 Jun 2021 01:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mnf/412BXT3SW6cMM4XrHUEIZkc2F6iPAGQOAC9hxkI=; b=HRe8ptDqAKO9fbUgdpEpgLH+fZ2WoPny5DL8SFLjklM1wPMdFyZ8rDTy5Zf6zytLuS yyW3HOR8JXPAcThdImno7gqL53pekgyvJAV+R0hQiNDQIQ1BNzjJDPX99dsjp6ueApbx S8iiesbcp2zi71iXH0Mdkm02Z96nIOuol/S3w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mnf/412BXT3SW6cMM4XrHUEIZkc2F6iPAGQOAC9hxkI=; b=d6PUJqZoXvMeKSf4xasPY+2hBh8kvdZW/FBUl0eJ9Jo23Pu1V4FIFSTrsjyW6M6Zb/ 2N+eIGOmmA7KJaaVDe9rIFLhAYSBhgCPZJaQywq70VrbE5f6jgvncESh8wdZapFPeeDE waIU3VQc/TVBrA1ONqi3MvUY2OqWczF5UUV+RI8Oax76yk8oRui2SBTmEbxQq9B2XL31 uCwEpR4wbBMjVURi1ZjJEqtcTXMk3zkTX6MRRM0+QxvSTAlWkDQLfp2nSYSz1+ealq29 7YSy6aSXgJrtJaZ/8pH840x5CR+BmRwX8eGDwRtioMQlNbT9NAxNhDMZitGSl5JtGnkT bFWQ== X-Gm-Message-State: AOAM531Wu0tJDANUqVsP/AvOA5AziKcADbXPxBZLYtDVImFPn0sIiSUp g5rpVhZ1k1HAnX/iJ7BtlgwluldULfnNkSwX/nsBzw== X-Google-Smtp-Source: ABdhPJzixrwlbsgihe9DSf0fQWrERfgmVQa0QAoHiwkWYylAeOsi7OM1vaTkpZk9MirF+w40feaVLpI7dAXAZ3q1yY0= X-Received: by 2002:ac2:4db6:: with SMTP id h22mr5928298lfe.171.1624437903317; Wed, 23 Jun 2021 01:45:03 -0700 (PDT) MIME-Version: 1.0 References: <20210618105526.265003-1-zenczykowski@gmail.com> In-Reply-To: <20210618105526.265003-1-zenczykowski@gmail.com> From: Lorenz Bauer Date: Wed, 23 Jun 2021 09:44:52 +0100 Message-ID: Subject: Re: [PATCH bpf] Revert "bpf: program: Refuse non-O_RDWR flags in BPF_OBJ_GET" To: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= Cc: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= , Alexei Starovoitov , Daniel Borkmann , Linux Network Development Mailing List , Linux Kernel Mailing List , BPF Mailing List , "David S . Miller" , Andrii Nakryiko , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 18 Jun 2021 at 11:55, Maciej =C5=BBenczykowski wrote: > > From: Maciej =C5=BBenczykowski > > This reverts commit d37300ed182131f1757895a62e556332857417e5. > > This breaks Android userspace which expects to be able to > fetch programs with just read permissions. > > See: https://cs.android.com/android/platform/superproject/+/master:framew= orks/libs/net/common/native/bpf_syscall_wrappers/include/BpfSyscallWrappers= .h;drc=3D7005c764be23d31fa1d69e826b4a2f6689a8c81e;l=3D124 As a follow up, what does Android expect to be able to do with this read only FD? Lorenz --=20 Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com