From: Jason Wang <jasowang@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Jakub Kicinski <kuba@kernel.org>, Cindy Lu <lulu@redhat.com>,
dtatulea@nvidia.com, mst@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
netdev@vger.kernel.org, Parav Pandit <parav@nvidia.com>
Subject: Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool
Date: Mon, 17 Jun 2024 09:48:17 +0800 [thread overview]
Message-ID: <CACGkMEtKFZwPpzjNBv2j6Y5L=jYTrW4B8FnSLRMWb_AtqqSSDQ@mail.gmail.com> (raw)
In-Reply-To: <ZmlAYcRHMqCgYBJD@nanopsycho.orion>
On Wed, Jun 12, 2024 at 2:30 PM Jiri Pirko <jiri@resnulli.us> wrote:
>
> Wed, Jun 12, 2024 at 03:58:10AM CEST, kuba@kernel.org wrote:
> >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote:
> >> Add new UAPI to support the mac address from vdpa tool
> >> Function vdpa_nl_cmd_dev_config_set_doit() will get the
> >> MAC address from the vdpa tool and then set it to the device.
> >>
> >> The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:**
> >
> >Why don't you use devlink?
>
> Fair question. Why does vdpa-specific uapi even exist? To have
> driver-specific uapi Does not make any sense to me :/
It came with devlink first actually, but switched to a dedicated uAPI.
Parav(cced) may explain more here.
Thanks
>
next prev parent reply other threads:[~2024-06-17 1:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 5:32 [PATCH 1/2] vdpa: support set mac address from vdpa tool Cindy Lu
2024-06-11 5:32 ` [PATCH 2/2] vdpa_sim_net: Add the support of set mac address Cindy Lu
2024-06-12 1:58 ` [PATCH 1/2] vdpa: support set mac address from vdpa tool Jakub Kicinski
2024-06-12 6:29 ` Jiri Pirko
2024-06-12 7:15 ` Michael S. Tsirkin
2024-06-12 7:22 ` Jiri Pirko
2024-06-13 6:49 ` Michael S. Tsirkin
2024-06-13 7:21 ` Jiri Pirko
2024-06-13 7:50 ` Michael S. Tsirkin
2024-06-13 14:46 ` Jiri Pirko
2024-06-17 1:48 ` Jason Wang [this message]
2024-06-17 2:57 ` Parav Pandit
2024-06-17 9:39 ` Jiri Pirko
2024-06-17 9:44 ` Parav Pandit
2024-06-17 11:39 ` Jiri Pirko
2024-06-17 11:48 ` Parav Pandit
2024-06-17 13:02 ` Jiri Pirko
2024-06-17 13:47 ` Michael S. Tsirkin
2024-06-17 15:20 ` Jakub Kicinski
2024-06-17 16:20 ` Michael S. Tsirkin
2024-06-17 16:44 ` Jakub Kicinski
2024-06-18 10:39 ` Michael S. Tsirkin
2024-06-19 13:10 ` Cindy Lu
2024-06-12 7:12 ` Michael S. Tsirkin
2024-06-13 6:44 ` Cindy Lu
2024-06-13 6:59 ` Michael S. Tsirkin
2024-06-13 13:29 ` Cindy Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACGkMEtKFZwPpzjNBv2j6Y5L=jYTrW4B8FnSLRMWb_AtqqSSDQ@mail.gmail.com' \
--to=jasowang@redhat.com \
--cc=dtatulea@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).