From: Jason Wang <jasowang@redhat.com>
To: liming.wu@jaguarmicro.com
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
398776277@qq.com
Subject: Re: [PATCH 2/2] tools/virtio: Add hints when module is not installed
Date: Sun, 8 Oct 2023 12:35:30 +0800 [thread overview]
Message-ID: <CACGkMEujvBtAx=1eTqSrzyjBde=0xpC9D0sRVC7wHHf_aqfqwg@mail.gmail.com> (raw)
In-Reply-To: <20230926050021.717-2-liming.wu@jaguarmicro.com>
On Tue, Sep 26, 2023 at 1:00 PM <liming.wu@jaguarmicro.com> wrote:
>
> From: Liming Wu <liming.wu@jaguarmicro.com>
>
> Need to insmod vhost_test.ko before run virtio_test.
> Give some hints to users.
>
> Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
> ---
> tools/virtio/virtio_test.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index 028f54e6854a..ce2c4d93d735 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -135,6 +135,10 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
> dev->buf = malloc(dev->buf_size);
> assert(dev->buf);
> dev->control = open("/dev/vhost-test", O_RDWR);
> +
> + if (dev->control < 0)
> + fprintf(stderr, "Install vhost_test module" \
> + "(./vhost_test/vhost_test.ko) firstly\n");
There should be many other reasons to fail for open().
Let's use strerror()?
Thanks
> assert(dev->control >= 0);
> r = ioctl(dev->control, VHOST_SET_OWNER, NULL);
> assert(r >= 0);
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-10-08 4:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 5:00 [PATCH 1/2] tools/virtio: Add dma sync api for virtio test liming.wu
2023-09-26 5:00 ` [PATCH 2/2] tools/virtio: Add hints when module is not installed liming.wu
2023-09-27 15:20 ` Michael S. Tsirkin
2023-10-07 6:55 ` [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test liming.wu
2023-10-07 6:55 ` [PATCH v2 2/2] tools/virtio: Add hints when module is not installed liming.wu
2023-10-08 2:19 ` [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test Xuan Zhuo
2023-10-08 3:03 ` Liming Wu
2023-10-08 4:35 ` Jason Wang [this message]
2023-10-09 2:44 ` [PATCH 2/2] tools/virtio: Add hints when module is not installed Liming Wu
2023-10-09 10:52 ` Michael S. Tsirkin
2023-10-08 4:37 ` [PATCH 1/2] tools/virtio: Add dma sync api for virtio test Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACGkMEujvBtAx=1eTqSrzyjBde=0xpC9D0sRVC7wHHf_aqfqwg@mail.gmail.com' \
--to=jasowang@redhat.com \
--cc=398776277@qq.com \
--cc=kvm@vger.kernel.org \
--cc=liming.wu@jaguarmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).