From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9DAEC433FE for ; Wed, 23 Nov 2022 05:51:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235405AbiKWFvW (ORCPT ); Wed, 23 Nov 2022 00:51:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiKWFvV (ORCPT ); Wed, 23 Nov 2022 00:51:21 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F21FAF240B for ; Tue, 22 Nov 2022 21:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669182625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JMYYiLCaB4GLtGxeCjzuDietMKLoY1I6jUe2ofSKrOo=; b=elUT7esQ7gat9NqRO20eXE+pUm92SbeHujAPS216ya1tydquDIxurVKiH7GVU10p6IHDM6 y8AsU2oUgOL6Dz836NCI2n7ex1gkxXs4IBRenSIbPw0lQMAjD8kYmgRFc0Vjw3iA1LGMzP YbJQhWZPQotHSLWgbrSbggdNIfgkrSs= Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-299-fQona7rPPUmYyYyMBlfjlQ-1; Wed, 23 Nov 2022 00:50:21 -0500 X-MC-Unique: fQona7rPPUmYyYyMBlfjlQ-1 Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-143248a54e5so993804fac.3 for ; Tue, 22 Nov 2022 21:50:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JMYYiLCaB4GLtGxeCjzuDietMKLoY1I6jUe2ofSKrOo=; b=LBA4inY+4GbfLW0QXOu9/Dg29MxlehjMvwBJpT4DEuYp+hBat0tux10tGO9Nkh5MgW zVzIranMfEsxp+Xm1wUc50rdD84Yf161IWlHTE0JG8/OFHaaTpxK7nWcXSmukSg27EFX UAZ+gLaOZf+F/k5aFOdxbBTvdU2Ir1vOEXXXIfFBRy0befXj/nmCqPOVNOvp5X49KNbQ ZkC3QUTPezRu8VxsLBhQM4xRnCtn0RtFRp2o1ydDuleE6cEAIrplkfbEXt9Df40Rb4u6 hThU3chBWzfCkmSRz1Wx3Mmn7gmSrOo+JLEVaLRekSQLF1pL3aG64XFFp5bTDOzOnpwH wRQA== X-Gm-Message-State: ANoB5pmYBH4G8ZUz5YOesWiAGe1Q6Dgcfsjb9qSCuA31SUnvDIqAfU29 9SvKoftxNdtQdk6zmkwCzqdOpv1/Z3ZkrfiKiDAK2Y2OVc5hGWDG8vgH04XL6TSO7bgVkgvQKLC kqKVun5PaoSRW+GCdNJWwsEvyPZHPN37+ X-Received: by 2002:a05:6808:220b:b0:359:f5eb:82ec with SMTP id bd11-20020a056808220b00b00359f5eb82ecmr3268509oib.280.1669182620983; Tue, 22 Nov 2022 21:50:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf4vUhvThjDXaYE0H+SpEJoxdmzmzDcZ/Xy2YPmdtfAXLakXiJ77qJrY4aA4PeK9ennZJJLXUGcaAYCvf5J5/sc= X-Received: by 2002:a05:6808:220b:b0:359:f5eb:82ec with SMTP id bd11-20020a056808220b00b00359f5eb82ecmr3268502oib.280.1669182620811; Tue, 22 Nov 2022 21:50:20 -0800 (PST) MIME-Version: 1.0 References: <20221117033303.16870-1-jasowang@redhat.com> In-Reply-To: From: Jason Wang Date: Wed, 23 Nov 2022 13:50:09 +0800 Message-ID: Subject: Re: [PATCH V2] vdpa: allow provisioning device features To: David Ahern Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, si-wei.liu@oracle.com, mst@redhat.com, eperezma@redhat.com, lingshan.zhu@intel.com, elic@nvidia.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 23, 2022 at 3:53 AM David Ahern wrote: > > On 11/16/22 8:33 PM, Jason Wang wrote: > > diff --git a/vdpa/include/uapi/linux/vdpa.h b/vdpa/include/uapi/linux/vdpa.h > > index 94e4dad1..7c961991 100644 > > --- a/vdpa/include/uapi/linux/vdpa.h > > +++ b/vdpa/include/uapi/linux/vdpa.h > > @@ -51,6 +51,7 @@ enum vdpa_attr { > > VDPA_ATTR_DEV_QUEUE_INDEX, /* u32 */ > > VDPA_ATTR_DEV_VENDOR_ATTR_NAME, /* string */ > > VDPA_ATTR_DEV_VENDOR_ATTR_VALUE, /* u64 */ > > + VDPA_ATTR_DEV_FEATURES, /* u64 */ > > > > /* new attributes must be added above here */ > > VDPA_ATTR_MAX, > > this header file already has: > ... > VDPA_ATTR_DEV_QUEUE_INDEX, /* u32 */ > VDPA_ATTR_DEV_VENDOR_ATTR_NAME, /* string */ > VDPA_ATTR_DEV_VENDOR_ATTR_VALUE, /* u64 */ > > VDPA_ATTR_DEV_FEATURES, /* u64 */ > > /* virtio features that are supported by the vDPA device */ > VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, /* u64 */ > > /* new attributes must be added above here */ > VDPA_ATTR_MAX, > > in which case your diff is not needed. More importantly it raises > questions about the status of the uapi file (is it correct as is or is > an update needed) and which tree you are creating patches against? I'm using git://git.kernel.org/pub/scm/network/iproute2/iproute2 main. But I don't pull the new codes before sending the patches. Will fix this. > > > @@ -615,8 +640,9 @@ static int cmd_mgmtdev(struct vdpa *vdpa, int argc, char **argv) > > static void cmd_dev_help(void) > > { > > fprintf(stderr, "Usage: vdpa dev show [ DEV ]\n"); > > - fprintf(stderr, " vdpa dev add name NAME mgmtdev MANAGEMENTDEV [ mac MACADDR ] [ mtu MTU ]\n"); > > - fprintf(stderr, " [ max_vqp MAX_VQ_PAIRS ]\n"); > > + fprintf(stderr, " vdpa dev add name NAME mgmtdevMANAGEMENTDEV [ device_features DEVICE_FEATURES]\n"); > > lost the space between mgmtdev and MANAGEMENTDEV Will fix it. Thanks > > > > + fprintf(stderr, " [ mac MACADDR ] [ mtu MTU ]\n"); > > + fprintf(stderr, " [ max_vqp MAX_VQ_PAIRS ]\n"); > > fprintf(stderr, " vdpa dev del DEV\n"); > > fprintf(stderr, "Usage: vdpa dev config COMMAND [ OPTIONS ]\n"); > > fprintf(stderr, "Usage: vdpa dev vstats COMMAND\n"); >