From: Michael Chan <michael.chan@broadcom.com>
To: Jon Maxwell <jmaxwell37@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Siva Reddy Kallam <siva.kallam@broadcom.com>,
"prashant.sreedharan@broadcom.com" <prashant@broadcom.com>,
"michael.chan@broadcom.com" <mchan@broadcom.com>,
Netdev <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
jmaxwell@redhat.com
Subject: Re: [net-next] tg3: allow ethtool -p to work for NICs in down state
Date: Mon, 1 Apr 2019 22:22:01 -0700 [thread overview]
Message-ID: <CACKFLi=kJ3FLuXFchVQ2mf0K09E7y5iVJNBTPsFZiv3Zaafitw@mail.gmail.com> (raw)
In-Reply-To: <20190402050756.20507-1-jmaxwell37@gmail.com>
On Mon, Apr 1, 2019 at 10:09 PM Jon Maxwell <jmaxwell37@gmail.com> wrote:
>
> Make tg3 behave like other drivers and let "ethtool -p" identify the
> NIC even when it's in the DOWN state. Before this patch it would get an
> error as follows if the NIC was down:
>
> # ip link set down dev em4
> # ethtool -p em4
> Cannot identify NIC: Resource temporarily unavailable
>
> With this patch ethtool identify works regardless of whether the NIC is up
> or down as it does for other drivers.
>
> Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
We used to power down the chip in tg3_close() and that's why we cannot
do ethtool -p after close. We don't do that any more so this is fine.
Thanks.
next prev parent reply other threads:[~2019-04-02 5:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 5:07 [net-next] tg3: allow ethtool -p to work for NICs in down state Jon Maxwell
2019-04-02 5:22 ` Michael Chan [this message]
2019-04-02 17:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACKFLi=kJ3FLuXFchVQ2mf0K09E7y5iVJNBTPsFZiv3Zaafitw@mail.gmail.com' \
--to=michael.chan@broadcom.com \
--cc=davem@davemloft.net \
--cc=jmaxwell37@gmail.com \
--cc=jmaxwell@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).