From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Chan Subject: Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef Date: Fri, 6 Oct 2017 18:27:31 -0700 Message-ID: References: <1a4d96f368f199bba0425012f50d55d634484cce.1507319311.git.jtoppins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Netdev , open list To: Jonathan Toppins Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: > There is no reason to wrap the data structures inside the ifdef. What's so bad about wrapping unused data structures inside #ifdef? These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is defined.