From: Michael Chan <michael.chan@broadcom.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW.
Date: Mon, 4 Dec 2017 10:11:38 -0800 [thread overview]
Message-ID: <CACKFLik-yLSCPMyV__CfDZaZfLWCHo6x74-7bWT+Ox1cVJfMpA@mail.gmail.com> (raw)
In-Reply-To: <CAJ3xEMghbGNkE5N2+aCMJK_nc2Yivyj2FYnFagTf9nF8xrew6g@mail.gmail.com>
On Mon, Dec 4, 2017 at 8:35 AM, Or Gerlitz <gerlitz.or@gmail.com> wrote:
> On Mon, Dec 4, 2017 at 1:12 PM, Michael Chan <michael.chan@broadcom.com> wrote:
>> Advertise NETIF_F_GRO_HW if hardware GRO is supported. Turn on or off
>> hardware GRO based on NETIF_F_GRO_HW.
>
> So the patch only deals with advertisement biz.. and I even failed to
> find a place where you arm
> something in the FW... so this just works OOB, all your buffers && skb
> logic && FW setup are fully
> ready for that? also, nothing you need to put differently on the SKB
> for HW GRO completions?
> can you explain this little further or it's all in your netdev slides...
>
All the logic is already in these 3 drivers in the tree. You can see
the additional logic in any of these drivers. It's just that these
drivers have been using NETIF_F_GRO to turn on this mode in
hardware/firmware. So these patches are just to switch over to use
the new flag to turn on this mode so that it can be independently
turned on or off.
next prev parent reply other threads:[~2017-12-04 18:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 11:12 [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW Michael Chan
2017-12-04 11:12 ` [PATCH net-next 1/4] net: " Michael Chan
2017-12-04 16:30 ` Or Gerlitz
2017-12-04 16:47 ` Alexander Duyck
2017-12-04 18:23 ` Michael Chan
2017-12-04 18:43 ` Alexander Duyck
2017-12-04 18:59 ` David Miller
2017-12-04 19:24 ` Alexander Duyck
2017-12-04 19:26 ` Eric Dumazet
2017-12-04 19:36 ` Alexander Duyck
2017-12-04 19:52 ` Michael Chan
2017-12-04 20:58 ` Alexander Duyck
2017-12-04 23:05 ` Michael Chan
2017-12-04 22:15 ` Yuval Mintz
2017-12-04 22:31 ` Michael Chan
2017-12-04 11:12 ` [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW Michael Chan
2017-12-04 16:35 ` Or Gerlitz
2017-12-04 18:11 ` Michael Chan [this message]
2017-12-04 21:06 ` Or Gerlitz
2017-12-04 22:00 ` Eric Dumazet
2017-12-05 0:07 ` Michael Chan
2017-12-05 18:10 ` Marcelo Ricardo Leitner
2017-12-06 21:04 ` Michael Chan
2017-12-04 11:12 ` [PATCH net-next 3/4] bnx2x: " Michael Chan
2017-12-04 11:12 ` [PATCH net-next 4/4] qede: " Michael Chan
2017-12-04 21:48 ` Yuval Mintz
2017-12-04 22:45 ` Michael Chan
2017-12-05 12:32 ` Chopra, Manish
2017-12-05 17:13 ` Michael Chan
2017-12-04 11:38 ` [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW Elior, Ariel
2017-12-05 19:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLik-yLSCPMyV__CfDZaZfLWCHo6x74-7bWT+Ox1cVJfMpA@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).