From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Chan Subject: Re: [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW. Date: Mon, 4 Dec 2017 10:11:38 -0800 Message-ID: References: <1512385967-32339-1-git-send-email-michael.chan@broadcom.com> <1512385967-32339-3-git-send-email-michael.chan@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: David Miller , Linux Netdev List To: Or Gerlitz Return-path: Received: from mail-oi0-f50.google.com ([209.85.218.50]:46465 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbdLDSLj (ORCPT ); Mon, 4 Dec 2017 13:11:39 -0500 Received: by mail-oi0-f50.google.com with SMTP id t81so12324830oih.13 for ; Mon, 04 Dec 2017 10:11:39 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Dec 4, 2017 at 8:35 AM, Or Gerlitz wrote: > On Mon, Dec 4, 2017 at 1:12 PM, Michael Chan wrote: >> Advertise NETIF_F_GRO_HW if hardware GRO is supported. Turn on or off >> hardware GRO based on NETIF_F_GRO_HW. > > So the patch only deals with advertisement biz.. and I even failed to > find a place where you arm > something in the FW... so this just works OOB, all your buffers && skb > logic && FW setup are fully > ready for that? also, nothing you need to put differently on the SKB > for HW GRO completions? > can you explain this little further or it's all in your netdev slides... > All the logic is already in these 3 drivers in the tree. You can see the additional logic in any of these drivers. It's just that these drivers have been using NETIF_F_GRO to turn on this mode in hardware/firmware. So these patches are just to switch over to use the new flag to turn on this mode so that it can be independently turned on or off.