From: Michael Chan <michael.chan@broadcom.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch,
pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com,
David Wei <dw@davidwei.uk>
Subject: Re: [PATCH net 3/3] bnxt_en: Update MRU and RSS table of RSS contexts on queue reset
Date: Tue, 20 May 2025 18:38:45 -0700 [thread overview]
Message-ID: <CACKFLikOwZmaucM4y2jMgKZ-s0vRyHBde+wuQRt33ScvfohyDA@mail.gmail.com> (raw)
In-Reply-To: <20250520182838.3f083f34@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Tue, May 20, 2025 at 6:28 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 19 May 2025 13:41:30 -0700 Michael Chan wrote:
> > @@ -15987,6 +16005,7 @@ static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx)
> >
> > bnxt_set_vnic_mru_p5(bp, vnic, 0);
> > }
> > + bnxt_set_rss_ctx_vnic_mru(bp, 0);
> > /* Make sure NAPI sees that the VNIC is disabled */
> > synchronize_net();
> > rxr = &bp->rx_ring[idx];
>
> What does setting MRU to zero do? All traffic will be dropped?
> Traffic will no longer be filtered based on MRU? Or.. ?
That VNIC with MRU set to zero will not receive any more traffic.
This step was recommended by the FW team when we first started working
with David to implement the queue_mgmt_ops.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4196 bytes --]
next prev parent reply other threads:[~2025-05-21 1:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 20:41 [PATCH net 0/3] bnxt_en: 2 bug fixes Michael Chan
2025-05-19 20:41 ` [PATCH net 1/3] bnxt_en: Fix netdev locking in ULP IRQ functions Michael Chan
2025-05-20 14:41 ` Simon Horman
2025-05-21 2:10 ` Jakub Kicinski
2025-05-19 20:41 ` [PATCH net 2/3] bnxt_en: Add a helper function to configure MRU and RSS Michael Chan
2025-05-20 14:41 ` Simon Horman
2025-05-20 14:57 ` David Wei
2025-05-19 20:41 ` [PATCH net 3/3] bnxt_en: Update MRU and RSS table of RSS contexts on queue reset Michael Chan
2025-05-20 14:42 ` Simon Horman
2025-05-20 14:59 ` David Wei
2025-05-21 1:28 ` Jakub Kicinski
2025-05-21 1:38 ` Michael Chan [this message]
2025-05-21 1:51 ` Jakub Kicinski
2025-05-21 2:10 ` Michael Chan
2025-05-21 2:17 ` Jakub Kicinski
2025-05-21 2:29 ` Michael Chan
2025-05-22 11:01 ` David Wei
2025-05-22 15:26 ` Jakub Kicinski
2025-05-27 15:37 ` David Wei
2025-05-27 16:50 ` Michael Chan
2025-05-21 2:20 ` [PATCH net 0/3] bnxt_en: 2 bug fixes patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2025-06-13 23:18 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
2025-06-13 23:18 ` [PATCH net 3/3] bnxt_en: Update MRU and RSS table of RSS contexts on queue reset Michael Chan
2025-06-16 13:38 ` Simon Horman
2025-06-16 17:40 ` Michael Chan
2025-06-16 20:48 ` Jakub Kicinski
2025-06-16 21:00 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLikOwZmaucM4y2jMgKZ-s0vRyHBde+wuQRt33ScvfohyDA@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).