From: Michael Chan <michael.chan@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] bnxt_en: Copy and paste bug in extended tx_stats
Date: Thu, 18 Oct 2018 07:32:52 -0700 [thread overview]
Message-ID: <CACKFLiknjz+sv4rxWPHO0aHVDn_acpaMJODYMxeBhpftV7UWhA@mail.gmail.com> (raw)
In-Reply-To: <20181018080239.z2egoh4bw4beb3r3@kili.mountain>
On Thu, Oct 18, 2018 at 1:02 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The struct type was copied from the line before but it should be "tx"
> instead of "rx". I have reviewed the code and I can't immediately see
> that this bug causes a runtime issue.
>
> Fixes: 36e53349b60b ("bnxt_en: Add additional extended port statistics.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks. Luckily, we did not use sizeof(*bp->hw_tx_port_stats_ext) to
allocate the memory, so there is no run-time issue.
Acked-by: Michael Chan <michael.chan@broadcom.com>
next prev parent reply other threads:[~2018-10-18 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 8:02 [PATCH net-next] bnxt_en: Copy and paste bug in extended tx_stats Dan Carpenter
2018-10-18 14:32 ` Michael Chan [this message]
2018-10-18 22:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLiknjz+sv4rxWPHO0aHVDn_acpaMJODYMxeBhpftV7UWhA@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).