From: Michael Chan <michael.chan@broadcom.com>
To: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>
Cc: Daniel Axtens <dja@axtens.net>, Netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: Stack sends oversize UDP packet to the driver
Date: Tue, 5 Feb 2019 11:35:56 -0800 [thread overview]
Message-ID: <CACKFLimWHQA_52D_6FZDOeJftXt-YqFOdADMDFTFuUkK__Ay2Q@mail.gmail.com> (raw)
In-Reply-To: <CAF2d9jiMMez62n7U+k02V7sRp9Q-usFC1X0-h8aqq-BtjmtVmA@mail.gmail.com>
On Wed, Jan 30, 2019 at 5:00 PM Mahesh Bandewar (महेश बंडेवार)
<maheshb@google.com> wrote:
>
> On Wed, Jan 30, 2019 at 1:07 AM Michael Chan <michael.chan@broadcom.com> wrote:
> >
> > On Tue, Jan 22, 2019 at 10:29 AM Mahesh Bandewar (महेश बंडेवार)
> > <maheshb@google.com> wrote:
> >
> > >
> > > The idea behind the fix is very simple and it is to create a dst-only
> > > (unregistered) device with a very low MTU and use it instead of 'lo'
> > > while invalidating the dst. This would make it *not* forward packets
> > > to driver which might need fragmentation.
> > >
> >
> > We tested the 2 patches many times and including an overnight test. I
> > can confirm that the oversize UDP packets are no longer seen with the
> > patches applied. However, I don't see the blackhole xmit function
> > getting called to free the SKBs though.
> >
> Thanks for the confirmation Michael. The blackhole device mtu is
> really small, so I would assume the fragmentation code dropped those
> packets before calling the xmit function (in ip_fragment), you could
> verify that with icmp counters.
>
I've looked at this a little more. The blackhole_dev is not IFF_UP |
IFF_RUNNING, right? May be that's why the packets are never getting
to the xmit function?
next prev parent reply other threads:[~2019-02-05 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 22:26 Stack sends oversize UDP packet to the driver Michael Chan
2019-01-22 0:36 ` Daniel Axtens
2019-01-22 0:59 ` Michael Chan
2019-01-22 18:28 ` Mahesh Bandewar (महेश बंडेवार)
2019-01-22 20:09 ` David Miller
2019-01-30 9:07 ` Michael Chan
2019-01-31 1:00 ` Mahesh Bandewar (महेश बंडेवार)
2019-02-05 19:35 ` Michael Chan [this message]
2019-02-07 4:51 ` Mahesh Bandewar (महेश बंडेवार)
2019-02-08 20:26 ` Mahesh Bandewar (महेश बंडेवार)
2019-02-12 8:55 ` Michael Chan
[not found] ` <CAF2d9jgskHTb-nmbVo9A2CQhh9T3OnH_vbfGcMBii13oq1teCw@mail.gmail.com>
2019-01-22 0:45 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLimWHQA_52D_6FZDOeJftXt-YqFOdADMDFTFuUkK__Ay2Q@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=davem@davemloft.net \
--cc=dja@axtens.net \
--cc=edumazet@google.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).