From: Michael Chan <michael.chan@broadcom.com>
To: "Chopra, Manish" <Manish.Chopra@cavium.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew.gospodarek@broadcom.com" <andrew.gospodarek@broadcom.com>,
"Elior, Ariel" <Ariel.Elior@cavium.com>,
Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@cavium.com>
Subject: Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.
Date: Thu, 14 Dec 2017 23:56:49 -0800 [thread overview]
Message-ID: <CACKFLimaFTMc62+VoSVNk+T8aT3snjwRPyXrZPeJ4hqXiE73KA@mail.gmail.com> (raw)
In-Reply-To: <BN3PR0701MB1412DAFEDB385E722073AD9F890B0@BN3PR0701MB1412.namprd07.prod.outlook.com>
On Thu, Dec 14, 2017 at 11:07 PM, Chopra, Manish
<Manish.Chopra@cavium.com> wrote:
> Michael, I checked it on again, I tried to set LRO in dev->features and dev->hw_features.
> Somehow, it gets disabled after register_netdevice(). Any idea why ? Although, I am not running any Bridge/bonding devices.
> Looks like, without this series also devices seems to have LRO disabled by default.
> Not sure why register_netdevice() disables LRO even driver populates this feature prior to register_netdevice().
May be you have ip forwarding enabled.
next prev parent reply other threads:[~2017-12-15 7:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 11:41 [PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW Michael Chan
2017-12-11 11:41 ` [PATCH net-next v4 1/5] net: " Michael Chan
2017-12-12 15:57 ` Alexander Duyck
2017-12-11 11:41 ` [PATCH net-next v4 2/5] net: Disable GRO_HW when generic XDP is installed on a device Michael Chan
2017-12-11 11:41 ` [PATCH net-next v4 3/5] bnxt_en: Use NETIF_F_GRO_HW Michael Chan
2017-12-11 11:41 ` [PATCH net-next v4 4/5] bnx2x: " Michael Chan
2017-12-13 9:08 ` Chopra, Manish
2017-12-13 20:45 ` Michael Chan
2017-12-14 7:46 ` Chopra, Manish
2017-12-14 7:59 ` Michael Chan
2017-12-15 7:07 ` Chopra, Manish
2017-12-15 7:56 ` Michael Chan [this message]
2017-12-11 11:41 ` [PATCH net-next v4 5/5] qede: " Michael Chan
2017-12-14 16:34 ` [PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW Or Gerlitz
2017-12-14 18:36 ` Michael Chan
2017-12-14 20:01 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLimaFTMc62+VoSVNk+T8aT3snjwRPyXrZPeJ4hqXiE73KA@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=Ariel.Elior@cavium.com \
--cc=Dept-EngEverestLinuxL2@cavium.com \
--cc=Manish.Chopra@cavium.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).