From: Michael Chan <michael.chan@broadcom.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Andrew Gospodarek <gospo@broadcom.com>
Subject: Re: [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features_check().
Date: Mon, 26 Apr 2021 09:45:17 -0700 [thread overview]
Message-ID: <CACKFLimdhTTD-vmfjkFDME_uHUBZTEMbUgA0WvSzjhPMjOPn_w@mail.gmail.com> (raw)
In-Reply-To: <CACKFLinRRcoaxsiHZyYcywgRtOs0E5hJdQ0gjHPAj3991gMzHw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Mon, Apr 26, 2021 at 9:35 AM Michael Chan <michael.chan@broadcom.com> wrote:
>
> On Mon, Apr 26, 2021 at 9:29 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Sun, 25 Apr 2021 13:45:27 -0400 Michael Chan wrote:
> > > + if (l4_proto != IPPROTO_UDP)
> > > + return features;
> >
> > This should have been "features & ~(CSUM | GSO)" if you actually
> > accepted my feedback.
Sorry, hit send too early. If it is not UDP, it could be GRE or IP
over IP for example, right? Why do we need to turn off offload?
> I mentioned extension headers as an example,
Extension headers (Geneve for example) are supported.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
next prev parent reply other threads:[~2021-04-26 16:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 17:45 [PATCH net-next v2 00/10] bnxt_en: Updates for net-next Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 01/10] bnxt_en: report signal mode in link up messages Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 02/10] bnxt_en: Add a new phy_flags field to the main driver structure Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 03/10] bnxt_en: Add support for fw managed link down feature Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 04/10] bnxt_en: allow promiscuous mode for trusted VFs Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 05/10] bnxt_en: allow VF config ops when PF is closed Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 06/10] bnxt_en: Move bnxt_approve_mac() Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 07/10] bnxt_en: Call bnxt_approve_mac() after the PF gives up control of the VF MAC Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 08/10] bnxt_en: Add PCI IDs for Hyper-V VF devices Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 09/10] bnxt_en: Support IFF_SUPP_NOFCS feature to transmit without ethernet FCS Michael Chan
2021-04-25 17:45 ` [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features_check() Michael Chan
2021-04-26 16:29 ` Jakub Kicinski
2021-04-26 16:35 ` Michael Chan
2021-04-26 16:45 ` Michael Chan [this message]
2021-04-26 17:00 ` Jakub Kicinski
2021-04-26 17:09 ` Michael Chan
2021-04-26 17:36 ` Jakub Kicinski
2021-04-26 17:52 ` Michael Chan
2021-04-26 2:00 ` [PATCH net-next v2 00/10] bnxt_en: Updates for net-next patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLimdhTTD-vmfjkFDME_uHUBZTEMbUgA0WvSzjhPMjOPn_w@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).