From: Michael Chan <michael.chan@broadcom.com>
To: Thinh Tran <thinhtr@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, siva.kallam@broadcom.com,
prashant@broadcom.com, mchan@broadcom.com,
pavan.chebbi@broadcom.com, drc@linux.vnet.ibm.com,
venkata.sai.duggi@ibm.com
Subject: Re: [PATCH v2] net/tg3: fix race condition in tg3_reset_task()
Date: Wed, 15 Nov 2023 10:56:57 -0800 [thread overview]
Message-ID: <CACKFLimy_DUPvMzApbgy7j701WCwkzTy_EARd1nmd+XKWC28kw@mail.gmail.com> (raw)
In-Reply-To: <bab94c00-c26e-4883-98c9-eb0a31b781fd@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On Wed, Nov 15, 2023 at 10:23 AM Thinh Tran <thinhtr@linux.vnet.ibm.com> wrote:
>
>
> On 11/14/2023 3:03 PM, Michael Chan wrote:
> >
> > Could you provide more information about the crashes? The
> > dev_watchdog() code already checks for netif_device_present() and
> > netif_running() and netif_carrier_ok() before proceeding to check for
> > TX timeout. Why would adding some additional checks for PCI errors
> > cause problems? Of course the additional checks should only be done
> > on PCI devices only. Thanks.
>
> The checking for PCI errors is not the problem, avoiding calling drivers
> ->ndo_tx_timeout() function, causing some issue.
I see. By skipping TX timeout during PCI errors, bnx2x crashes in
.ndo_start_xmit() after EEH error recovery.
I think it should be fine to fix the original EEH issue in tg3 then.
Please re-post the tg3 patch. Thanks.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
next prev parent reply other threads:[~2023-11-15 18:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 18:55 [PATCH] net/tg3: fix race condition in tg3_reset_task_cancel() Thinh Tran
2023-10-03 4:34 ` Pavan Chebbi
2023-10-31 23:18 ` Thinh Tran
2023-10-03 9:37 ` Michael Chan
2023-10-03 22:05 ` Thinh Tran
2023-11-02 16:02 ` Thinh Tran
2023-11-02 16:12 ` [PATCH v2] net/tg3: fix race condition in tg3_reset_task() Thinh Tran
2023-11-02 17:27 ` Michael Chan
2023-11-02 20:37 ` Thinh Tran
2023-11-14 17:39 ` Thinh Tran
2023-11-14 21:03 ` Michael Chan
2023-11-15 18:23 ` Thinh Tran
2023-11-15 18:56 ` Michael Chan [this message]
2023-11-16 14:41 ` Thinh Tran
2023-11-16 15:18 ` [PATCH v3] " Thinh Tran
2023-11-16 21:34 ` Michael Chan
2023-11-17 16:19 ` Thinh Tran
2023-11-17 18:31 ` Michael Chan
2023-11-30 22:29 ` Thinh Tran
2023-12-01 0:19 ` [PATCH v4] " Thinh Tran
2023-12-01 16:50 ` Michael Chan
2023-12-02 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLimy_DUPvMzApbgy7j701WCwkzTy_EARd1nmd+XKWC28kw@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=drc@linux.vnet.ibm.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
--cc=thinhtr@linux.vnet.ibm.com \
--cc=venkata.sai.duggi@ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).