Re: [PATCH net-next v2 3/3] eth: bnxt: support per-queue statistics

[Michael Chan <michael.chan@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

On Wed, Feb 28, 2024 at 5:02 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Support per-queue statistics API in bnxt.
>
> $ ethtool -S eth0
> NIC statistics:
>      [0]: rx_ucast_packets: 1418
>      [0]: rx_mcast_packets: 178
>      [0]: rx_bcast_packets: 0
>      [0]: rx_discards: 0
>      [0]: rx_errors: 0
>      [0]: rx_ucast_bytes: 1141815
>      [0]: rx_mcast_bytes: 16766
>      [0]: rx_bcast_bytes: 0
>      [0]: tx_ucast_packets: 1734
> ...
> +
> +static void bnxt_get_queue_stats_tx(struct net_device *dev, int i,
> +                                   struct netdev_queue_stats_tx *stats)
> +{
> +       struct bnxt *bp = netdev_priv(dev);
> +       u64 *sw;
> +
> +       sw = bp->bnapi[i]->cp_ring.stats.sw_stats;

Sorry I missed this earlier.  When we are in XDP mode, the first set
of TX rings is generally hidden from the user.  The standard TX rings
don't start from index 0.  They start from bp->tx_nr_rings_xdp.
Should we adjust for that?

> +
> +       stats->packets = 0;
> +       stats->packets += BNXT_GET_RING_STATS64(sw, tx_ucast_pkts);
> +       stats->packets += BNXT_GET_RING_STATS64(sw, tx_mcast_pkts);
> +       stats->packets += BNXT_GET_RING_STATS64(sw, tx_bcast_pkts);
> +
> +       stats->bytes = 0;
> +       stats->bytes += BNXT_GET_RING_STATS64(sw, tx_ucast_bytes);
> +       stats->bytes += BNXT_GET_RING_STATS64(sw, tx_mcast_bytes);
> +       stats->bytes += BNXT_GET_RING_STATS64(sw, tx_bcast_bytes);
> +}
> +

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]