From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1964C47257 for ; Sat, 9 May 2020 04:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8748A2184D for ; Sat, 9 May 2020 04:50:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="J16hc94N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728766AbgEIEuO (ORCPT ); Sat, 9 May 2020 00:50:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbgEIEuN (ORCPT ); Sat, 9 May 2020 00:50:13 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73271C05BD0A for ; Fri, 8 May 2020 21:50:13 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id s9so3210024qkm.6 for ; Fri, 08 May 2020 21:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o1JFY8qJmZXd/aUl9gDLLurD+wehBfsqo8Bz40G/nWw=; b=J16hc94Nk376MVeMGTdJs5OJAz/Ehej4THCEf4foNANL5Yu/B80oKDrU/aEmsxYPfE R6PyDEMbV0fqJYLmIXzRt4HBWSDOIp6+311zEYOxL2u8OEC7+60bkC3pBAib3EXph7Db TEgkBKRmiOWR8nxpGR7MNewvquOMd6dRRkxm8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o1JFY8qJmZXd/aUl9gDLLurD+wehBfsqo8Bz40G/nWw=; b=BrSkSqcrxBKlTiNCftFtC8nnbT2q5BAopANxxttOgNLJho0efkSC0dryS/H2uBexnH m9OehJCNhSW1YXKwEmM08jS/hW/6Si1RmtFYj430a0QDVL6ayugF5O2Y8nw3h/ticBMm LeYC5DRPBvKXNjYxnjn7p94ccDGCRHZT6wssdv5kxjP/oarhKN8dOcEAhzI2iLBdghF7 lSDPKKkqSbrIW20k6W+3rBm+9Zb5VYuQSJ1DwKMEcoyLZLO7pfgS0Qpot5kTReyOFZOi UO/dS8kxd+Lb8McUiM9Sit861tzNQO5oN/EkuwXQcDCIAMZBSnu3DfTr7diGaWetXv0k WC2w== X-Gm-Message-State: AGi0PuajsKFf61JYKUS3Y/4hTVeUUXTEAx6wf+nncUg51xt4sJ44SqT3 H9OueTJeMtf9DpHVC5qMqaNWlVc19z/M7s6Kr8QixW54 X-Google-Smtp-Source: APiQypJBp2r6Es5PVpPUyc2m1NAUrTMh1P00GZIlWuu0gAXEIz+sgXN+lihgtlNrzkjKnptXRPhsXJbgN7ojbaB5dNU= X-Received: by 2002:a37:7443:: with SMTP id p64mr6032310qkc.269.1588999812631; Fri, 08 May 2020 21:50:12 -0700 (PDT) MIME-Version: 1.0 References: <20200508224026.483746-1-colin.king@canonical.com> In-Reply-To: <20200508224026.483746-1-colin.king@canonical.com> From: Michael Chan Date: Fri, 8 May 2020 21:50:01 -0700 Message-ID: Subject: Re: [PATCH] cnic: remove redundant assignment to variable ret To: Colin King Cc: "David S . Miller" , Netdev , kernel-janitors@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 8, 2020 at 3:40 PM Colin King wrote: > > From: Colin Ian King > > The variable ret is being assigned with a value that is never read, > the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Michael Chan