From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DE1B147C60 for ; Wed, 19 Jun 2024 13:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718802688; cv=none; b=qUyJ8CT1XX1pjtD660H1KnVEsrGXfLFWHAuXnGpBpoHPRCLaynsxHrMBmAnFS0otBKGP2q75C8cDlM8T7D/Ob/+3OTB/c57GorLFLHpAW+tB5L4z0hAVGplMQw9dFXRw7yXuxVoyx4O7U3eMpBoMoaSp43Dnj+vnDbpJ0mYR+IM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718802688; c=relaxed/simple; bh=6MMx9/E3X3W91ugE851hUdJfDhuyenBEGy36UVjDJ3M=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FWT6maJVG87w9GHm/uJKz++xrr6ENg5nDmQQbdGNATEtUeBAA9naifZxvwmy2FPz/NVs2zYmch4rMJxqANFxccrfO3VWD56xzz15KnduiFinGsOWiSFxzVqEMgqz622WuBNAzC6O6lvSpbERdTz2PRap3HVy5i51KbB27OEtmjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ojlevmjd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ojlevmjd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718802683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RNygLwLxnRl00trKraz6/piCD3IZTxeSu/NBGyrNrIo=; b=OjlevmjdRki3yyQMPCBTTR5j/Mu7Yapb0HwttS6m63zV5Hku62GHP3ZFjozRxUCY0gBQtX AJseLsUqnft8Gs2A0Taizf7itPYBl6NqmQtHL0W1SMZd5cs7Wnn/R696RBgWsaXJRIJN+B o1nwFgS5FW+9VSyFagZWFtevl4qhmls= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-Rt6zr8RDMwudxubnimQr3Q-1; Wed, 19 Jun 2024 09:11:22 -0400 X-MC-Unique: Rt6zr8RDMwudxubnimQr3Q-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a6ec06ed579so357361266b.2 for ; Wed, 19 Jun 2024 06:11:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718802681; x=1719407481; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RNygLwLxnRl00trKraz6/piCD3IZTxeSu/NBGyrNrIo=; b=VCwAXjwfA54Xcqq81NRXxUYAHFn7VlQKKyCYnfTVBCEd+yYLlfkkTfceB5cIX+wvbX 2OUBN5Th67IwWh0PPCTJeG0mtgnb9cxmuBnsRAVx+cQrpgb+QkkN0cnDaz+opFeb1JZW mMDJewYB+a4ZV0PL3mUckQu+TdB58aMgCnPlZ6uRPYLkQY/zyJypbyfincbPv+bClq3x cnh2xi7owHGpqU3R8d/87lFt5vSiJdS+8zpeTmkYCWX08G9cEgS2acK+SAKWg2LE/njX r+zNmNndrJVRA2XRm+Hsn/x+JdQwLkIlic0EfqPZcr0ixEOQjK56NMqWss6ATPX4b/aL NGNA== X-Forwarded-Encrypted: i=1; AJvYcCXntGfVnxfeE1PFp3mlHK+rkJjCNw0dKstAKXtmJ0Jia68lVJi6lluoSYCsLLWxtVZxYKcdowQSkk7zBdJepZhG6X+/PUVt X-Gm-Message-State: AOJu0YzKrtDkIhWF5kMDCXuLv6++ivhBFBqWMlwpnMxBSp3FydzeLzSh ZLdkc6Cc4T6A5KbvSAb849HuRYE7a6AB+fmwFGiCxvepwZNWQ/oiycVBn9P5r65nyO3Spr9ewqJ +7tA0Q5XyxUT9H10oJ0Hby5poRy/zVqhg+Jh0SCRK5uKiHqKGDZBLajso8R32G8TjYpm/QCnj6Y oJomAf5/QnRG15RMPaF2yVb2PFt44L X-Received: by 2002:a17:906:31cc:b0:a6e:fb9b:676c with SMTP id a640c23a62f3a-a6fab7dcf3dmr132239766b.68.1718802681424; Wed, 19 Jun 2024 06:11:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEEEmubgGou+QZ+1kvAFjWIGTzn5KXKVv/pMwHZqrSCREnG5fUXo5Bg5YKnt2dpd+aruHL5m4QRsXhSoeJdF9M= X-Received: by 2002:a17:906:31cc:b0:a6e:fb9b:676c with SMTP id a640c23a62f3a-a6fab7dcf3dmr132238166b.68.1718802680997; Wed, 19 Jun 2024 06:11:20 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240617094314-mutt-send-email-mst@kernel.org> <20240617082002.3daaf9d4@kernel.org> <20240617121929-mutt-send-email-mst@kernel.org> <20240617094421.4ae387d7@kernel.org> <20240618063613-mutt-send-email-mst@kernel.org> In-Reply-To: <20240618063613-mutt-send-email-mst@kernel.org> From: Cindy Lu Date: Wed, 19 Jun 2024 21:10:41 +0800 Message-ID: Subject: Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool To: "Michael S. Tsirkin" Cc: Jakub Kicinski , Jiri Pirko , Parav Pandit , Jason Wang , Dragos Tatulea , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 18, 2024 at 6:39=E2=80=AFPM Michael S. Tsirkin = wrote: > > On Mon, Jun 17, 2024 at 09:44:21AM -0700, Jakub Kicinski wrote: > > On Mon, 17 Jun 2024 12:20:19 -0400 Michael S. Tsirkin wrote: > > > > But the virtio spec doesn't allow setting the MAC... > > > > I'm probably just lost in the conversation but there's hypervisor s= ide > > > > and there is user/VM side, each of them already has an interface to= set > > > > the MAC. The MAC doesn't matter, but I want to make sure my mental = model > > > > matches reality in case we start duplicating too much.. > > > > > > An obvious part of provisioning is specifying the config space > > > of the device. > > > > Agreed, that part is obvious. > > Please go ahead, I don't really care and you clearly don't have time > > to explain. > > Thanks! > Just in case Cindy who is working on it is also confused, > here is what I meant: > > - an interface to provision a device, including its config > space, makes sense to me > - default mac address is part of config space, and would thus be covered > - note how this is different from ability to tweak the mac of an existing > device > Thanks Micheal, I will continue working in this thanks cindy > > -- > MST >