From: Joel Stanley <joel@jms.id.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Andrew Jeffery <andrew@aj.id.au>,
Ivan Mikhaylov <i.mikhaylov@yadro.com>,
Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: ftgmac100: Fix crash when removing driver
Date: Mon, 16 Nov 2020 03:22:54 +0000 [thread overview]
Message-ID: <CACPK8XdW14+6p9nxmc9wrgqo2H3VBWqJRSS53qzn6-nXpCg0rQ@mail.gmail.com> (raw)
In-Reply-To: <20201112152241.7a3acaca@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, 12 Nov 2020 at 23:22, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 12 Nov 2020 11:01:45 +1030 Joel Stanley wrote:
> > When removing the driver we would hit BUG_ON(!list_empty(&dev->ptype_specific))
> > in net/core/dev.c due to still having the NC-SI packet handler
> > registered.
>
> > Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode")
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> Thanks for the fix, I think there is another one of those missing in
> the error path of ftgmac100_probe(), right? Under err_ncsi_dev?
You're correct, I'll send a v2.
prev parent reply other threads:[~2020-11-16 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 0:31 [PATCH] net: ftgmac100: Fix crash when removing driver Joel Stanley
2020-11-12 23:22 ` Jakub Kicinski
2020-11-16 3:22 ` Joel Stanley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XdW14+6p9nxmc9wrgqo2H3VBWqJRSS53qzn6-nXpCg0rQ@mail.gmail.com \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=davem@davemloft.net \
--cc=i.mikhaylov@yadro.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).