From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Genoud Subject: Re: hv_netvsc: WARNING in softirq.c Date: Tue, 19 Mar 2013 09:36:06 +0100 Message-ID: References: <20130228083437.GA28143@lnx-rg> <78fd1c1df13b449887de6e0b3505a988@DFM-DB3MBX15-06.exchange.corp.microsoft.com> <4147bb5a7cf547c19c6a5a6b459a957d@DFM-DB3MBX15-06.exchange.corp.microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" To: Haiyang Zhang Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org 2013/3/7 Richard Genoud : > 2013/3/6 Haiyang Zhang : >> I have found a simple way to reproduce this kind of warning: >> 1) reboot the VM (because this warning can be displayed only once.) >> 2) login to the host and open the VM [Settings] >> 3) Temporarily change the Network adapter's option [Virtual Switch] to "Not connected". >> 4) run dmesg, you should see the warning. >> >> The reason for the warning is -- netif_tx_disable() is called when the NIC >> is disconnected. And it's called within irq context. netif_tx_disable() >> calls local_bh_enable() which displays warning if in irq. >> >> The fix is to remove the unnecessary netif_tx_disable() in the netvsc_linkstatus_callback(). >> I attached a patch. Would you like to test it on your side as well? I installed the patched kernel today. here are the stats of the warings until today : kern.log.1:Mar 12 22:32:10 devlabo kernel: [30114.506299] ------------[ cut here ]------------ kern.log.2:Mar 5 22:30:48 devlabo kernel: [10455.098586] ------------[ cut here ]------------ kern.log.2:Mar 6 22:31:25 devlabo kernel: [85552.645480] ------------[ cut here ]------------ kern.log.3:Feb 26 22:35:14 devlabo kernel: [37398.788119] ------------[ cut here ]------------ kern.log.3:Feb 27 22:34:37 devlabo kernel: [10688.187196] ------------[ cut here ]------------ kern.log.4:Feb 22 22:32:22 devlabo kernel: [40399.795364] ------------[ cut here ]------------ So, I'll wait for one or two weeks before sending some feedback. Regards, Richard