From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74220C43381 for ; Mon, 4 Mar 2019 12:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 426F82075B for ; Mon, 4 Mar 2019 12:26:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mtG5AOtg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726182AbfCDM0d (ORCPT ); Mon, 4 Mar 2019 07:26:33 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42882 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbfCDM0d (ORCPT ); Mon, 4 Mar 2019 07:26:33 -0500 Received: by mail-lj1-f193.google.com with SMTP id d14so4138451ljl.9 for ; Mon, 04 Mar 2019 04:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cbtGedPGD7F9qQNMPHYXrEjPB6F4S+FNjsUdmefz4v4=; b=mtG5AOtgNj5fEJnG3+B9OmrgIv/UG0nipTv39l5TrEvI1q6EtzLhJeVtWPaj8vCC4O k49xzI/g6C3kj83JcAsz9Lro7LbRxRGh4+g+MoRVPiRqjaprvsgKOemtrAMUOwqNVrMR gx2fTdR52WoSvzUVNStmRsAj1WpoSFLw9R+0gOPAncArLFFvxNb6u7Tb/6uECk0dvNnZ u/T6mkxWXd8w4hBTTAXQK4dlYvjdFfAA0L6bufSTVjklUjoaZ53XHrKkKE7uibxAiOOs k3QeebNUqlMeaYBrVvqFr7oKiTY6Hk0LHxPQxIURHedp5ewvP+8fCojNcdTAYVhGRLZc /acQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cbtGedPGD7F9qQNMPHYXrEjPB6F4S+FNjsUdmefz4v4=; b=kE2ddtCBGAPwBU6T7mWWnZZi9a71wo65CRp5I9E9NsZmijs0hm8wpuqwvNnAtRqd8Q ANizJsCDuz5ll6W9s5EP8F24H2FKygiJCqKeIDcnNrAs/Iq7Hl92eO/Q29jtcxv2yHdb r7vBJ7WzeODRkoLuKqMQPdLISeJgE6KT0IVsnQ5KKQDFfjReenx5Kc+Vp2Nv+N+m3yer k4mOxdE2ke2Gg0QAHA2rtsYMKhJpxEZCUjFfbrb6vpYyEY0kWyNvZQ8kvkVP4WohGowD Ko89yHXZVdKHasQJyRN9Ex6tZtQNOjHZiNYIUIuNJBnZIHj2pGlxeJHi/ieSmIVFGT5C XxYw== X-Gm-Message-State: APjAAAUQ242UHH+UowIrm1QB52zUDFwyEcKDcI9rz/vf7Qjbx0DlaOM7 tpv/4zaJvfVt0ofyV1n6aMDBUDHa7yVAod5n5s2tjg== X-Google-Smtp-Source: APXvYqxMQyz0ZYWii20HeTbbzwBWEEh5i0FajLDl286+jxyetJWnCrxkxrLWQEm4bFjcTehvvGL7A3ZIKMrnWczQhhw= X-Received: by 2002:a2e:9217:: with SMTP id k23mr504877ljg.159.1551702391717; Mon, 04 Mar 2019 04:26:31 -0800 (PST) MIME-Version: 1.0 References: <3ad23735-38be-16ea-3bd0-c77eccc22f16@gmail.com> <20190303120839.17868-1-olteanv@gmail.com> In-Reply-To: From: Linus Walleij Date: Mon, 4 Mar 2019 13:26:20 +0100 Message-ID: Subject: Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver To: Vladimir Oltean Cc: Andrew Lunn , Florian Fainelli , netdev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Vladimir, On Mon, Mar 4, 2019 at 1:14 PM Vladimir Oltean wrote: > I may be in error, but I don't think we have the same understanding of what > VLAN filtering is. As far as I understand, no VLAN filtering means that > hardware is required to not parse, push or pop VLAN tags in whatever frames > it receives or sends (tagged or not). Conversely, VLAN filtering enabled means > hardware is required to parse VLAN information and enforce port membership. OK I get it now, I hope I don't forget it the next 5 minutes. I think I have the wrong mental model about a whole lot of things regarding VLANs. > Now, this is orthogonal to forwarding, in a way. I believe that if you want > to isolate two front-panel ports from other two front-panel ports (be they WAN > or LAN), you would want to add them to different bridges (br0 and br1). > But indeed forwarding domain can also be limited using VLAN. In this case a > frame will be passed from one port to another based on a compound decision > (L2 forwarding rules allow AND VLAN port membership domain allows). You would > want to use VLAN when you want a single port to be a member of multiple > domains, because you can't put a single netdevice (front-panel switch port) > in multiple bridges. > All I'm really saying is that I don't think that inside the port_bridge_join > callback, configuring forwarding based on VLAN is a sane thing to do. > > I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge > membership callbacks, and as I don't happen to know nearly enough about DSA, I > wonder at what moment in time does forwarding get activated between ports. I think I should seriously look at other DSA drivers implementing this because I think that is what I really want to achieve here. Yours, Linus Walleij