From: Linus Walleij <linus.walleij@linaro.org>
To: cgel.zte@gmail.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
arnd@arndb.de, lv.ruyi@zte.com.cn, wanjiabing@vivo.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] ixp4xx_eth: fix error check return value of platform_get_irq()
Date: Tue, 12 Apr 2022 15:45:21 +0200 [thread overview]
Message-ID: <CACRpkdY87j7-Gm6fPM_MXBZvLsHWCPVU3gdbv1b=vB+L-Mn5QA@mail.gmail.com> (raw)
In-Reply-To: <20220412085126.2532924-1-lv.ruyi@zte.com.cn>
On Tue, Apr 12, 2022 at 10:51 AM <cgel.zte@gmail.com> wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> platform_get_irq() return negative value on failure, so null check of
> return value is incorrect. Fix it by comparing whether it is less than
> zero.
>
> Fixes: 9055a2f59162 ("ixp4xx_eth: make ptp support a platform driver")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-04-12 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 8:51 [PATCH] ixp4xx_eth: fix error check return value of platform_get_irq() cgel.zte
2022-04-12 13:45 ` Linus Walleij [this message]
2022-04-12 22:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY87j7-Gm6fPM_MXBZvLsHWCPVU3gdbv1b=vB+L-Mn5QA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=cgel.zte@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wanjiabing@vivo.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).