From: Linus Walleij <linus.walleij@linaro.org>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: tag_rtl4_a: Drop bit 9 from egress frames
Date: Thu, 23 Sep 2021 23:59:36 +0200 [thread overview]
Message-ID: <CACRpkdYu7Q5Y88YmBzcBBGycmW92dd0jVhJNUpDFyd65bBq52A@mail.gmail.com> (raw)
In-Reply-To: <20210915071901.1315-1-dqfext@gmail.com>
On Wed, Sep 15, 2021 at 9:20 AM DENG Qingfang <dqfext@gmail.com> wrote:
> On Mon, Sep 13, 2021 at 04:31:56PM +0200, Linus Walleij wrote:
> > This drops the code setting bit 9 on egress frames on the
> > Realtek "type A" (RTL8366RB) frames.
>
> FYI, on RTL8366S, bit 9 on egress frames is disable learning.
>
> > This bit was set on ingress frames for unknown reason,
>
> I think it could be the reason why the frame is forwarded to the CPU.
Hm I suspect it disable learning on RTL8366RB as well.
Do we have some use for that feature in DSA taggers?
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-09-23 21:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:31 [PATCH net-next] net: dsa: tag_rtl4_a: Drop bit 9 from egress frames Linus Walleij
2021-09-13 16:05 ` Andrew Lunn
2021-09-13 16:06 ` Florian Fainelli
2021-09-15 3:10 ` patchwork-bot+netdevbpf
2021-09-15 7:19 ` DENG Qingfang
2021-09-23 21:59 ` Linus Walleij [this message]
2021-09-23 22:12 ` Vladimir Oltean
2021-09-23 22:21 ` Linus Walleij
2021-09-23 22:25 ` Vladimir Oltean
2021-09-23 22:58 ` Linus Walleij
2021-09-23 23:11 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYu7Q5Y88YmBzcBBGycmW92dd0jVhJNUpDFyd65bBq52A@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).