From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Anders Roxell <anders.roxell@linaro.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names
Date: Sat, 8 Jun 2019 01:21:54 +0200 [thread overview]
Message-ID: <CACRpkdZdQPuLKtpsgA4zUeFhubeTwajDUAzvsQ9RY0Q3WFKxcQ@mail.gmail.com> (raw)
In-Reply-To: <20190606125024.GE20899@lunn.ch>
On Thu, Jun 6, 2019 at 2:50 PM Andrew Lunn <andrew@lunn.ch> wrote:
> On Thu, Jun 06, 2019 at 11:47:07AM +0200, Anders Roxell wrote:
> > When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
> > enabled as loadable modules, we see the following warning:
> >
> > warning: same module names found:
> > drivers/net/phy/realtek.ko
> > drivers/net/dsa/realtek.ko
> >
> > Rework so the names matches the config fragment.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> [Removes most of the Cc:]
>
> Hi Anders
>
> Please base this patch on net-next and submit it to David
> Miller/netdev.
>
> It would also be nice to state the new name of the module in the
> commit message.
>
> Linus, would you prefer this module is called rtl8366?
Yes that should be unique enough!
Anders: thanks for looking into this. I just always compiled
all modules as y.
Yours,
Linus Walleij
prev parent reply other threads:[~2019-06-07 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 9:47 [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names Anders Roxell
2019-06-06 12:50 ` Andrew Lunn
2019-06-07 23:21 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZdQPuLKtpsgA4zUeFhubeTwajDUAzvsQ9RY0Q3WFKxcQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=anders.roxell@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).