From: Linus Walleij <linus.walleij@linaro.org>
To: "Alvin Šipraga" <alvin@pqrs.dk>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Michael Rasmussen" <mir@bang-olufsen.dk>,
netdev <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 6/7] net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC
Date: Sun, 17 Oct 2021 00:32:21 +0200 [thread overview]
Message-ID: <CACRpkdbQyZcEYRdt=QusrKYufgBf7ROEc0eQY_MN559hM40naw@mail.gmail.com> (raw)
In-Reply-To: <20211015171030.2713493-7-alvin@pqrs.dk>
On Fri, Oct 15, 2021 at 7:11 PM Alvin Šipraga <alvin@pqrs.dk> wrote:
> This patch adds a realtek-smi subdriver for the RTL8365MB-VC 4+1 port
> 10/100/1000M switch controller. The driver has been developed based on a
> GPL-licensed OS-agnostic Realtek vendor driver known as rtl8367c found
> in the OpenWrt source tree.
This version is really nice!
> v2 -> v3:
> - following the stats change, it became apparent that the rtl8366
> helper library is no longer that helpful; scrap it and implement
> the ethtool ops specifically for this chip
I wonder if I should just scrap it in general when I convert RTL8366RB over
to use your new nice callbacks? Just push that part down into the
driver for each chip.
I vaguely remember the RTL8366S having the same counters though...
(I think this is why it is in the shared library at all.)
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-10-16 22:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 17:10 [PATCH v3 net-next 0/7] net: dsa: add support for RTL8365MB-VC Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 1/7] ether: add EtherType for proprietary Realtek protocols Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 2/7] net: dsa: allow reporting of standard ethtool stats for slave devices Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 3/7] net: dsa: move NET_DSA_TAG_RTL4_A to right place in Kconfig/Makefile Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 4/7] dt-bindings: net: dsa: realtek-smi: document new compatible rtl8365mb Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 5/7] net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag Alvin Šipraga
2021-10-16 6:04 ` DENG Qingfang
2021-10-18 7:58 ` Alvin Šipraga
2021-10-15 17:10 ` [PATCH v3 net-next 6/7] net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC Alvin Šipraga
2021-10-16 0:40 ` Jakub Kicinski
2021-10-16 10:39 ` Alvin Šipraga
2021-10-16 4:29 ` kernel test robot
2021-10-16 22:32 ` Linus Walleij [this message]
2021-10-15 17:10 ` [PATCH v3 net-next 7/7] net: phy: realtek: add support for RTL8365MB-VC internal PHYs Alvin Šipraga
2021-10-16 9:13 ` [PATCH v3 net-next 0/7] net: dsa: add support for RTL8365MB-VC Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbQyZcEYRdt=QusrKYufgBf7ROEc0eQY_MN559hM40naw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alsi@bang-olufsen.dk \
--cc=alvin@pqrs.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mir@bang-olufsen.dk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).